Use t.Run for /pkg/cri tests

A majority of the tests in /pkg/cri are testing/validating multiple
things per test (generally spec or options validations). This flow
lends itself well to using *testing.T's Run method to run each thing
as a subtest so `go test` output can actually display which subtest
failed/passed.

Some of the tests in the packages in pkg/cri already did this, but
a bunch simply logged what sub-testcase was currently running without
invoking t.Run.

Signed-off-by: Daniel Canter <dcanter@microsoft.com>

pkg/cri/server/container_create_test.go

@@ -187,21 +187,22 @@ func TestContainerSpecCommand(t *testing.T) {
 			expectErr: true,
 		},
 	} {
+		t.Run(desc, func(t *testing.T) {
+			config, _, imageConfig, _ := getCreateContainerTestData()
+			config.Command = test.criEntrypoint
+			config.Args = test.criArgs
+			imageConfig.Entrypoint = test.imageEntrypoint
+			imageConfig.Cmd = test.imageArgs
 
-		config, _, imageConfig, _ := getCreateContainerTestData()
-		config.Command = test.criEntrypoint
-		config.Args = test.criArgs
-		imageConfig.Entrypoint = test.imageEntrypoint
-		imageConfig.Cmd = test.imageArgs
-
-		var spec runtimespec.Spec
-		err := opts.WithProcessArgs(config, imageConfig)(context.Background(), nil, nil, &spec)
-		if test.expectErr {
-			assert.Error(t, err)
-			continue
-		}
-		assert.NoError(t, err)
-		assert.Equal(t, test.expected, spec.Process.Args, desc)
+			var spec runtimespec.Spec
+			err := opts.WithProcessArgs(config, imageConfig)(context.Background(), nil, nil, &spec)
+			if test.expectErr {
+				assert.Error(t, err)
+				return
+			}
+			assert.NoError(t, err)
+			assert.Equal(t, test.expected, spec.Process.Args, desc)
+		})
 	}
 }
 
@@ -253,26 +254,27 @@ func TestVolumeMounts(t *testing.T) {
 			},
 		},
 	} {
-		t.Logf("TestCase %q", desc)
-		config := &imagespec.ImageConfig{
-			Volumes: test.imageVolumes,
-		}
-		c := newTestCRIService()
-		got := c.volumeMounts(testContainerRootDir, test.criMounts, config)
-		assert.Len(t, got, len(test.expectedMountDest))
-		for _, dest := range test.expectedMountDest {
-			found := false
-			for _, m := range got {
-				if m.ContainerPath == dest {
-					found = true
-					assert.Equal(t,
-						filepath.Dir(m.HostPath),
-						filepath.Join(testContainerRootDir, "volumes"))
-					break
-				}
+		t.Run(desc, func(t *testing.T) {
+			config := &imagespec.ImageConfig{
+				Volumes: test.imageVolumes,
 			}
-			assert.True(t, found)
-		}
+			c := newTestCRIService()
+			got := c.volumeMounts(testContainerRootDir, test.criMounts, config)
+			assert.Len(t, got, len(test.expectedMountDest))
+			for _, dest := range test.expectedMountDest {
+				found := false
+				for _, m := range got {
+					if m.ContainerPath == dest {
+						found = true
+						assert.Equal(t,
+							filepath.Dir(m.HostPath),
+							filepath.Join(testContainerRootDir, "volumes"))
+						break
+					}
+				}
+				assert.True(t, found)
+			}
+		})
 	}
 }