github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

replace some fmt.Sprintfs with strconv

Browse Source 
Teeny-tiny optimizations:

    BenchmarkSprintf-10       37735996    32.31  ns/op  0 B/op  0 allocs/op
    BenchmarkItoa-10         591945836     2.031 ns/op  0 B/op  0 allocs/op
    BenchmarkFormatUint-10   593701444     2.014 ns/op  0 B/op  0 allocs/op

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2023-06-23 13:06:48 +02:00
parent 11a5dd8265
commit b76cd4d9fd
No known key found for this signature in database
GPG Key ID: 76698F39D527CE8C
5 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/ctr/commands/snapshots/snapshots.go
View File

@ -23,6 +23,7 @@ import (
"io"
"os"
"path/filepath"
"strconv"
"strings"
"text/tabwriter"
"time"
@ -207,7 +208,7 @@ var usageCommand = cli.Command{
var displaySize func(int64) string
if context.Bool("b") {
displaySize = func(s int64) string {
return fmt.Sprintf("%d", s)
return strconv.FormatInt(s, 10)
}
} else {
displaySize = func(s int64) string {

4
integration/client/daemon_config_linux_test.go
View File

@ -18,9 +18,9 @@ package client
import (
"bufio"
"fmt"
"os"
"path/filepath"
"strconv"
"strings"
"syscall"
"testing"
@ -133,7 +133,7 @@ func TestDaemonCustomCgroup(t *testing.T) {
t.Skip("skip TestDaemonCustomCgroup since no cgroup path available")
}
customCgroup := fmt.Sprintf("%d", time.Now().Nanosecond())
customCgroup := strconv.Itoa(time.Now().Nanosecond())
configTOML := `
version = 2
[cgroup]

2
integration/nri_test.go
View File

@ -602,7 +602,7 @@ func (tc *nriTest) setup() {
tc.prefix = strings.ToLower(tc.name)
}
if tc.namespace == "" {
tc.namespace = tc.prefix + "-" + fmt.Sprintf("%d", os.Getpid())
tc.namespace = tc.prefix + "-" + strconv.Itoa(os.Getpid())
}
tc.sbCfg = make(map[string]*runtime.PodSandboxConfig)

2
pkg/cri/sbserver/helpers.go
View File

@ -151,7 +151,7 @@ func makeContainerName(c *runtime.ContainerMetadata, s *runtime.PodSandboxMetada
s.Name, // 1: pod name
s.Namespace, // 2: pod namespace
s.Uid, // 3: pod uid
strconv.FormatUint(uint64(s.Attempt), 10), // 4: attempt number of creating the container
strconv.FormatUint(uint64(c.Attempt), 10), // 4: attempt number of creating the container
}, nameDelimiter)
}

2
pkg/cri/server/helpers.go
View File

@ -112,7 +112,7 @@ func makeContainerName(c *runtime.ContainerMetadata, s *runtime.PodSandboxMetada
s.Name, // 1: pod name
s.Namespace, // 2: pod namespace
s.Uid, // 3: pod uid
strconv.FormatUint(uint64(s.Attempt), 10), // 4: attempt number of creating the container
strconv.FormatUint(uint64(c.Attempt), 10), // 4: attempt number of creating the container
}, nameDelimiter)
}