github/containerd
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Use cgroups.AddProc() for cgroups v1

Browse Source 
All occurrences only passed a PID, so we can use this utility to make
the code more symmetrical with their cgroups v2 counterparts.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn
2021-07-15 10:17:44 +02:00
parent f8585d632a
commit c091d48cb9
4 changed files with 4 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
runtime/v1/shim/client/client_linux.go
View File

@@ -35,9 +35,7 @@ func setCgroup(cgroupPath string, cmd *exec.Cmd) error {
if err != nil { if err != nil {
return fmt.Errorf("failed to load cgroup %s: %w", cgroupPath, err) return fmt.Errorf("failed to load cgroup %s: %w", cgroupPath, err)
} }
if err := cg.Add(cgroups.Process{ if err := cg.AddProc(uint64(cmd.Process.Pid)); err != nil {
Pid: cmd.Process.Pid,
}); err != nil {
return fmt.Errorf("failed to join cgroup %s: %w", cgroupPath, err) return fmt.Errorf("failed to join cgroup %s: %w", cgroupPath, err)
} }
return nil return nil

4
runtime/v2/runc/manager/manager_linux.go
View File

@@ -221,9 +221,7 @@ func (manager) Start(ctx context.Context, id string, opts shim.StartOpts) (_ str
if err != nil { if err != nil {
return "", fmt.Errorf("failed to load cgroup %s: %w", opts.ShimCgroup, err) return "", fmt.Errorf("failed to load cgroup %s: %w", opts.ShimCgroup, err)
} }
if err := cg.Add(cgroups.Process{ if err := cg.AddProc(uint64(cmd.Process.Pid)); err != nil {
Pid: cmd.Process.Pid,
}); err != nil {
return "", fmt.Errorf("failed to join cgroup %s: %w", opts.ShimCgroup, err) return "", fmt.Errorf("failed to join cgroup %s: %w", opts.ShimCgroup, err)
} }
} }

4
runtime/v2/runc/v1/service.go
View File

@@ -207,9 +207,7 @@ func (s *service) StartShim(ctx context.Context, opts shim.StartOpts) (_ string,
if err != nil { if err != nil {
return "", fmt.Errorf("failed to load cgroup %s: %w", opts.ShimCgroup, err) return "", fmt.Errorf("failed to load cgroup %s: %w", opts.ShimCgroup, err)
} }
if err := cg.Add(cgroups.Process{ if err := cg.AddProc(uint64(cmd.Process.Pid)); err != nil {
Pid: cmd.Process.Pid,
}); err != nil {
return "", fmt.Errorf("failed to join cgroup %s: %w", opts.ShimCgroup, err) return "", fmt.Errorf("failed to join cgroup %s: %w", opts.ShimCgroup, err)
} }
} }

4
services/server/server_linux.go
View File

@@ -56,9 +56,7 @@ func apply(ctx context.Context, config *srvconfig.Config) error {
return err return err
} }
} }
if err := cg.Add(cgroups.Process{ if err := cg.AddProc(uint64(os.Getpid())); err != nil {
Pid: os.Getpid(),
}); err != nil {
return err return err
} }
} }