github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

ctr: ctr images import --all-platforms: fix unpack

Browse Source 
Fix issue 11228

`ctr images import --all-platforms` w/o `--local` was failing due to
`unable to initialize unpacker: no unpack platforms defined` error.

W/ `--local`, it unpacks the layers for the strict-default platform.

Now `ctr images import --all-platforms` w/o `--local` unpacks the layers
for the non-strict default platform.
This behavior still differs from `--local`.
i.e., on an arm64 host, arm/v{5,6,7} layers are unpacked too.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
This commit is contained in:
Akihiro Suda 2025-01-08 10:12:31 +09:00 committed by k8s-infra-cherrypick-robot
parent ce560bb249
commit c4270430db
1 changed files with 9 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
cmd/ctr/commands/images/import.go
View File

@ -23,7 +23,6 @@ import (
"os"
"time"
ocispec "github.com/opencontainers/image-spec/specs-go/v1"
"github.com/urfave/cli/v2"
containerd "github.com/containerd/containerd/v2/client"
@ -141,33 +140,26 @@ If foobar.tar contains an OCI ref named "latest" and anonymous ref "sha256:deadb
opts = append(opts, image.WithNamedPrefix(prefix, overwrite))
}
var platSpec ocispec.Platform
// Only when all-platforms not specified, we will check platform value
// Implicitly if the platforms is empty, it means all-platforms
// Even with --all-platforms, only the default platform layers are unpacked,
// for compatibility with --local.
//
// This is still not fully compatible with --local, which only unpacks
// the strict-default platform layers.
platUnpack := platforms.DefaultSpec()
if !cliContext.Bool("all-platforms") {
// If platform specified, use that one, if not use default
if platform := cliContext.String("platform"); platform != "" {
platSpec, err = platforms.Parse(platform)
platUnpack, err = platforms.Parse(platform)
if err != nil {
return err
}
} else {
platSpec = platforms.DefaultSpec()
}
opts = append(opts, image.WithPlatforms(platSpec))
opts = append(opts, image.WithPlatforms(platUnpack))
}
if !cliContext.Bool("no-unpack") {
snapshotter := cliContext.String("snapshotter")
// If OS field is not empty, it means platSpec was updated in the above block
// i.e all-platforms was not specified
if platSpec.OS != "" {
opts = append(opts, image.WithUnpack(platSpec, snapshotter))
} else {
// Empty spec means all platforms
var emptySpec ocispec.Platform
opts = append(opts, image.WithUnpack(emptySpec, snapshotter))
}
opts = append(opts, image.WithUnpack(platUnpack, snapshotter))
}
is := image.NewStore(cliContext.String("index-name"), opts...)