github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Merge pull request #3956 from sethp-nr/fix/eventfd-leak

Browse Source 
fix: eventfd leak
This commit is contained in:
Akihiro Suda 2020-01-14 12:11:57 +09:00 committed by GitHub
commit c55bd87f47
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
runtime/v2/runc/v1/service.go
View File

@ -271,6 +271,8 @@ func (s *service) Start(ctx context.Context, r *taskAPI.StartRequest) (*taskAPI.
s.eventSendMu.Unlock() s.eventSendMu.Unlock()
return nil, errdefs.ToGRPC(err) return nil, errdefs.ToGRPC(err)
} }
switch r.ExecID {
case "":
if cg, ok := container.Cgroup().(cgroups.Cgroup); ok { if cg, ok := container.Cgroup().(cgroups.Cgroup); ok {
if err := s.ep.Add(container.ID, cg); err != nil { if err := s.ep.Add(container.ID, cg); err != nil {
logrus.WithError(err).Error("add cg to OOM monitor") logrus.WithError(err).Error("add cg to OOM monitor")
@ -278,8 +280,6 @@ func (s *service) Start(ctx context.Context, r *taskAPI.StartRequest) (*taskAPI.
} else { } else {
logrus.WithError(errdefs.ErrNotImplemented).Error("add cg to OOM monitor") logrus.WithError(errdefs.ErrNotImplemented).Error("add cg to OOM monitor")
} }
switch r.ExecID {
case "":
s.send(&eventstypes.TaskStart{ s.send(&eventstypes.TaskStart{
ContainerID: container.ID, ContainerID: container.ID,
Pid: uint32(p.Pid()), Pid: uint32(p.Pid()),

5
runtime/v2/runc/v2/service.go
View File

@ -330,6 +330,9 @@ func (s *service) Start(ctx context.Context, r *taskAPI.StartRequest) (*taskAPI.
s.eventSendMu.Unlock() s.eventSendMu.Unlock()
return nil, errdefs.ToGRPC(err) return nil, errdefs.ToGRPC(err)
} }
switch r.ExecID {
case "":
switch cg := container.Cgroup().(type) { switch cg := container.Cgroup().(type) {
case cgroups.Cgroup: case cgroups.Cgroup:
if err := s.ep.Add(container.ID, cg); err != nil { if err := s.ep.Add(container.ID, cg); err != nil {
@ -349,8 +352,6 @@ func (s *service) Start(ctx context.Context, r *taskAPI.StartRequest) (*taskAPI.
logrus.WithError(errdefs.ErrNotImplemented).Warn("add cg to OOM monitor") logrus.WithError(errdefs.ErrNotImplemented).Warn("add cg to OOM monitor")
} }
switch r.ExecID {
case "":
s.send(&eventstypes.TaskStart{ s.send(&eventstypes.TaskStart{
ContainerID: container.ID, ContainerID: container.ID,
Pid: uint32(p.Pid()), Pid: uint32(p.Pid()),