Merge pull request #4098 from thaJeztah/update_golangci_lint

Update Golangci-lint v1.23.8

.golangci.yml

@@ -15,7 +15,7 @@ linters:
     - errcheck
 
 run:
-  deadline: 2m
+  timeout: 2m
   skip-dirs:
     - api
     - design

cmd/containerd/command/service_windows.go

@@ -49,8 +49,6 @@ var (
 	allocConsole = kernel32.NewProc("AllocConsole")
 	oldStderr    windows.Handle
 	panicFile    *os.File
-
-	service *handler
 )
 
 const defaultServiceName = "containerd"
@@ -282,7 +280,6 @@ func launchService(s *server.Server, done chan struct{}) error {
 		return err
 	}
 
-	service = h
 	go func() {
 		if interactive {
 			err = debug.Run(serviceNameFlag, h)

script/setup/install-dev-tools

@@ -26,6 +26,6 @@ go get -u github.com/cpuguy83/go-md2man
 
 (
 	cd "$GOPATH"/src/github.com/golangci/golangci-lint/cmd/golangci-lint
-	git checkout v1.18.0
+	git checkout v1.23.8
 	go build -v && go install
 )