github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Merge pull request #9878 from amghazanfari/main

Browse Source 
refactor: clean switch statements and convert if to switch
This commit is contained in:
Derek McGowan 2024-02-27 05:14:01 +00:00 committed by GitHub
commit c9c8346bfa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
core/snapshots/snapshotter.go
View File

@ -65,9 +65,9 @@ func ParseKind(s string) Kind {
return KindActive return KindActive
case "committed": case "committed":
return KindCommitted return KindCommitted
default:
return KindUnknown
} }
return KindUnknown
} }
// String returns the string representation of the Kind // String returns the string representation of the Kind
@ -79,9 +79,9 @@ func (k Kind) String() string {
return "Active" return "Active"
case KindCommitted: case KindCommitted:
return "Committed" return "Committed"
default:
return "Unknown"
} }
return "Unknown"
} }
// MarshalJSON the Kind to JSON // MarshalJSON the Kind to JSON
@ -102,25 +102,27 @@ func (k *Kind) UnmarshalJSON(b []byte) error {
// KindToProto converts from [Kind] to the protobuf definition [snapshots.Kind]. // KindToProto converts from [Kind] to the protobuf definition [snapshots.Kind].
func KindToProto(kind Kind) snapshotsapi.Kind { func KindToProto(kind Kind) snapshotsapi.Kind {
if kind == KindActive { switch kind {
case KindActive:
return snapshotsapi.Kind_ACTIVE return snapshotsapi.Kind_ACTIVE
} case KindView:
if kind == KindView {
return snapshotsapi.Kind_VIEW return snapshotsapi.Kind_VIEW
default:
return snapshotsapi.Kind_COMMITTED
} }
return snapshotsapi.Kind_COMMITTED
} }
// KindFromProto converts from the protobuf definition [snapshots.Kind] to // KindFromProto converts from the protobuf definition [snapshots.Kind] to
// [Kind]. // [Kind].
func KindFromProto(kind snapshotsapi.Kind) Kind { func KindFromProto(kind snapshotsapi.Kind) Kind {
if kind == snapshotsapi.Kind_ACTIVE { switch kind {
case snapshotsapi.Kind_ACTIVE:
return KindActive return KindActive
} case snapshotsapi.Kind_VIEW:
if kind == snapshotsapi.Kind_VIEW {
return KindView return KindView
default:
return KindCommitted
} }
return KindCommitted
} }
// Info provides information about a particular snapshot. // Info provides information about a particular snapshot.