Merge pull request #4384 from AkihiroSuda/deprecate-legacy-shims

Deprecate legacy shims

RELEASES.md

@@ -309,3 +309,12 @@ in that process. Container root file systems will be maintained on upgrade.
 We may make exceptions in the interest of __security patches__. If a break is
 required, it will be communicated clearly and the solution will be considered
 against total impact.
+
+## Deprecated features
+
+The deprecated features are shown in the following table:
+
+| Component                                                            | Deprecation release | Target release for removal |
+|----------------------------------------------------------------------|---------------------|----------------------------|
+| Runtime V1 API and implementation (`io.containerd.runtime.v1.linux`) | containerd v1.4     | containerd v2.0            |
+| Runc V1 implementation of Runtime V2 (`io.containerd.runc.v1`)       | containerd v1.4     | containerd v2.0            |

services/tasks/local.go

@@ -184,6 +184,11 @@ func (l *local) Create(ctx context.Context, r *api.CreateTaskRequest, _ ...grpc.
 			Options: m.Options,
 		})
 	}
+	if strings.HasPrefix(container.Runtime.Name, "io.containerd.runtime.v1.") {
+		log.G(ctx).Warn("runtime v1 is deprecated since containerd v1.4, consider using runtime v2")
+	} else if container.Runtime.Name == plugin.RuntimeRuncV1 {
+		log.G(ctx).Warnf("%q is deprecated since containerd v1.4, consider using %q", plugin.RuntimeRuncV1, plugin.RuntimeRuncV2)
+	}
 	rtime, err := l.getRuntime(container.Runtime.Name)
 	if err != nil {
 		return nil, err