github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

avoid repeated calls in Tricolor gc

Browse Source 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
This commit is contained in:
Jin Dong 2024-08-26 18:29:57 -07:00
parent 6b97a08eee
commit d83184ced1
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/gc/gc.go
View File

@ -69,12 +69,14 @@ func Tricolor(roots []Node, refs func(ref Node) ([]Node, error)) (map[Node]struc
) )
grays = append(grays, roots...) grays = append(grays, roots...)
for _, root := range roots {
seen[root] = struct{}{} // pre-mark this as not-white
}
for len(grays) > 0 { for len(grays) > 0 {
// Pick any gray object // Pick any gray object
id := grays[len(grays)-1] // effectively "depth first" because first element id := grays[len(grays)-1] // effectively "depth first" because first element
grays = grays[:len(grays)-1] grays = grays[:len(grays)-1]
seen[id] = struct{}{} // post-mark this as not-white
rs, err := refs(id) rs, err := refs(id)
if err != nil { if err != nil {
return nil, err return nil, err
@ -84,6 +86,7 @@ func Tricolor(roots []Node, refs func(ref Node) ([]Node, error)) (map[Node]struc
for _, target := range rs { for _, target := range rs {
if _, ok := seen[target]; !ok { if _, ok := seen[target]; !ok {
grays = append(grays, target) grays = append(grays, target)
seen[target] = struct{}{}
} }
} }