diff --git a/pkg/cri/sbserver/helpers_windows.go b/pkg/cri/sbserver/helpers_windows.go index aa44299d0..808a95e75 100644 --- a/pkg/cri/sbserver/helpers_windows.go +++ b/pkg/cri/sbserver/helpers_windows.go @@ -28,7 +28,10 @@ import ( // openLogFile opens/creates a container log file. // It specifies `FILE_SHARE_DELETE` option to make sure // log files can be rotated by kubelet. -// TODO(windows): Use golang support after 1.14. (https://github.com/golang/go/issues/32088) +// +// Unfortunately this needs to be maintained as Go doesn't +// have a way to set FILE_SHARE_DELETE for os.OpenFile. +// https://github.com/golang/go/issues/32088 func openLogFile(path string) (*os.File, error) { path = fixLongPath(path) if len(path) == 0 { diff --git a/pkg/cri/server/helpers_windows.go b/pkg/cri/server/helpers_windows.go index 1b8940129..d0a5b6f7f 100644 --- a/pkg/cri/server/helpers_windows.go +++ b/pkg/cri/server/helpers_windows.go @@ -28,7 +28,10 @@ import ( // openLogFile opens/creates a container log file. // It specifies `FILE_SHARE_DELETE` option to make sure // log files can be rotated by kubelet. -// TODO(windows): Use golang support after 1.14. (https://github.com/golang/go/issues/32088) +// +// Unfortunately this needs to be maintained as Go doesn't +// have a way to set FILE_SHARE_DELETE for os.OpenFile. +// https://github.com/golang/go/issues/32088 func openLogFile(path string) (*os.File, error) { path = fixLongPath(path) if len(path) == 0 {