From abcf7c2f6a20d2dcf596d84afc64020ceaf33a90 Mon Sep 17 00:00:00 2001 From: Daniel Canter Date: Tue, 14 Dec 2021 17:05:07 -0800 Subject: [PATCH] Disable TestContainerHook on Windows OCI hooks aren't implemented on Windows. The test will, and has been, actuallyrunning fine on Windows because the Github runners seem to have a 'ps' binary in the users PATH, but there's not any actual hook functionality being tested as any of the OCI fields are ignored for Windows containers. Signed-off-by: Daniel Canter --- integration/client/container_test.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/integration/client/container_test.go b/integration/client/container_test.go index adde09857..b01a84c21 100644 --- a/integration/client/container_test.go +++ b/integration/client/container_test.go @@ -1569,6 +1569,12 @@ func TestContainerLabels(t *testing.T) { } func TestContainerHook(t *testing.T) { + // OCI hooks aren't implemented on Windows. This test will actually run fine on Windows if there's a 'ps' binary in the users PATH, but + // there's not any actual hook functionality being tested as any of the OCI fields are plain ignored for Windows containers. + if runtime.GOOS == "windows" { + t.Skip() + } + t.Parallel() client, err := newClient(t, address) @@ -2012,7 +2018,7 @@ func TestDaemonRestart(t *testing.T) { } type directIO struct { - cio.DirectIO + cio.DirectIO } // ioCreate returns IO available for use with task creation