From 3b670ebc949f8ebe8aba5899cb9d6b1d7433a11a Mon Sep 17 00:00:00 2001 From: yanxuean Date: Wed, 22 Nov 2017 22:37:52 +0800 Subject: [PATCH] remove redundant check for imagestore create correct check object for imagestore update Signed-off-by: yanxuean --- metadata/images.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/metadata/images.go b/metadata/images.go index 7e5e3c76e..fbd5cbf17 100644 --- a/metadata/images.go +++ b/metadata/images.go @@ -100,10 +100,6 @@ func (s *imageStore) Create(ctx context.Context, image images.Image) (images.Ima return images.Image{}, err } - if image.Name == "" { - return images.Image{}, errors.Wrapf(errdefs.ErrInvalidArgument, "image name is required for create") - } - if err := validateImage(&image); err != nil { return images.Image{}, err } @@ -177,7 +173,7 @@ func (s *imageStore) Update(ctx context.Context, image images.Image, fieldpaths updated = image } - if err := validateImage(&image); err != nil { + if err := validateImage(&updated); err != nil { return err }