Add unit test to getSupportedPlatform
Signed-off-by: Tony Fang <nhfang@amazon.com>
This commit is contained in:
parent
a18709442b
commit
f53417921d
153
pkg/transfer/local/pull_test.go
Normal file
153
pkg/transfer/local/pull_test.go
Normal file
@ -0,0 +1,153 @@
|
|||||||
|
/*
|
||||||
|
Copyright The containerd Authors.
|
||||||
|
|
||||||
|
Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
you may not use this file except in compliance with the License.
|
||||||
|
You may obtain a copy of the License at
|
||||||
|
|
||||||
|
http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
|
||||||
|
Unless required by applicable law or agreed to in writing, software
|
||||||
|
distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
See the License for the specific language governing permissions and
|
||||||
|
limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package local
|
||||||
|
|
||||||
|
import (
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"github.com/containerd/containerd"
|
||||||
|
"github.com/containerd/containerd/pkg/transfer"
|
||||||
|
"github.com/containerd/containerd/pkg/unpack"
|
||||||
|
"github.com/containerd/containerd/platforms"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestGetSupportedPlatform(t *testing.T) {
|
||||||
|
supportedPlatforms := []unpack.Platform{
|
||||||
|
{
|
||||||
|
Platform: platforms.OnlyStrict(platforms.MustParse("linux/amd64")),
|
||||||
|
SnapshotterKey: "native",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
Platform: platforms.OnlyStrict(platforms.MustParse("linux/amd64")),
|
||||||
|
SnapshotterKey: "devmapper",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
Platform: platforms.OnlyStrict(platforms.MustParse("linux/arm64")),
|
||||||
|
SnapshotterKey: "native",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
Platform: platforms.OnlyStrict(platforms.MustParse("linux/arm")),
|
||||||
|
SnapshotterKey: "native",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
Platform: platforms.DefaultStrict(),
|
||||||
|
SnapshotterKey: containerd.DefaultSnapshotter,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, testCase := range []struct {
|
||||||
|
// Name is the name of the test
|
||||||
|
Name string
|
||||||
|
|
||||||
|
// Input
|
||||||
|
UnpackConfig transfer.UnpackConfiguration
|
||||||
|
SupportedPlatforms []unpack.Platform
|
||||||
|
|
||||||
|
// Expected
|
||||||
|
Match bool
|
||||||
|
ExpectedPlatform transfer.UnpackConfiguration
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
Name: "No match on input linux/arm64 and devmapper snapshotter",
|
||||||
|
UnpackConfig: transfer.UnpackConfiguration{
|
||||||
|
Platform: platforms.MustParse("linux/arm64"),
|
||||||
|
Snapshotter: "devmapper",
|
||||||
|
},
|
||||||
|
SupportedPlatforms: supportedPlatforms,
|
||||||
|
Match: false,
|
||||||
|
ExpectedPlatform: transfer.UnpackConfiguration{},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
Name: "No match on input linux/386 and native snapshotter",
|
||||||
|
UnpackConfig: transfer.UnpackConfiguration{
|
||||||
|
Platform: platforms.MustParse("linux/386"),
|
||||||
|
Snapshotter: "native",
|
||||||
|
},
|
||||||
|
SupportedPlatforms: supportedPlatforms,
|
||||||
|
Match: false,
|
||||||
|
ExpectedPlatform: transfer.UnpackConfiguration{},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
Name: "Match linux/amd64 and native snapshotter",
|
||||||
|
UnpackConfig: transfer.UnpackConfiguration{
|
||||||
|
Platform: platforms.MustParse("linux/amd64"),
|
||||||
|
Snapshotter: "native",
|
||||||
|
},
|
||||||
|
SupportedPlatforms: supportedPlatforms,
|
||||||
|
Match: true,
|
||||||
|
ExpectedPlatform: transfer.UnpackConfiguration{
|
||||||
|
Platform: platforms.MustParse("linux/amd64"),
|
||||||
|
Snapshotter: "native",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
Name: "Match linux/arm64 and native snapshotter",
|
||||||
|
UnpackConfig: transfer.UnpackConfiguration{
|
||||||
|
Platform: platforms.MustParse("linux/arm64"),
|
||||||
|
Snapshotter: "native",
|
||||||
|
},
|
||||||
|
SupportedPlatforms: supportedPlatforms,
|
||||||
|
Match: true,
|
||||||
|
ExpectedPlatform: transfer.UnpackConfiguration{
|
||||||
|
Platform: platforms.MustParse("linux/arm64"),
|
||||||
|
Snapshotter: "native",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
Name: "Default platform input only match with defaultSnapshotter",
|
||||||
|
UnpackConfig: transfer.UnpackConfiguration{
|
||||||
|
Platform: platforms.DefaultSpec(),
|
||||||
|
},
|
||||||
|
SupportedPlatforms: supportedPlatforms,
|
||||||
|
Match: true,
|
||||||
|
ExpectedPlatform: transfer.UnpackConfiguration{
|
||||||
|
Platform: platforms.DefaultSpec(),
|
||||||
|
Snapshotter: containerd.DefaultSnapshotter,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
} {
|
||||||
|
testCase := testCase
|
||||||
|
t.Run(testCase.Name, func(t *testing.T) {
|
||||||
|
m, sp := getSupportedPlatform(testCase.UnpackConfig, testCase.SupportedPlatforms)
|
||||||
|
|
||||||
|
// Match result should match expected
|
||||||
|
if m != testCase.Match {
|
||||||
|
t.Fatalf("Expect match result %v, but got %v", testCase.Match, m)
|
||||||
|
}
|
||||||
|
|
||||||
|
// If match result is false, the Platform should be nil too
|
||||||
|
if !m && sp.Platform != nil {
|
||||||
|
t.Fatalf("Expect nil Platform when we don't have a match")
|
||||||
|
}
|
||||||
|
|
||||||
|
// Snapshotter should match, empty string can be compared too
|
||||||
|
if sp.SnapshotterKey != testCase.ExpectedPlatform.Snapshotter {
|
||||||
|
t.Fatalf("Expect SnapshotterKey %v, but got %v", testCase.ExpectedPlatform.Snapshotter, sp.SnapshotterKey)
|
||||||
|
}
|
||||||
|
|
||||||
|
// If the matched Platform is not nil, it should match the expected Platform
|
||||||
|
if sp.Platform != nil && !sp.Platform.Match(testCase.ExpectedPlatform.Platform) {
|
||||||
|
t.Fatalf("Expect Platform %v doesn't match", testCase.ExpectedPlatform.Platform)
|
||||||
|
}
|
||||||
|
// If the ExectedPlatform is not empty, the matched Platform shoule not be nil either
|
||||||
|
if sp.Platform == nil && testCase.ExpectedPlatform.Platform.OS != "" {
|
||||||
|
t.Fatalf("Expect Platform %v doesn't match", testCase.ExpectedPlatform.Platform)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
Loading…
Reference in New Issue
Block a user