From e9bb9c3bc7ff7bc3ffb80a2505b736efd85d6d6e Mon Sep 17 00:00:00 2001 From: Daniel Canter Date: Fri, 18 Mar 2022 11:36:36 -0700 Subject: [PATCH] Skip tty critest testcase on Windows Server 2022 Skip the 'runtime should support exec with tty=true and stdin=true' test for now as it's exceedingly flaky only on Ws2022.. Doesn't seem to reproduce on a local ws2022 machine, but don't want to keep the CI red while we investigate. Signed-off-by: Daniel Canter --- .github/workflows/ci.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 194513e73..c3f093b49 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -340,7 +340,13 @@ jobs: Start-Process -FilePath containerd.exe -NoNewWindow -RedirectStandardError true -PassThru get-process | sls containerd start-sleep 5 - critest.exe --runtime-endpoint=npipe://.//pipe//containerd-containerd --test-images-file='${{env.CRI_TEST_IMAGES}}' --report-dir='${{github.workspace}}/critestreport' + # This test is exceedingly flaky only on ws2022 so skip for now to keep CI happy. + # Info: https://github.com/containerd/containerd/issues/6652 + if( '${{ matrix.os }}' -eq 'windows-2022' ) + { + $skip = "-ginkgo.skip=runtime should support exec with tty=true and stdin=true" + } + critest.exe --runtime-endpoint=npipe://.//pipe//containerd-containerd --test-images-file='${{env.CRI_TEST_IMAGES}}' --report-dir='${{github.workspace}}/critestreport' $skip - uses: actions/upload-artifact@v2 if: always() with: