From f7850ccd689656a8d51e93dcfe763fb89120df9e Mon Sep 17 00:00:00 2001 From: Stephen J Day Date: Wed, 7 Dec 2016 19:58:26 -0800 Subject: [PATCH] snapshot: specify View function on snapshot manager Signed-off-by: Stephen J Day --- snapshot/manager.go | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/snapshot/manager.go b/snapshot/manager.go index 84a2327c6..fcc763a5a 100644 --- a/snapshot/manager.go +++ b/snapshot/manager.go @@ -1,7 +1,6 @@ package snapshot import ( - "errors" "fmt" "io/ioutil" "os" @@ -11,10 +10,6 @@ import ( "github.com/docker/containerd" ) -var ( - errNotImplemented = errors.New("not implemented") -) - // Manager provides an API for allocating, snapshotting and mounting // abstract, layer-based filesytems. The model works by building up sets of // directories with parent-child relationships. @@ -204,6 +199,18 @@ func (lm *Manager) Prepare(dst, parent string) ([]containerd.Mount, error) { }, nil } +// View behaves identically to Prepare except the result may not be commited +// back to the snappshot manager. +// +// Whether or not these are readonly mounts is implementation specific, but the +// caller may write to dst freely. +// +// Calling Commit on dst will result in an error. Calling Rollback on dst +// should be done to cleanup resources. +func (lm *Manager) View(dst, parent string) ([]containerd.Mount, error) { + panic("not implemented") +} + // Commit captures the changes between dst and its parent into the path // provided by diff. The path diff can then be used with the layer // manipulator's other methods to access the diff content. @@ -292,5 +299,5 @@ type Change struct { // Changes returns the list of changes from the diff's parent. func (lm *Manager) Changes(diff string) ([]Change, error) { - return nil, errNotImplemented + panic("not implemented") }