github/containerd
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

api, metadata: use map type for Container.Extensions

Browse Source 
To allow for updating extensions without collisions, we have moved to
using a map type that can be explicitly selected via the field path for
updates. This ensures that multiple parties can operate on their
extensions without stepping on each other's toes or incurring an
inordinate number of round trips.

Signed-off-by: Stephen J Day <stephen.day@docker.com>
This commit is contained in:
Stephen J Day
2017-09-08 14:51:30 -07:00
parent 3552ce5688
commit f7d31e2be4
9 changed files with 349 additions and 123 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
container_test.go
View File

@@ -1384,7 +1384,7 @@ func TestContainerExtensions(t *testing.T) {
defer client.Close()
ext := gogotypes.Any{TypeUrl: "test.ext.url", Value: []byte("hello")}
container, err := client.NewContainer(ctx, id, WithNewSpec(), WithContainerExtension(&ext))
container, err := client.NewContainer(ctx, id, WithNewSpec(), WithContainerExtension("hello", &ext))
if err != nil {
t.Fatal(err)
}
@@ -1395,11 +1395,11 @@ func TestContainerExtensions(t *testing.T) {
if len(cExts) != 1 {
t.Fatal("expected 1 container extension")
}
if cExts[0].TypeUrl != ext.TypeUrl {
t.Fatalf("got unexpected type url for extension: %s", cExts[0].TypeUrl)
if cExts["hello"].TypeUrl != ext.TypeUrl {
t.Fatalf("got unexpected type url for extension: %s", cExts["hello"].TypeUrl)
}
if !bytes.Equal(cExts[0].Value, ext.Value) {
t.Fatalf("expected extension value %q, got: %q", ext.Value, cExts[0].Value)
if !bytes.Equal(cExts["hello"].Value, ext.Value) {
t.Fatalf("expected extension value %q, got: %q", ext.Value, cExts["hello"].Value)
}
}