From f8e0753366c7266f08e5a754751688191e6190a0 Mon Sep 17 00:00:00 2001 From: Akhil Mohan Date: Wed, 14 Aug 2024 14:22:03 +0530 Subject: [PATCH] remove windows check in linux_test file Signed-off-by: Akhil Mohan --- integration/client/container_linux_test.go | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/integration/client/container_linux_test.go b/integration/client/container_linux_test.go index bbb7bb91e..1554f89d5 100644 --- a/integration/client/container_linux_test.go +++ b/integration/client/container_linux_test.go @@ -24,7 +24,6 @@ import ( "os" "os/exec" "path/filepath" - "runtime" "strings" "sync" "syscall" @@ -488,13 +487,6 @@ func getLogDirPath(runtimeVersion, id string) string { func TestContainerAttach(t *testing.T) { t.Parallel() - if runtime.GOOS == "windows" { - // On windows, closing the write side of the pipe closes the read - // side, sending an EOF to it and preventing reopening it. - // Hence this test will always fails on windows - t.Skip("invalid logic on windows") - } - client, err := newClient(t, address) if err != nil { t.Fatal(err) @@ -667,13 +659,6 @@ func testContainerUser(t *testing.T, userstr, expectedOutput string) { func TestContainerAttachProcess(t *testing.T) { t.Parallel() - if runtime.GOOS == "windows" { - // On windows, closing the write side of the pipe closes the read - // side, sending an EOF to it and preventing reopening it. - // Hence this test will always fails on windows - t.Skip("invalid logic on windows") - } - client, err := newClient(t, address) if err != nil { t.Fatal(err) @@ -791,13 +776,6 @@ func TestContainerAttachProcess(t *testing.T) { func TestContainerLoadUnexistingProcess(t *testing.T) { t.Parallel() - if runtime.GOOS == "windows" { - // On windows, closing the write side of the pipe closes the read - // side, sending an EOF to it and preventing reopening it. - // Hence this test will always fails on windows - t.Skip("invalid logic on windows") - } - client, err := newClient(t, address) if err != nil { t.Fatal(err)