github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Remove out-of-date TODOs.

Browse Source 
Signed-off-by: Lantao Liu <lantaol@google.com>
This commit is contained in:
Lantao Liu 2017-06-30 01:19:28 +00:00
parent 7174310f95
commit faf592069b
3 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/server/container_create.go
View File

@ -173,7 +173,6 @@ func (c *criContainerdService) CreateContainer(ctx context.Context, r *runtime.C
func (c *criContainerdService) generateContainerSpec(id string, sandboxPid uint32, config *runtime.ContainerConfig, func (c *criContainerdService) generateContainerSpec(id string, sandboxPid uint32, config *runtime.ContainerConfig,
sandboxConfig *runtime.PodSandboxConfig, imageConfig *imagespec.ImageConfig, extraMounts []*runtime.Mount) (*runtimespec.Spec, error) { sandboxConfig *runtime.PodSandboxConfig, imageConfig *imagespec.ImageConfig, extraMounts []*runtime.Mount) (*runtimespec.Spec, error) {
// Creates a spec Generator with the default spec. // Creates a spec Generator with the default spec.
// TODO(random-liu): [P2] Move container runtime spec generation into a helper function.
g := generate.New() g := generate.New()
// Set the relative path to the rootfs of the container from containerd's // Set the relative path to the rootfs of the container from containerd's
@ -211,8 +210,6 @@ func (c *criContainerdService) generateContainerSpec(id string, sandboxPid uint3
return nil, fmt.Errorf("failed to set devices mapping %+v: %v", config.GetDevices(), err) return nil, fmt.Errorf("failed to set devices mapping %+v: %v", config.GetDevices(), err)
} }
// TODO(random-liu): [P1] Handle container logging, decorate and redirect to file.
setOCILinuxResource(&g, config.GetLinux().GetResources()) setOCILinuxResource(&g, config.GetLinux().GetResources())
if sandboxConfig.GetLinux().GetCgroupParent() != "" { if sandboxConfig.GetLinux().GetCgroupParent() != "" {

1
pkg/server/image_remove.go
View File

@ -29,7 +29,6 @@ import (
) )
// RemoveImage removes the image. // RemoveImage removes the image.
// TODO(mikebrow): harden api
// TODO(random-liu): Update CRI to pass image reference instead of ImageSpec. (See // TODO(random-liu): Update CRI to pass image reference instead of ImageSpec. (See
// kubernetes/kubernetes#46255) // kubernetes/kubernetes#46255)
// TODO(random-liu): We should change CRI to distinguish image id and image spec. // TODO(random-liu): We should change CRI to distinguish image id and image spec.

3
pkg/server/sandbox_run.go
View File

@ -281,9 +281,6 @@ func (c *criContainerdService) generateSandboxContainerSpec(id string, config *r
// Set hostname. // Set hostname.
g.SetHostname(config.GetHostname()) g.SetHostname(config.GetHostname())
// TODO(random-liu): [P0] Add NamespaceGetter and PortMappingGetter to initialize network plugin.
// TODO(random-liu): [P0] Add annotation to identify the container is managed by cri-containerd.
// TODO(random-liu): [P2] Consider whether to add labels and annotations to the container. // TODO(random-liu): [P2] Consider whether to add labels and annotations to the container.
// Set cgroups parent. // Set cgroups parent.