From fec33aa7359e1c717234b885ab8e24413cf2bd91 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 27 Jun 2024 12:03:15 +0200 Subject: [PATCH] pkg/reference: deprecate SplitObject The behavior of this function is quite counter-intuitive, as it preserves the delimiter in the result, and its use for external consumers would be very limited. Spec.Digest no longer uses this function, and it appears that BuildKit is currently the only (publicly visible) external consumer of it. This patch deprecates the function. Signed-off-by: Sebastiaan van Stijn --- pkg/reference/reference.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/reference/reference.go b/pkg/reference/reference.go index 1f3a47063..9329a9aab 100644 --- a/pkg/reference/reference.go +++ b/pkg/reference/reference.go @@ -168,6 +168,8 @@ func (r Spec) String() string { // t, d := SplitObject("docker.io/library/ubuntu:latest@sha256:deadbeef") // fmt.Println(t) // docker.io/library/ubuntu:latest@ // fmt.Println(d) // sha256:deadbeef +// +// Deprecated: use [Parse] and [Spec.Digest] instead. func SplitObject(obj string) (tag string, dgst digest.Digest) { if i := strings.Index(obj, "@"); i >= 0 { // Offset by one so preserve the "@" in the tag returned.