github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity
4,736 Commits 3 Branches 2 Tags 112 MiB
15ae6b74fd
Commit Graph

3 Commits

Author SHA1 Message Date
Li Yuxuan
cf6e008542 Fix fd leak of shim log 
Open shim v2 log with the flag `O_RDWR` will cause the `Read()` block
forever even if the pipe has been closed on the shim side. Then the
`io.Copy()` would never return and lead to a fd leak.
Fix typo when closing shim v1 log which causes the `stdouLog` leak.
Update `numPipes` function in test case to get the opened FIFO
correctly.

Signed-off-by: Li Yuxuan <liyuxuan04@baidu.com>
 2019-05-09 20:21:57 +08:00
Lantao Liu
26ab393e7d Use context.Background for O_NONBLOCK OpenFifo. 
Signed-off-by: Lantao Liu <lantaol@google.com>
 2019-01-23 10:18:54 -08:00
Michael Crosby
6ba4ddfdda Add shim log pipe for log forwarding to the daemon 
A fifo on unix or named pipe on Windows will be provided to the shim.
It can be located inside the `cwd` of the shim named "log".
The shims can use the existing `github.com/containerd/containerd/log` package to log debug messages.
Messages will automatically be output in the containerd's daemon logs with the correct fiels and runtime set.

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
 2018-08-07 15:31:00 -04:00