Commit Graph

14496 Commits

Author SHA1 Message Date
Phil Estes
0f5586ee09
Merge pull request #9748 from fuweid/upgrade-testcase
test: update upgrade test suite in integration
2024-02-16 16:11:25 +00:00
Fu Wei
dc88cdea1b
Merge pull request #9829 from mxpv/fp
Run failpoints tests only for runc
2024-02-16 06:10:08 +00:00
Derek McGowan
c36950d64e
Merge pull request #9831 from mxpv/status
Workaround "required job statuses" job list
2024-02-16 06:09:34 +00:00
Derek McGowan
d346aeebdf
Merge pull request #9746 from neoaggelos/fix/config-glob
Fix config import relative path glob
2024-02-16 06:08:17 +00:00
Derek McGowan
f8f1e5f7a6
Add container monitor plugin type for restart
Adds a plugin type for container monitor.
Rename the task monitor type to avoid confusion.
Add config migration for new plugin types to pass existing migration
tests.

Signed-off-by: Derek McGowan <derek@mcg.dev>
2024-02-15 21:54:40 -08:00
Wei Fu
c86c8a16f0 integration: add case related to ContainerStats in upgrade suite
It's used to check new release containerd can parse metric data from existing
shim created by previous release.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-02-16 12:18:38 +08:00
Wei Fu
acec60f554 integration: update recover case for upgrade
The new release containerd should detect dead shim during recover.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-02-16 12:18:38 +08:00
Wei Fu
e659cd2752 integration: connect to shim by bridge client
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-02-16 12:18:38 +08:00
Wei Fu
51689b6618 integration: introduce hook for upgrade test suite
We can inject failpoint in beforeUpgradeHookFunc.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-02-16 12:18:38 +08:00
Wei Fu
a95c8ed591 integration: check data dir after delete container or pod
The new release containerd should cleanup old pod's data dir after
RemovePodSandbox.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-02-16 12:18:38 +08:00
Wei Fu
ec759f5be4 integration/*: extend Runtime.Status response
CRI Runtime Status contains `Info` and it can help us check current
configuration.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-02-16 12:18:38 +08:00
Wei Fu
401d4b491f integration: add some helper function to release upgrade cases
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-02-16 12:18:30 +08:00
Maksym Pavlenko
7cf8a00c77
Run failpoints tests only for runc
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
2024-02-15 12:19:31 -08:00
Maksym Pavlenko
a890c8e537
Add job to report statuses from matrix jobs
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
2024-02-15 12:13:58 -08:00
Derek Nola
132485adb0
Convert CLI to urfave v2
Followed the Migration Guide at https://cli.urfave.org/migrate-v1-to-v2/
The major changes not pointed out in the migration guide are:
- context.Args() no longer produces a []slice, so context.Args().Slice()
  in substitued
- All cli.Global***** are deprecated (the migration guide is somewhat
  unclear on this)

Signed-off-by: Derek Nola <derek.nola@suse.com>

Vendor in urfave cli/v2

Signed-off-by: Derek Nola <derek.nola@suse.com>

Fix NewStringSlice calls

Signed-off-by: Derek Nola <derek.nola@suse.com>
2024-02-15 09:48:04 -08:00
Phil Estes
00fe7a4974
Merge pull request #9827 from dmcgowan/move-config-version
Move config version to version package
2024-02-15 14:58:04 +00:00
Kirill A. Korinsky
c8766123d9
Prevent GC from schedule itself with 0 period.
On startup `gcTimeSum` might work fast and return `0`, so on this case
the algorithm turns in infinity loop which simple consume CPU on timer
which fires without any interval.

Use `5ms` as fallback to have interval `245ms` for that case.

Closes: https://github.com/containerd/containerd/issues/5089

Signed-off-by: Kirill A. Korinsky <kirill@korins.ky>
2024-02-15 11:32:53 +01:00
Derek McGowan
a086125ae3
Move config version to version package
Signed-off-by: Derek McGowan <derek@mcg.dev>
2024-02-14 21:09:44 -08:00
Akihiro Suda
99721c27e1
Disable the support for Schema 1 images
Schema 1 (`application/vnd.docker.distribution.manifest.v1+prettyjws`) has been
officially deprecated since containerd v1.7 (PR 6884).

We have planned to remove the support for Schema 1 in containerd v2.0, but this
removal may still surprise some users.
So, in containerd v2.0 we will just disable it by default.

The support for Schema 1 can be still enabled by setting an environment variable
`CONTAINERD_ENABLE_DEPRECATED_PULL_SCHEMA_1_IMAGE=1`, however, this workaround
will be completely removed in containerd v2.1.

Schema 2 was introduced in Docker 1.10 (Feb 2016), so most users should
have been already using Schema 2 or OCI.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2024-02-15 11:11:35 +09:00
Mike Brown
f1a3c3705f
Merge pull request #9815 from kiashok/updateCRIServicePull
Pass runtimehandler from CRI to pull image request
2024-02-15 00:38:40 +00:00
Mike Brown
97f86f18ae
Merge pull request #9788 from kiashok/criRemoveImage
Add CRIImageService.RemoveImage()
2024-02-14 23:49:07 +00:00
Kirtana Ashok
b9dfba5b80 Add CRIImageService.RemoveImage()
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
2024-02-14 13:49:39 -08:00
Kirtana Ashok
4c775fcfbf Pass runtimehandler from CRI pull image request
Starting with k8s cri-api v0.29.1, CRI supports new runtime handler flag

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
2024-02-14 13:31:23 -08:00
Akihiro Suda
32169d591d
Merge pull request #9807 from AkihiroSuda/ctr-print-deprecations
ctr: print deprecation warnings on every invocation
2024-02-14 05:48:52 +00:00
Akihiro Suda
a2cf4fb9ba
Merge pull request #9817 from kiashok/moveToTraceLogs
Move high volume event logs to Trace level
2024-02-14 05:42:44 +00:00
Kirtana Ashok
4dcf089fa3 Move high volume event logs to Trace level
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
2024-02-13 20:05:50 -08:00
Maksym Pavlenko
a843731305
Merge pull request #9767 from AkihiroSuda/cri-propagate-deprecation
cri: propagate deprecation list to runtime status
2024-02-13 21:22:26 +00:00
Akihiro Suda
1b3a96da6c
cri: propagate deprecation list to runtime status
Propagate the deprecation list to CRI runtime conditions.

The propagated conditions are visible via `crictl info`,
but not visible via `kubectl get nodes -o yaml` yet, although
the CRI API says "These conditions will be exposed to users to help
them understand the status of the system".

https://github.com/kubernetes/cri-api/blob/v0.29.1/pkg/apis/runtime/v1/api.proto#L1505-L1509

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2024-02-14 03:59:49 +09:00
Akihiro Suda
ec26600394
Merge pull request #9814 from mikebrow/update-critools
moving up cri-tools to pull in new CRI changes tied to k8s v1.29
2024-02-13 18:54:53 +00:00
Mike Brown
ac7febc93a moving up for new CRI changes
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
2024-02-13 12:14:27 -06:00
Mike Brown
dd725fae25
Merge pull request #9378 from kiashok/updateCriApi
Update cri-api to v0.29.1
2024-02-13 16:01:10 +00:00
Fu Wei
81965c0a57
Merge pull request #9813 from UiPath/remove-loop-config
Remove internal LoopConfig struct
2024-02-13 11:50:36 +00:00
Alexandru Matei
ccec1e6e4c Remove internal LoopConfig struct
The struct is now part of golang.org/x/sys.
Follow-up for #9805

Signed-off-by: Alexandru Matei <alexandru.matei@uipath.com>
2024-02-13 11:49:28 +02:00
Akihiro Suda
b21e93b320
Merge pull request #9811 from containerd/dependabot/go_modules/golang-x-cd731e5d14
build(deps): bump the golang-x group with 1 update
2024-02-13 07:03:42 +00:00
Akihiro Suda
1435b0552e
Merge pull request #9810 from containerd/dependabot/github_actions/golangci/golangci-lint-action-4
build(deps): bump golangci/golangci-lint-action from 3 to 4
2024-02-13 06:24:55 +00:00
dependabot[bot]
3d8da2ebfc
build(deps): bump the golang-x group with 1 update
Bumps the golang-x group with 1 update: [golang.org/x/mod](https://github.com/golang/mod).


Updates `golang.org/x/mod` from 0.14.0 to 0.15.0
- [Commits](https://github.com/golang/mod/compare/v0.14.0...v0.15.0)

---
updated-dependencies:
- dependency-name: golang.org/x/mod
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-x
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-12 23:58:13 +00:00
dependabot[bot]
a274439f2e
build(deps): bump golangci/golangci-lint-action from 3 to 4
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3 to 4.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](https://github.com/golangci/golangci-lint-action/compare/v3...v4)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-12 23:37:29 +00:00
Maksym Pavlenko
4f76ebcb86
Merge pull request #9778 from adisky/use-latest-registry-conf
Update gce configure.sh to use registry config_path
2024-02-12 19:34:47 +00:00
Derek McGowan
44f92599e5
Merge pull request #9805 from UiPath/use-sys-for-loop-configure
go.mod: Bump golang.org/x/sys to v0.17.0
2024-02-12 18:28:20 +00:00
Akihiro Suda
468bee9a79
ctr: print deprecation warnings on every invocation
Print deprecation warnings on any ctr command, as users won't notice the
deprecations until we actually remove the deprecated features.

The warnings can be suppressed by setting
`CONTAINERD_SUPPRESS_DEPRECATION_WARNINGS=1`.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2024-02-13 02:51:02 +09:00
Maksym Pavlenko
d4d228926c
Merge pull request #9804 from dims/revert-fix-for-k8s-nfs-related-tests
Revert "Fix for k8s nfs related tests"
2024-02-12 17:35:32 +00:00
Phil Estes
dff12d83fa
Merge pull request #9802 from austinvazquez/fix-links-in-snapshotter-docs
Fix unpacker link in remote snapshotter docs
2024-02-12 17:02:04 +00:00
Alexandru Matei
c2dfae8d05 go.mod: Bump golang.org/x/sys to v0.17.0
Replace internal LOOP_CONFIGURE ioctl implementation with
IoctlLoopConfigure from sys

Signed-off-by: Alexandru Matei <alexandru.matei@uipath.com>
2024-02-12 15:55:33 +02:00
Davanum Srinivas
2c7520d6eb
Merge pull request #9803 from mxpv/depr
Remove deprecated functions and packages
2024-02-11 13:10:46 +00:00
Davanum Srinivas
41bb8b816b
Revert "Fix for k8s nfs related tests"
This reverts commit 23ebfd0305.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2024-02-10 22:34:30 -05:00
Maksym Pavlenko
48c8c5f502 Remove ParseSignal from client
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
2024-02-10 18:02:05 -08:00
Maksym Pavlenko
281eb22ccd Remove deprecated dialer
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
2024-02-10 17:58:38 -08:00
Maksym Pavlenko
1ce7b99511 Remove deprecated filesys funcs
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
2024-02-10 17:55:57 -08:00
Maksym Pavlenko
5ca56ddbb4 Remove deprecated funcs from restart package
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
2024-02-10 17:54:48 -08:00
Maksym Pavlenko
653b808992 Remove deprecated docker package
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
2024-02-10 17:54:30 -08:00