Commit Graph

8706 Commits

Author SHA1 Message Date
Lantao Liu
26ab393e7d Use context.Background for O_NONBLOCK OpenFifo.
Signed-off-by: Lantao Liu <lantaol@google.com>
2019-01-23 10:18:54 -08:00
Justin Cormack
7db5697719
unix.UtimesNanoAt now supported on Darwin
unix.UtimesNanoAt now supported on Darwin and sets nanosecond precision if the filesystems does.
This call is now generally supported. Note that os.Chtimes also sets nanosecond precision,
but will always follow symlinks so not appropriate.

Signed-off-by: Justin Cormack <justin.cormack@docker.com>
2019-01-23 17:57:09 +00:00
Michael Crosby
aee74ad2f8
Merge pull request #2948 from fuweid/fix_linter_issue
fix: linter issue
2019-01-23 10:58:50 -05:00
Wei Fu
132ee9b826 fix: linter issue
megacheck, gosimple and unused has been deprecated and subsumed by
staticcheck. And staticcheck also has been upgraded. we need to update
code for the linter issue.

close: #2945

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2019-01-23 22:54:51 +08:00
Michael Crosby
35582cb7a3
Merge pull request #2899 from fuweid/proposal-add-Add-method-in-PlatformRuntime
runtime: add Add/Delete method in PlatformRuntime interface
2019-01-22 13:48:39 -05:00
Justin Terry (VM)
6468619d73 Implement the Runtime v2 Shim async task model for runhcs
Changes the requirement of a Runtime v2 shim in order to avoid race conditions
between shim and shim client sending async events. Places a requirement of what
events and what order a shim must comply to.

Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
2019-01-17 14:56:37 -08:00
Michael Crosby
3acf6f1835
Merge pull request #2936 from estesp/post-2622-cleanups
Handle additional cleanups from prior PR
2019-01-17 11:58:42 -05:00
zhoulin xie
ae1b7ac4fd Fix some typos in comment
Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>
2019-01-17 15:50:46 +08:00
Phil Estes
b444d7d507
Handle additional cleanups from prior PR
Update comment and streamline getting the default platform spec

Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
2019-01-16 13:07:29 -05:00
Phil Estes
df97414a77
Merge pull request #2622 from kadisi/export_bug
fix ctr image export not found error
2019-01-16 12:59:34 -05:00
Michael Crosby
7d75a3f282
Merge pull request #2935 from jhowardmsft/jjh/rightexitcode
Windows: Publish exit status correctly in TaskExit
2019-01-15 15:17:11 -05:00
Michael Crosby
4915476f11
Merge pull request #2934 from jhowardmsft/jjh/fifoset
Windows:NewDirectIOFromFIFOSet
2019-01-15 15:17:02 -05:00
John Howard
4ef9bf5c84 Windows: Publish exit status correctly in TaskExit
Signed-off-by: John Howard <jhoward@microsoft.com>

Before this change, the shim was only publishing a non-zero exit status
(exit code) in the case that the process.Wait() call failed. This
grabs the exit status correctly when process.Wait() succeeds too.
2019-01-15 11:12:27 -08:00
John Howard
90caf6f6a7 Windows:NewDirectIOFromFIFOSet
Signed-off-by: John Howard <jhoward@microsoft.com>
2019-01-15 10:04:43 -08:00
Michael Crosby
96f306ee4c
Merge pull request #2900 from Ace-Tang/fix_snapshot_remove
fix: miss remove temp file in createSnapshot
2019-01-15 11:42:27 -05:00
Phil Estes
804faeacdb
Merge pull request #2930 from cpuguy83/update_ttrpc
Update ttrpc to support context timeout.
2019-01-15 11:23:00 -05:00
Michael Crosby
4bad5c0247
Merge pull request #2931 from AkihiroSuda/runc20190115
bump up runc for pivot fix
2019-01-15 10:57:09 -05:00
Phil Estes
33b56e253e
Merge pull request #2927 from jterry75/bug_io_relay_close
Fix issue in runhcs shim CloseIO
2019-01-15 09:59:09 -05:00
Phil Estes
038d707889
Merge pull request #2929 from dmcgowan/releases-update
Update releases files
2019-01-15 09:58:15 -05:00
Akihiro Suda
3aec9e7beb bump up runc
Changes: 96ec2177ae...12f6a99120

Including critical security fix for `runc run --no-pivot` (`DOCKER_RAMDISK=1`): https://github.com/opencontainers/runc/pull/1962

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2019-01-15 16:27:31 +09:00
Brian Goff
0befa457d3 Update ttrpc to support context timeout.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2019-01-14 20:11:53 -08:00
Derek McGowan
946e402663
Update releases files
Brings versions and statuses up to date

Signed-off-by: Derek McGowan <derek@mcgstyle.net>
2019-01-14 15:42:55 -08:00
John Howard
e30bba53ff
Merge pull request #2926 from jterry75/bug_argon_mount
Fix runhcs shim bug in Create with "len(Rootfs) == 0"
2019-01-14 15:26:32 -08:00
Derek McGowan
5a6b18042b
Merge pull request #2925 from jterry75/bug_exec_pid
Fixes a bug in runhcs shim Exec.Pid
2019-01-14 14:48:48 -08:00
Phil Estes
c171b615ff
Merge pull request #2814 from fuweid/support_legacy_media_type
bugfix: support application/octet-stream during pull
2019-01-14 17:29:14 -05:00
Justin Terry (VM)
c5a8c9fc12 Fix issue in runhcs shim CloseIO
The call was closing all upstream IO when a shim.CloseIO call was made rather
than just the Stdin as it is supposed to.

Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
2019-01-14 13:31:28 -08:00
Justin Terry (VM)
31616e7945 Fix runhcs shim bug in Create with "len(Rootfs) == 0"
Rootfs length can be set to zero if the upstream caller fully manages storage
and mounts on their own. In this case just treat the bundle as a fully complete
OCI spec and run it without doing any storage work in the shim.

Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
2019-01-14 13:24:15 -08:00
Justin Terry (VM)
bcd4cc51c8 Fixes a bug in runhcs shim Exec.Pid
When an exec occurs the pid was not properly updated on the in memory state
value causing many queries to see a 0.

Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
2019-01-14 13:18:02 -08:00
Derek McGowan
8706a355dd
Merge pull request #2889 from linxiulei/isolated_content
metadata: define content sharing policy
2019-01-14 13:15:38 -08:00
Mike Brown
8976690320
Merge pull request #1021 from Random-Liu/move-no-metadata-test
Move no metadata test
2019-01-09 11:25:40 -06:00
Lantao Liu
5c40fd9585 Move no metadata test
Signed-off-by: Lantao Liu <lantaol@google.com>
2019-01-09 00:12:53 -08:00
Lantao Liu
76c5b20339
Merge pull request #1019 from teawater/add_test
Add integration test for RunPodSandbox and CreateContainer
2019-01-08 11:12:53 -08:00
Hui Zhu
ab84e3914d Add integration test for RunPodSandbox and CreateContainer
Fixes: #1009

Signed-off-by: Hui Zhu <teawater@hyper.sh>
2019-01-08 12:05:48 +08:00
Michael Crosby
adfaa697a8
Merge pull request #2887 from andrey-ko/args-fix
fix oci.WithImageConfigArgs for windows
2019-01-07 17:00:25 -05:00
Michael Crosby
b5a794649a
Merge pull request #2911 from estesp/security-audit
Add security audit report to README
2019-01-07 12:01:13 -05:00
Michael Crosby
fcf5462d49
Merge pull request #2914 from jterry75/runhcs_runtime_opts
Update runhcs options to include CRI Sandbox support
2019-01-07 11:54:41 -05:00
Michael Crosby
30003c4439
Merge pull request #2910 from jterry75/shim_shutdown_error_log
Fix spurious ttrpc client shutdown error log on success
2019-01-07 11:54:07 -05:00
Lantao Liu
a7d1b3c7dc
Merge pull request #1020 from Random-Liu/add-test-for-shared-pid-multi-process-container-stop
Add test for shared pid multi-process container stop.
2019-01-05 16:50:36 -08:00
Justin Terry (VM)
bc76e01a87 Update runhcs options to include CRI Sandbox support
Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
2019-01-04 14:37:10 -08:00
Lantao Liu
f0f68c1032 Add test for shared pid multi-process container stop.
Signed-off-by: Lantao Liu <lantaol@google.com>
2019-01-04 13:16:29 -08:00
Phil Estes
a79879e9dd
Add security audit report to README
Also remove weekly development reports section from README as those are
not being produced regularly at this time.

Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
2019-01-04 09:56:03 -05:00
Justin Terry (VM)
dee0945e18 Fix spurious ttrpc client shutdown error log on success
Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
2019-01-03 13:44:29 -08:00
Lantao Liu
a22f1c3416
Merge pull request #1017 from Random-Liu/add-unit-test
Add unit test for DisableCgroup, RestrictOOMScoreAdj.
2019-01-03 13:39:52 -08:00
Lantao Liu
b1ad4ee9b6 Add unit test for DisableCgroup, RestrictOOMScoreAdj.
Signed-off-by: Lantao Liu <lantaol@google.com>
2019-01-03 10:47:34 -08:00
Lantao Liu
0fa8668aa4
Merge pull request #970 from AkihiroSuda/rootless
support DisableCgroup, DisableApparmor, RestrictOOMScoreAdj
2019-01-03 10:14:22 -08:00
Lantao Liu
1fbd06479e
Merge pull request #1010 from teawater/fix_crash
Fix the issue that pod or container config file without metadata will…
2019-01-03 10:10:26 -08:00
Hui Zhu
3bfef01589 Fix the issue that pod or container config file without metadata will crash containerd
Because RunPodSandbox and CreateContainer will access metadata
without check, pod or container config file without metadata will
crash containerd.

This patch add checks to handle the issue.

Fixes: #1009

Signed-off-by: Hui Zhu <teawater@hyper.sh>
2019-01-03 11:02:10 +08:00
Akihiro Suda
231bff7f60
Merge pull request #2909 from Random-Liu/update-cri
Update cri to 4b4b2abb2e.
2019-01-03 06:48:05 +09:00
Lantao Liu
64a0046416 Update cri-tools to v1.13.0.
Signed-off-by: Lantao Liu <lantaol@google.com>
2019-01-02 12:54:55 -08:00
Akihiro Suda
cd8231ab2a support DisableCgroup, DisableApparmor, RestrictOOMScoreAdj
Add following config for supporting "rootless" mode

* DisableCgroup: disable cgroup
* DisableApparmor: disable Apparmor
* RestrictOOMScoreAdj: restrict the lower bound of OOMScoreAdj

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2019-01-03 05:12:04 +09:00