Michael Crosby
07e2b63d69
Send stderr on windows Terminal
...
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
2018-08-22 13:34:08 -04:00
Justin Terry (VM)
019b0c34de
Introduce containerd-shim-runhcs-v1 on Windows
...
Implements the containerd-shim-runhcs-v1 shim on Windows for the runtime
v2 shim API.
Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
2018-08-22 08:15:43 -07:00
Justin Terry (VM)
6a252a7141
IO Windows remove unused wait group
...
Removes an unused and unneeded wait group.
Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
2018-08-01 09:54:31 -07:00
Michael Crosby
fdceb13b14
Add cio.Load for loading io set
...
This adds a `Load` Opt for cio to load a tasks io/fifos without
attaching or starting the copy routines.
It adds the load method in `ctr` by default so that fifos or other IO
are removed from disk on delete methods inbetween command runs. It is
not the default for all task loads for backwards compat. and a user may
want to keep io around to reuse or if log files are used.
Fixes #2421
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
2018-06-26 11:48:26 -04:00
Vincent Demeester
832b05ae67
Update tests to use gotest.tools angel
...
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
2018-06-08 21:02:01 +02:00
Derek McGowan
6b9be1bfc3
Fix creation of DirectIO overwriting fifo config
...
Creating a direct IO should not overwrite the fifo
configuration. The fifo configuration can be updated
before creating the direct io if needed.
This fixes an expected change in behavior for clients
who were calling NewDirectIO previously with terminal
configured on the fifo.
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
2018-06-01 16:04:22 -07:00
Michael Crosby
1c263a7d5e
Add LogFile as a cio IO option
...
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
2018-04-26 17:04:01 -04:00
Evan Hazlett
6b4355d242
add NewDirectIOWithTerminal; add test for pty
...
Signed-off-by: Evan Hazlett <ejhazlett@gmail.com>
2018-04-25 16:17:10 -04:00
Kunal Kushwaha
3491b9ea4a
Copyright header added
...
Signed-off-by: Kunal Kushwaha <kushwaha_kunal_v7@lab.ntt.co.jp>
2018-03-05 10:07:58 +09:00
Stephen Day
0273e970a4
Merge pull request #2161 from IRCody/cio_panic
...
Fix panics in cio/io_unix.go
2018-02-26 13:45:45 -08:00
Cody Roseborough
4c5ebfee96
Fix panics in cio/io_unix.go
...
Add nil checks before closing fifos to avoid panic when fifo was never
opened.
Signed-off-by: Cody Roseborough <crrosebo@amazon.com>
2018-02-26 19:22:36 +00:00
Kunal Kushwaha
b12c3215a0
Licence header added
...
Signed-off-by: Kunal Kushwaha <kushwaha_kunal_v7@lab.ntt.co.jp>
2018-02-19 10:32:26 +09:00
Daniel Nephin
3279acca82
Check timestamps in snapshot storage test suite
...
also use t.Helper()
convert assertions to canonical
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
2018-02-12 12:26:26 -05:00
Daniel Nephin
37aa41b164
Cleanup after migration
...
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
2018-02-12 12:26:26 -05:00
Daniel Nephin
ef48a0268e
Migrate to gotestyourself/assert
...
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
2018-02-12 12:26:26 -05:00
Phil Estes
d7efcbc083
Merge pull request #2036 from stevvooe/use-buffer-pools
...
archive, cio, cmd, linux: use buffer pools
2018-01-23 15:00:41 -05:00
Stephen J Day
cd72819b53
archive, cio, cmd, linux: use buffer pools
...
To avoid buffer bloat in long running processes, we try to use buffer
pools where possible. This is meant to address shim memory usage issues,
but may not be the root cause.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2018-01-22 13:52:06 -08:00
Akihiro Suda
507a149488
cio: add WithFIFODir opt
...
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2018-01-18 14:33:56 +09:00
Lucas Molas
eda50b1fa6
Fix race condition in IO test (TestNewAttach)
...
Signed-off-by: Lucas Molas <lmolas@fundacionsadosky.org.ar>
2017-12-21 13:54:22 -03:00
Daniel Nephin
f34d030178
Add unit test for cio
...
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
2017-12-12 16:52:16 -05:00
Daniel Nephin
7d4337e738
Reduce the number of IO constructors
...
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
2017-12-11 15:07:09 -05:00
Daniel Nephin
a901091f7c
Rename cio.Creation to cio.Creator
...
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
2017-12-08 14:26:10 -05:00
Daniel Nephin
3146019918
Refactor cio.DirectIO
...
New code duplication
Better re-use from consumers of the cio package
TODO: io_windows.go
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
2017-12-08 14:26:10 -05:00
Daniel Nephin
f79ec5b55f
Cleanup cio.FIFOSet interface
...
Remove duplication with cio.Config
unexport newFIFOSetTempDir() since it includes hardcoded paths
Expose os.RemoveAll() as part of FIFOSet instead of a Dir
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
2017-12-08 14:26:10 -05:00
Daniel Nephin
65665ab807
Always Cancel before Close
...
Document this contract.
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
2017-12-08 10:30:36 -05:00
Daniel Nephin
298dabc6c2
Move io.go into cio package
...
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
2017-11-17 17:04:45 -05:00