github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity
13,124 Commits 3 Branches 2 Tags 112 MiB
db43e3d1f7
Commit Graph

13124 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Kirtana Ashok
8137e41c48 Add ArgsEscaped support for CRI 
This commit adds supports for the ArgsEscaped
value for the image got from the dockerfile.
It is used to evaluate and process the image
entrypoint/cmd and container entrypoint/cmd
options got from the podspec.

Signed-off-by: Kirtana Ashok <Kirtana.Ashok@microsoft.com>
 2023-03-03 13:38:06 -08:00
Wei Fu
5946c1051e *: fix code style issue 
1. it's easy to check wrong input if using drain_exec_sync_io_timeout in error
2. avoid to use full error message, as part of error generated by go
   stdlib would be changed in the future
3. delete the extra empty line

Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-03-03 17:51:03 +08:00
Wei Fu
98cb6d7eb8 cri/sbserver: ignore the NOT_FOUND error in exec cleanup 
Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-03-03 12:20:09 +08:00
Wei Fu
01671e9fc5 cri: add config ut for invalid drain io timeout value 
Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-03-03 12:00:19 +08:00
Wei Fu
55e25f1644 integration: add testcase to drain exec IO in time 
Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-03-03 11:59:07 +08:00
Wei Fu
ffebcb1223 cri: disable drain-exec-IO if it is empty timeout 
Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-03-03 11:59:07 +08:00
Wei Fu
791f137a5b *: update drainExecSyncIO docs and validate the timeout 
We should validate the drainExecSyncIO timeout at the beginning and
raise the error for any invalid input.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-03-03 11:58:52 +08:00
Derek McGowan
081d81858d
Merge pull request #8192 from dmcgowan/prepare-v1.7.0-rc.1 
Prepare release notes for v1.7.0-rc.1
 2023-03-02 13:03:36 -08:00
Derek McGowan
58d8c3a31d
Merge pull request #8191 from dmcgowan/transfer-export-image 
Transfer export image
 2023-03-02 13:03:18 -08:00
Derek McGowan
13bf5565eb
[transfer] update export to use image store references 
Signed-off-by: Derek McGowan <derek@mcg.dev>
 2023-03-02 11:14:32 -08:00
Derek McGowan
e2283edefb
[transfer] update export API types 
Signed-off-by: Derek McGowan <derek@mcg.dev>
 2023-03-02 09:04:29 -08:00
Jian Zeng
f6491b0049
feat: export images using Transfer api 
Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
 2023-03-02 09:04:25 -08:00
Jian Zeng
b9d7eae1ad
feat(api): add fields to ImageExportStream 
Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
 2023-03-02 09:01:53 -08:00
Phil Estes
477df4bd47
Merge pull request #8193 from fangn2/fix-config-dump 
Create config struct to take user input
 2023-03-02 11:37:49 -05:00
Wei Fu
3c18decea7 *: add DrainExecSyncIOTimeout config and disable as by default 
Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-03-03 00:21:55 +08:00
Wei Fu
a9cbddd65d *: fix typo and skip exec-io-drain-testcase in win 
Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-03-02 21:57:43 +08:00
Fu Wei
fd1db216db
Merge pull request #7864 from Iceber/ctr_tasks 
ctr/tasks: support remapped UID/GID
 2023-03-02 17:23:05 +08:00
Iceber Gu
b91f42a146 ctr/tasks: support remapped UID/GID 
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
 2023-03-02 14:02:14 +08:00
Tony Fang
2e96ba95e0 Create config struct to take user input 
Signed-off-by: Tony Fang <nhfang@amazon.com>
 2023-03-02 05:44:25 +00:00
Luca Comellini
f25ec98d0d
Fix linting error sets.String is deprecated 
Signed-off-by: Luca Comellini <luca.com@gmail.com>
 2023-03-01 21:37:30 -08:00
Luca Comellini
8145b15f08
Bump k8s.io deps 
Signed-off-by: Luca Comellini <luca.com@gmail.com>
 2023-03-01 21:37:21 -08:00
Wei Fu
04dfd6275e pkg/cri/sbserver: add timeout to drain exec io 
Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-03-02 13:06:45 +08:00
Wei Fu
82c0f4ff86 pkg/cri/server: add timeout to drain exec io 
By default, the child processes spawned by exec process will inherit standard
io file descriptors. The shim server creates a pipe as data channel. Both exec
process and its children write data into the write end of the pipe. And the
shim server will read data from the pipe. If the write end is still open, the
shim server will continue to wait for data from pipe.

So, if the exec command is like `bash -c "sleep 365d &"`, the exec process is
bash and quit after create `sleep 365d`. But the `sleep 365d` will hold the
write end of the pipe for a year! It doesn't make senses that CRI plugin
should wait for it.

For this case, we should use timeout to drain exec process's io instead of
waiting for it.

Fixes: #7802

Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-03-02 13:06:45 +08:00
Akihiro Suda
f50dce84f8
Merge pull request #8119 from dmcgowan/add-experimental-features-release 
Add experimental section to RELEASES.md
 2023-03-02 13:45:37 +09:00
Derek McGowan
43d36a2549
Add experimental section to RELEASES.md 
Signed-off-by: Derek McGowan <derek@mcg.dev>
 2023-03-01 17:56:57 -08:00
Akihiro Suda
4ced1fa69e
Merge pull request #8188 from dmcgowan/fix-streaming-gc-deadlock 
Fix streaming manager deadlock on collection
 2023-03-02 10:25:05 +09:00
Derek McGowan
7e93432be0
Merge pull request #8190 from bennett-white/update-cri-guide-link 
Update CRI guide link
 2023-03-01 17:18:15 -08:00
Derek McGowan
cd84f752c7
Prepare release notes for v1.7.0-rc.1 
Signed-off-by: Derek McGowan <derek@mcg.dev>
 2023-03-01 16:59:32 -08:00
Derek McGowan
ae42f836f4
Update mailmap 
Signed-off-by: Derek McGowan <derek@mcg.dev>
 2023-03-01 16:48:29 -08:00
Fu Wei
f681d409ed
Merge pull request #8189 from dmcgowan/shim-max-version 
Add max shim version environment variable
 2023-03-02 07:50:13 +08:00
Bennett-White
4522ad8866 Update CRI guide link 
Signed-off-by: Bennett-White <Bennett.White@ibm.com>
 2023-03-01 14:44:25 -05:00
Samuel Karp
5a9a370fbc
Merge pull request #8187 from estesp/sec-audit-move 2023-03-01 11:29:05 -08:00
Derek McGowan
d86cea9e2f
Merge pull request #8181 from davidhsingyuchen/fix-typo-data-flow 
docs: fix typos in historical/design/data-flow.md
 2023-03-01 11:28:20 -08:00
Derek McGowan
b8fcdbee8e
Merge pull request #8183 from aznashwan/windows-ci-test-timeout 
Increase CI workflow timeout on Windows.
 2023-03-01 11:27:38 -08:00
Derek McGowan
57fb2d30f0
Add max shim version environment variable 
Adds environment variable to shim start command

Signed-off-by: Derek McGowan <derek@mcg.dev>
 2023-03-01 11:20:49 -08:00
Derek McGowan
5c6e9f83d4
Fix streaming manager deadlock on collection 
Ensure that lock is released and stream is closed.

Signed-off-by: Derek McGowan <derek@mcg.dev>
 2023-03-01 09:40:59 -08:00
Phil Estes
acf6e9411a
Update README with location of security audits 
Now that we have a security page on the website with the Cure53 security
audit downloadable from there, update the README to point there and remove
the PDF from our docs/ directory.

Signed-off-by: Phil Estes <estesp@amazon.com>
 2023-03-01 09:21:18 -05:00
Nashwan Azhari
30883d8314 Increase CI workflow timeout on Windows. 
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
 2023-03-01 09:06:33 +02:00
Hsing-Yu (David) Chen
af7477e43e docs: fix typos in historical/design/data-flow.md 
Signed-off-by: Hsing-Yu (David) Chen <davidhsingyuchen@gmail.com>
 2023-02-28 15:32:12 -08:00
Maksym Pavlenko
759a6350bc
Merge pull request #8178 from samuelkarp/1.5-eol 
releases: mark 1.5 as EOL
 2023-02-28 13:04:53 -08:00
Samuel Karp
6b589a89fe
releases: mark 1.5 as EOL 
So long 1.5, you were a good release!

Signed-off-by: Samuel Karp <samuelkarp@google.com>
 2023-02-28 11:33:51 -08:00
Maksym Pavlenko
1944ef13e2
Merge pull request #8177 from dmcgowan/shim-version 
Add version to shim protocol
 2023-02-28 10:51:49 -08:00
Derek McGowan
590f55cdf5
Merge pull request #8164 from mxpv/install-protobuf 
Rework install-protobuf script and add new targets
 2023-02-28 09:08:14 -08:00
Derek McGowan
a5a4c9ce04
Merge pull request #8173 from fuweid/update-go-cni-ver 
bump go-cni to v1.1.9
 2023-02-27 23:22:44 -08:00
Derek McGowan
dba6f9db18
Add version to shim protocol 
Document environment variables and test shim start response parsing.

Signed-off-by: Derek McGowan <derek@mcg.dev>
 2023-02-27 22:58:47 -08:00
Fu Wei
33c0eafb17
Merge pull request #8172 from henry118/sbgc 
Treat sandboxes as root gc resources and scan referenced objects
 2023-02-28 09:58:36 +08:00
Akihiro Suda
e0a05b56e5
Merge pull request #8152 from bart0sh/PR007-upgrade-CDI-to-0.5.4 
update CDI version to v0.5.4
 2023-02-28 09:22:30 +09:00
Wei Fu
36ae2f6b9e bump go-cni to v1.1.9 
Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-02-28 07:30:59 +08:00
Henry Wang
cf46d3c6fc Treat sandboxes as root gc resources and scan referenced objects 
Signed-off-by: Henry Wang <henwang@amazon.com>
 2023-02-27 19:28:28 +00:00
Derek McGowan
2be87c1a75
Merge pull request #8162 from dmcgowan/prepare-1.7.0-rc.0 
Prepare release notes for v1.7.0-rc.0
 2023-02-27 09:50:25 -08:00