Rodrigo Campos
c99cb95f07
cri/sbserver: Let OCI runtime create netns when userns is used
...
This commit just ports 36f520dc04 ("Let OCI runtime create netns when
userns is used") to sbserver.
The CNI network setup is done after OCI start, as it didn't seem simple
to get the sandbox PID we need for the netns otherwise.
Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com >
2023-07-11 15:14:42 +02:00
Rodrigo Campos
0b6a0fe773
cri/sbserver: Move runtimeStart to match position with cri/server
...
Commit c085fac1e5 ("Move sandbox start behind controller") moved the
runtimeStart to only account for time _after_ the netns has been
created.
To match what we currently do in cri/server, let's move it to just after
the get the sandbox runtime.
This come up when porting userns to sbserver, as the CNI network setup
needs to be done at a later stage and runtimeStart was accounting for
the CNI network setup time only when userns is enabled.
To avoid that discrepancy, let's just move it earlier, that also matches
what we do in cri/server.
Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com >
2023-07-11 13:58:45 +02:00
Markus Lehtonen
f60a4a2718
cri: drop unused arg from generateRuntimeOptions
...
Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com >
2023-06-19 16:11:36 +03:00
Maksym Pavlenko
6f34da5f80
Cleanup logrus imports
...
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
2023-05-05 11:54:14 -07:00
Zhang Tianyang
5144ba9c49
sandbox: create sandbox with network namespace path
...
Signed-off-by: Zhang Tianyang <burning9699@gmail.com >
2023-03-08 18:54:14 +08:00
Kazuyoshi Kato
fe5d1d3e7c
Merge pull request #7954 from klihub/devel/sbserver-nri-integration
...
pkg/cri/sbserver: experimental NRI integration for CRI.
2023-02-15 10:42:25 -08:00
Casey Callendrello
0166783c79
cni: pass in the cgroupPath capability argument
...
There is a new CNI capability argument, cgroupPath, where runtimes can
pass cgroup paths to CNI plugins.
Implement that.
Signed-off-by: Casey Callendrello <cdc@isovalent.com >
2023-02-14 16:49:29 +01:00
Maksym Pavlenko
2b24af8d13
Use options to pass PodSandboxConfig to shims
...
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
2023-02-13 12:36:20 -08:00
Krisztian Litkey
ebbcb57a4c
pkg/cri/sbserver: experimental NRI integration for CRI.
...
Hook the NRI service plugin into CRI sbserver request
processing.
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com >
2023-02-13 22:08:18 +02:00
Derek McGowan
edb8ebaf07
Merge pull request #8047 from ruiwen-zhao/send_nil
...
Send container events with nil PodSandboxStatus
2023-02-13 11:38:14 -08:00
Akihiro Suda
b61988670c
go.mod: github.com/containerd/typeurl/v2 v2.1.0
...
Changes: https://github.com/containerd/typeurl/compare/7f6e6d160d67...v2.1.0
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp >
2023-02-11 23:39:52 +09:00
ruiwen-zhao
27c8f4085c
Move PLEG event generation back to sbserver to avoid missing pod sandbox status
...
Signed-off-by: ruiwen-zhao <ruiwen@google.com >
2023-02-11 01:34:33 +00:00
Fu Wei
362ba2c743
Merge pull request #7981 from dmcgowan/sandbox-controller-interface-refactor
...
[sandbox] refactor controller interface
2023-02-11 09:22:36 +08:00
Zechun Chen
b944b108df
Clean up repeated package import
...
Signed-off-by: Zechun Chen <zechun.chen@daocloud.io >
2023-02-10 16:21:55 +08:00
Derek McGowan
b0e97c0f9b
Use multierror for cleanup error
...
Signed-off-by: Derek McGowan <derek@mcg.dev >
2023-02-07 11:06:14 -08:00
Derek McGowan
2717685dad
Refactor sandbox controller interface
...
Update the sandbox controller interface to use local types rather than
using the API types.
Signed-off-by: Derek McGowan <derek@mcg.dev >
2023-02-06 21:39:30 -08:00
Maksym Pavlenko
1f35b03369
Fix sandbox exit monitor
...
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
2023-02-02 14:02:52 -08:00
Maksym Pavlenko
21fe0ceaad
Move PLEG events for pause container to podsandbox
...
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
2023-01-25 19:28:48 -08:00
Maksym Pavlenko
41eabf134a
Backport #7685 to sbserver
...
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
2023-01-17 14:26:16 -08:00
Antonio Ojea
ba0a7185f0
add network plugin metrics
...
Add network plugin metrics.
The metrics are the same that were used in dockershim/kubelet until
it was deprecated in kubernetes 1.23
https://github.com/kubernetes/kubernetes/blob/release-1.23/pkg/kubelet/dockershim/network/metrics/metrics.go
Signed-off-by: Antonio Ojea <aojea@google.com >
2022-12-23 09:23:56 +00:00
Danny Canter
84529072d2
CRI: Add host networking helper
...
We do a ton of host networking checks around the CRI plugin, all mainly
doing the same thing of checking the different quirks on various platforms
(for windows are we a HostProcess pod, for linux is namespace mode the
right thing, darwin doesn't have CNI support etc.) which could all be
bundled up into a small helper that can be re-used.
Signed-off-by: Danny Canter <danny@dcantah.dev >
2022-12-14 01:47:22 -08:00
Fu Wei
f2cf411b79
Merge pull request #7073 from ruiwen-zhao/event
...
Add container event support to containerd
2022-12-09 15:24:23 +08:00
ruiwen-zhao
a6929f9f6b
Add Evented PLEG support to sandbox server
...
Signed-off-by: ruiwen-zhao <ruiwen@google.com >
2022-12-08 19:31:36 +00:00
Maksym Pavlenko
f9295aa49f
Fix context when waiting sandbox
...
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
2022-12-07 12:52:04 -08:00
Maksym Pavlenko
9f4ba48839
[sandbox] Fix panic when waiting for sandbox controller
...
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
2022-11-28 13:29:21 -08:00
Maksym Pavlenko
dbc6d33ac5
[sandbox] Specify sandbox ID when using sandboxed shims
...
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
2022-11-28 13:27:54 -08:00
Maksym Pavlenko
3f331e7d13
Specify runtime configuration for sandbox shims
...
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
2022-11-22 17:39:27 -08:00
Samuel Karp
a74f7e902b
sbserver: save netns in sandbox metadata on create
...
Port of b41d6f40bb to sbserver
Signed-off-by: Samuel Karp <samuelkarp@google.com >
2022-11-21 16:45:37 -08:00
Samuel Karp
1deaedd38a
sbserver: persist sandbox during partial teardown
...
Port of 4f4aad057d to sbserver
Signed-off-by: Samuel Karp <samuelkarp@google.com >
2022-11-21 16:45:36 -08:00
Zhang Tianyang
c953eecb79
Sandbox API: Add a new mode config for sandbox controller impls
...
Add a new config as sandbox controller mod, which can be either
"podsandbox" or "shim". If empty, set it to default "podsandbox"
when CRI plugin inits.
Signed-off-by: Zhang Tianyang <burning9699@gmail.com >
2022-11-09 12:12:39 +08:00
Maksym Pavlenko
b7d0d12715
Cleanup sandbox interfaces
...
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
2022-10-25 12:31:32 -04:00
wanglei01
927906992f
CRI: implement Controller.Wait for SandboxAPI
...
Rework sandbox monitoring, we should rely on Controller.Wait instead of
CRIService.StartSandboxExitMonitor
Signed-off-by: WangLei <wllenyj@linux.alibaba.com >
2022-09-22 14:38:45 +08:00
Maksym Pavlenko
5cf77fc43d
Add TODOs for the remaining work
...
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
2022-08-04 10:29:15 -07:00
Maksym Pavlenko
8823224174
Update controller's start response to incldue pid and labels
...
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
2022-07-29 16:08:07 -07:00
Maksym Pavlenko
c085fac1e5
Move sandbox start behind controller
...
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
2022-07-29 16:08:07 -07:00
Maksym Pavlenko
cf5df7e4ac
Fork CRI server package
...
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
2022-07-13 10:54:59 -07:00