
This commit improves the fallback behaviour when resolving and fetching images with multiple hosts. If an error is encountered when resolving and fetching images, and more than one host is being used, we will try the same operation on the next host. The error from the first host is preserved so that if all hosts fail, we can display the error from the first host. fixes #3850 Signed-off-by: Alex Price <aprice@atlassian.com>
203 lines
5.5 KiB
Go
203 lines
5.5 KiB
Go
/*
|
|
Copyright The containerd Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package docker
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"net/url"
|
|
"strings"
|
|
|
|
"github.com/containerd/containerd/errdefs"
|
|
"github.com/containerd/containerd/images"
|
|
"github.com/containerd/containerd/log"
|
|
ocispec "github.com/opencontainers/image-spec/specs-go/v1"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
type dockerFetcher struct {
|
|
*dockerBase
|
|
}
|
|
|
|
func (r dockerFetcher) Fetch(ctx context.Context, desc ocispec.Descriptor) (io.ReadCloser, error) {
|
|
ctx = log.WithLogger(ctx, log.G(ctx).WithField("digest", desc.Digest))
|
|
|
|
hosts := r.filterHosts(HostCapabilityPull)
|
|
if len(hosts) == 0 {
|
|
return nil, errors.Wrap(errdefs.ErrNotFound, "no pull hosts")
|
|
}
|
|
|
|
ctx, err := contextWithRepositoryScope(ctx, r.refspec, false)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return newHTTPReadSeeker(desc.Size, func(offset int64) (io.ReadCloser, error) {
|
|
// firstly try fetch via external urls
|
|
for _, us := range desc.URLs {
|
|
ctx = log.WithLogger(ctx, log.G(ctx).WithField("url", us))
|
|
|
|
u, err := url.Parse(us)
|
|
if err != nil {
|
|
log.G(ctx).WithError(err).Debug("failed to parse")
|
|
continue
|
|
}
|
|
log.G(ctx).Debug("trying alternative url")
|
|
|
|
// Try this first, parse it
|
|
host := RegistryHost{
|
|
Client: http.DefaultClient,
|
|
Host: u.Host,
|
|
Scheme: u.Scheme,
|
|
Path: u.Path,
|
|
Capabilities: HostCapabilityPull,
|
|
}
|
|
req := r.request(host, http.MethodGet)
|
|
// Strip namespace from base
|
|
req.path = u.Path
|
|
if u.RawQuery != "" {
|
|
req.path = req.path + "?" + u.RawQuery
|
|
}
|
|
|
|
rc, err := r.open(ctx, req, desc.MediaType, offset)
|
|
if err != nil {
|
|
if errdefs.IsNotFound(err) {
|
|
continue // try one of the other urls.
|
|
}
|
|
|
|
return nil, err
|
|
}
|
|
|
|
return rc, nil
|
|
}
|
|
|
|
// Try manifests endpoints for manifests types
|
|
switch desc.MediaType {
|
|
case images.MediaTypeDockerSchema2Manifest, images.MediaTypeDockerSchema2ManifestList,
|
|
images.MediaTypeDockerSchema1Manifest,
|
|
ocispec.MediaTypeImageManifest, ocispec.MediaTypeImageIndex:
|
|
|
|
var firstErr error
|
|
for _, host := range r.hosts {
|
|
req := r.request(host, http.MethodGet, "manifests", desc.Digest.String())
|
|
|
|
rc, err := r.open(ctx, req, desc.MediaType, offset)
|
|
if err != nil {
|
|
// Store the error for referencing later
|
|
if firstErr == nil {
|
|
firstErr = err
|
|
}
|
|
continue // try another host
|
|
}
|
|
|
|
return rc, nil
|
|
}
|
|
|
|
return nil, firstErr
|
|
}
|
|
|
|
// Finally use blobs endpoints
|
|
var firstErr error
|
|
for _, host := range r.hosts {
|
|
req := r.request(host, http.MethodGet, "blobs", desc.Digest.String())
|
|
|
|
rc, err := r.open(ctx, req, desc.MediaType, offset)
|
|
if err != nil {
|
|
// Store the error for referencing later
|
|
if firstErr == nil {
|
|
firstErr = err
|
|
}
|
|
continue // try another host
|
|
}
|
|
|
|
return rc, nil
|
|
}
|
|
|
|
if errdefs.IsNotFound(firstErr) {
|
|
firstErr = errors.Wrapf(errdefs.ErrNotFound,
|
|
"could not fetch content descriptor %v (%v) from remote",
|
|
desc.Digest, desc.MediaType)
|
|
}
|
|
|
|
return nil, firstErr
|
|
|
|
})
|
|
}
|
|
|
|
func (r dockerFetcher) open(ctx context.Context, req *request, mediatype string, offset int64) (io.ReadCloser, error) {
|
|
req.header.Set("Accept", strings.Join([]string{mediatype, `*/*`}, ", "))
|
|
|
|
if offset > 0 {
|
|
// Note: "Accept-Ranges: bytes" cannot be trusted as some endpoints
|
|
// will return the header without supporting the range. The content
|
|
// range must always be checked.
|
|
req.header.Set("Range", fmt.Sprintf("bytes=%d-", offset))
|
|
}
|
|
|
|
resp, err := req.doWithRetries(ctx, nil)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if resp.StatusCode > 299 {
|
|
// TODO(stevvooe): When doing a offset specific request, we should
|
|
// really distinguish between a 206 and a 200. In the case of 200, we
|
|
// can discard the bytes, hiding the seek behavior from the
|
|
// implementation.
|
|
defer resp.Body.Close()
|
|
|
|
if resp.StatusCode == http.StatusNotFound {
|
|
return nil, errors.Wrapf(errdefs.ErrNotFound, "content at %v not found", req.String())
|
|
}
|
|
var registryErr Errors
|
|
if err := json.NewDecoder(resp.Body).Decode(®istryErr); err != nil || registryErr.Len() < 1 {
|
|
return nil, errors.Errorf("unexpected status code %v: %v", req.String(), resp.Status)
|
|
}
|
|
return nil, errors.Errorf("unexpected status code %v: %s - Server message: %s", req.String(), resp.Status, registryErr.Error())
|
|
}
|
|
if offset > 0 {
|
|
cr := resp.Header.Get("content-range")
|
|
if cr != "" {
|
|
if !strings.HasPrefix(cr, fmt.Sprintf("bytes %d-", offset)) {
|
|
return nil, errors.Errorf("unhandled content range in response: %v", cr)
|
|
|
|
}
|
|
} else {
|
|
// TODO: Should any cases where use of content range
|
|
// without the proper header be considered?
|
|
// 206 responses?
|
|
|
|
// Discard up to offset
|
|
// Could use buffer pool here but this case should be rare
|
|
n, err := io.Copy(ioutil.Discard, io.LimitReader(resp.Body, offset))
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "failed to discard to offset")
|
|
}
|
|
if n != offset {
|
|
return nil, errors.Errorf("unable to discard to offset")
|
|
}
|
|
|
|
}
|
|
}
|
|
|
|
return resp.Body, nil
|
|
}
|