
We should never return a nil context because of the way this function is typically used... e.g. ``` ctx, done, err := containerd.WithLease(ctx) ``` If there is an error `ctx` will be nil and any error handling may cause an NPE if it tries to use `ctx`. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
74 lines
2.1 KiB
Go
74 lines
2.1 KiB
Go
/*
|
|
Copyright The containerd Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package images
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/containerd/containerd/cmd/ctr/commands"
|
|
"github.com/containerd/containerd/errdefs"
|
|
"github.com/containerd/containerd/leases"
|
|
"github.com/containerd/containerd/mount"
|
|
"github.com/pkg/errors"
|
|
"github.com/urfave/cli"
|
|
)
|
|
|
|
var unmountCommand = cli.Command{
|
|
Name: "unmount",
|
|
Usage: "unmount the image from the target",
|
|
ArgsUsage: "[flags] <target>",
|
|
Description: "Unmount the image rootfs from the specified target.",
|
|
Flags: append(append(commands.RegistryFlags, append(commands.SnapshotterFlags, commands.LabelFlag)...),
|
|
cli.BoolFlag{
|
|
Name: "rm",
|
|
Usage: "remove the snapshot after a successful unmount",
|
|
},
|
|
),
|
|
Action: func(context *cli.Context) error {
|
|
var (
|
|
target = context.Args().First()
|
|
)
|
|
if target == "" {
|
|
return fmt.Errorf("please provide a target path to mount to")
|
|
}
|
|
|
|
client, ctx, cancel, err := commands.NewClient(context)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer cancel()
|
|
|
|
if err := mount.UnmountAll(target, 0); err != nil {
|
|
return err
|
|
}
|
|
|
|
if context.Bool("rm") {
|
|
snapshotter := context.String("snapshotter")
|
|
s := client.SnapshotService(snapshotter)
|
|
if err := client.LeasesService().Delete(ctx, leases.Lease{ID: target}); err != nil && !errdefs.IsNotFound(err) {
|
|
return errors.Wrap(err, "error deleting lease")
|
|
}
|
|
if err := s.Remove(ctx, target); err != nil && !errdefs.IsNotFound(err) {
|
|
return errors.Wrap(err, "error removing snapshot")
|
|
}
|
|
}
|
|
|
|
fmt.Fprintln(context.App.Writer, target)
|
|
return nil
|
|
},
|
|
}
|