4ce334aa49
With go RWMutex design, no goroutine should expect to be able to acquire a read lock until the read lock has been released, if one goroutine call lock. The original design is to reload cni network config on every single Status CRI gRPC call. If one RunPodSandbox request holds read lock to allocate IP for too long, all other RunPodSandbox/StopPodSandbox requests will wait for the RunPodSandbox request to release read lock. And the Status CRI call will fail and kubelet becomes NOTReady. Reload cni network config at every single Status CRI call is not necessary and also brings NOTReady situation. To lower the possibility of NOTReady, CRI will reload cni network config if there is any valid fs change events from the cni network config dir. Signed-off-by: Wei Fu <fuweid89@gmail.com>
84 lines
2.4 KiB
Go
84 lines
2.4 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package server
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
goruntime "runtime"
|
|
|
|
"github.com/containerd/containerd/log"
|
|
"golang.org/x/net/context"
|
|
runtime "k8s.io/cri-api/pkg/apis/runtime/v1alpha2"
|
|
)
|
|
|
|
// networkNotReadyReason is the reason reported when network is not ready.
|
|
const networkNotReadyReason = "NetworkPluginNotReady"
|
|
|
|
// Status returns the status of the runtime.
|
|
func (c *criService) Status(ctx context.Context, r *runtime.StatusRequest) (*runtime.StatusResponse, error) {
|
|
// As a containerd plugin, if CRI plugin is serving request,
|
|
// containerd must be ready.
|
|
runtimeCondition := &runtime.RuntimeCondition{
|
|
Type: runtime.RuntimeReady,
|
|
Status: true,
|
|
}
|
|
networkCondition := &runtime.RuntimeCondition{
|
|
Type: runtime.NetworkReady,
|
|
Status: true,
|
|
}
|
|
// Check the status of the cni initialization
|
|
if err := c.netPlugin.Status(); err != nil {
|
|
networkCondition.Status = false
|
|
networkCondition.Reason = networkNotReadyReason
|
|
networkCondition.Message = fmt.Sprintf("Network plugin returns error: %v", err)
|
|
}
|
|
|
|
resp := &runtime.StatusResponse{
|
|
Status: &runtime.RuntimeStatus{Conditions: []*runtime.RuntimeCondition{
|
|
runtimeCondition,
|
|
networkCondition,
|
|
}},
|
|
}
|
|
if r.Verbose {
|
|
configByt, err := json.Marshal(c.config)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
resp.Info = make(map[string]string)
|
|
resp.Info["config"] = string(configByt)
|
|
versionByt, err := json.Marshal(goruntime.Version())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
resp.Info["golang"] = string(versionByt)
|
|
|
|
cniConfig, err := json.Marshal(c.netPlugin.GetConfig())
|
|
if err != nil {
|
|
log.G(ctx).WithError(err).Errorf("Failed to marshal CNI config %v", err)
|
|
}
|
|
resp.Info["cniconfig"] = string(cniConfig)
|
|
|
|
lastCNILoadStatus := "OK"
|
|
if lerr := c.cniNetConfMonitor.lastStatus(); lerr != nil {
|
|
lastCNILoadStatus = lerr.Error()
|
|
}
|
|
resp.Info["lastCNILoadStatus"] = lastCNILoadStatus
|
|
}
|
|
return resp, nil
|
|
}
|