This is effectively a revert of 2ac9968401, which
switched from os/exec to the golang.org/x/sys/execabs package to mitigate
security issues (mainly on Windows) with lookups resolving to binaries in the
current directory.
from the go1.19 release notes https://go.dev/doc/go1.19#os-exec-path
> ## PATH lookups
>
> Command and LookPath no longer allow results from a PATH search to be found
> relative to the current directory. This removes a common source of security
> problems but may also break existing programs that depend on using, say,
> exec.Command("prog") to run a binary named prog (or, on Windows, prog.exe) in
> the current directory. See the os/exec package documentation for information
> about how best to update such programs.
>
> On Windows, Command and LookPath now respect the NoDefaultCurrentDirectoryInExePath
> environment variable, making it possible to disable the default implicit search
> of “.” in PATH lookups on Windows systems.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
		
	
		
			
				
	
	
		
			134 lines
		
	
	
		
			3.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			134 lines
		
	
	
		
			3.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
/*
 | 
						|
   Copyright The containerd Authors.
 | 
						|
 | 
						|
   Licensed under the Apache License, Version 2.0 (the "License");
 | 
						|
   you may not use this file except in compliance with the License.
 | 
						|
   You may obtain a copy of the License at
 | 
						|
 | 
						|
       http://www.apache.org/licenses/LICENSE-2.0
 | 
						|
 | 
						|
   Unless required by applicable law or agreed to in writing, software
 | 
						|
   distributed under the License is distributed on an "AS IS" BASIS,
 | 
						|
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | 
						|
   See the License for the specific language governing permissions and
 | 
						|
   limitations under the License.
 | 
						|
*/
 | 
						|
 | 
						|
package mount
 | 
						|
 | 
						|
import (
 | 
						|
	"errors"
 | 
						|
	"fmt"
 | 
						|
	"os"
 | 
						|
	"os/exec"
 | 
						|
	"time"
 | 
						|
 | 
						|
	"golang.org/x/sys/unix"
 | 
						|
)
 | 
						|
 | 
						|
var (
 | 
						|
	// ErrNotImplementOnUnix is returned for methods that are not implemented
 | 
						|
	ErrNotImplementOnUnix = errors.New("not implemented under unix")
 | 
						|
)
 | 
						|
 | 
						|
// Mount to the provided target.
 | 
						|
//
 | 
						|
// The "syscall" and "golang.org/x/sys/unix" packages do not define a Mount
 | 
						|
// function for FreeBSD, so instead we execute mount(8) and trust it to do
 | 
						|
// the right thing
 | 
						|
func (m *Mount) mount(target string) error {
 | 
						|
	// target: "/foo/target"
 | 
						|
	// command: "mount -o ro -t nullfs /foo/source /foo/merged"
 | 
						|
	// Note: FreeBSD mount(8) is particular about the order of flags and arguments
 | 
						|
	var args []string
 | 
						|
	for _, o := range m.Options {
 | 
						|
		args = append(args, "-o", o)
 | 
						|
	}
 | 
						|
	args = append(args, "-t", m.Type)
 | 
						|
	args = append(args, m.Source, target)
 | 
						|
 | 
						|
	infoBeforeMount, err := Lookup(target)
 | 
						|
	if err != nil {
 | 
						|
		return err
 | 
						|
	}
 | 
						|
 | 
						|
	// cmd.CombinedOutput() may intermittently return ECHILD because of our signal handling in shim.
 | 
						|
	// See #4387 and wait(2).
 | 
						|
	const retriesOnECHILD = 10
 | 
						|
	for i := 0; i < retriesOnECHILD; i++ {
 | 
						|
		cmd := exec.Command("mount", args...)
 | 
						|
		out, err := cmd.CombinedOutput()
 | 
						|
		if err == nil {
 | 
						|
			return nil
 | 
						|
		}
 | 
						|
		if !errors.Is(err, unix.ECHILD) {
 | 
						|
			return fmt.Errorf("mount [%v] failed: %q: %w", args, string(out), err)
 | 
						|
		}
 | 
						|
		// We got ECHILD, we are not sure whether the mount was successful.
 | 
						|
		// If the mount ID has changed, we are sure we got some new mount, but still not sure it is fully completed.
 | 
						|
		// So we attempt to unmount the new mount before retrying.
 | 
						|
		infoAfterMount, err := Lookup(target)
 | 
						|
		if err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
		if infoAfterMount.ID != infoBeforeMount.ID {
 | 
						|
			_ = unmount(target, 0)
 | 
						|
		}
 | 
						|
	}
 | 
						|
	return fmt.Errorf("mount [%v] failed with ECHILD (retried %d times)", args, retriesOnECHILD)
 | 
						|
}
 | 
						|
 | 
						|
// Unmount the provided mount path with the flags
 | 
						|
func Unmount(target string, flags int) error {
 | 
						|
	if err := unmount(target, flags); err != nil && err != unix.EINVAL {
 | 
						|
		return err
 | 
						|
	}
 | 
						|
	return nil
 | 
						|
}
 | 
						|
 | 
						|
func unmount(target string, flags int) error {
 | 
						|
	for i := 0; i < 50; i++ {
 | 
						|
		if err := unix.Unmount(target, flags); err != nil {
 | 
						|
			switch err {
 | 
						|
			case unix.EBUSY:
 | 
						|
				time.Sleep(50 * time.Millisecond)
 | 
						|
				continue
 | 
						|
			default:
 | 
						|
				return err
 | 
						|
			}
 | 
						|
		}
 | 
						|
		return nil
 | 
						|
	}
 | 
						|
	return fmt.Errorf("failed to unmount target %s: %w", target, unix.EBUSY)
 | 
						|
}
 | 
						|
 | 
						|
// UnmountAll repeatedly unmounts the given mount point until there
 | 
						|
// are no mounts remaining (EINVAL is returned by mount), which is
 | 
						|
// useful for undoing a stack of mounts on the same mount point.
 | 
						|
// UnmountAll all is noop when the first argument is an empty string.
 | 
						|
// This is done when the containerd client did not specify any rootfs
 | 
						|
// mounts (e.g. because the rootfs is managed outside containerd)
 | 
						|
// UnmountAll is noop when the mount path does not exist.
 | 
						|
func UnmountAll(mount string, flags int) error {
 | 
						|
	if mount == "" {
 | 
						|
		return nil
 | 
						|
	}
 | 
						|
	if _, err := os.Stat(mount); os.IsNotExist(err) {
 | 
						|
		return nil
 | 
						|
	}
 | 
						|
 | 
						|
	for {
 | 
						|
		if err := unmount(mount, flags); err != nil {
 | 
						|
			// EINVAL is returned if the target is not a
 | 
						|
			// mount point, indicating that we are
 | 
						|
			// done. It can also indicate a few other
 | 
						|
			// things (such as invalid flags) which we
 | 
						|
			// unfortunately end up squelching here too.
 | 
						|
			if err == unix.EINVAL {
 | 
						|
				return nil
 | 
						|
			}
 | 
						|
			return err
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 |