31a6449734
This allows user namespace support to progress, either by allowing snapshotters to deal with ownership, or falling back to containerd doing a recursive chown. In the future, when snapshotters implement idmap mounts, they should report the "remap-ids" capability. Co-authored-by: Rodrigo Campos <rodrigoca@microsoft.com> Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com> Signed-off-by: David Leadbeater <dgl@dgl.cx>
125 lines
4.6 KiB
Go
125 lines
4.6 KiB
Go
/*
|
|
Copyright The containerd Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package server
|
|
|
|
import (
|
|
"fmt"
|
|
"strconv"
|
|
|
|
"github.com/containerd/containerd"
|
|
"github.com/containerd/containerd/oci"
|
|
"github.com/containerd/containerd/snapshots"
|
|
imagespec "github.com/opencontainers/image-spec/specs-go/v1"
|
|
runtimespec "github.com/opencontainers/runtime-spec/specs-go"
|
|
runtime "k8s.io/cri-api/pkg/apis/runtime/v1"
|
|
|
|
"github.com/containerd/containerd/pkg/cri/annotations"
|
|
customopts "github.com/containerd/containerd/pkg/cri/opts"
|
|
)
|
|
|
|
func (c *criService) sandboxContainerSpec(id string, config *runtime.PodSandboxConfig,
|
|
imageConfig *imagespec.ImageConfig, nsPath string, runtimePodAnnotations []string) (*runtimespec.Spec, error) {
|
|
// Creates a spec Generator with the default spec.
|
|
specOpts := []oci.SpecOpts{
|
|
oci.WithEnv(imageConfig.Env),
|
|
oci.WithHostname(config.GetHostname()),
|
|
}
|
|
if imageConfig.WorkingDir != "" {
|
|
specOpts = append(specOpts, oci.WithProcessCwd(imageConfig.WorkingDir))
|
|
}
|
|
|
|
if len(imageConfig.Entrypoint) == 0 && len(imageConfig.Cmd) == 0 {
|
|
// Pause image must have entrypoint or cmd.
|
|
return nil, fmt.Errorf("invalid empty entrypoint and cmd in image config %+v", imageConfig)
|
|
}
|
|
specOpts = append(specOpts, oci.WithProcessArgs(append(imageConfig.Entrypoint, imageConfig.Cmd...)...))
|
|
|
|
specOpts = append(specOpts,
|
|
// Clear the root location since hcsshim expects it.
|
|
// NOTE: readonly rootfs doesn't work on windows.
|
|
customopts.WithoutRoot,
|
|
oci.WithWindowsNetworkNamespace(nsPath),
|
|
)
|
|
|
|
specOpts = append(specOpts, customopts.WithWindowsDefaultSandboxShares)
|
|
|
|
// Start with the image config user and override below if RunAsUsername is not "".
|
|
username := imageConfig.User
|
|
|
|
runAsUser := config.GetWindows().GetSecurityContext().GetRunAsUsername()
|
|
if runAsUser != "" {
|
|
username = runAsUser
|
|
}
|
|
|
|
cs := config.GetWindows().GetSecurityContext().GetCredentialSpec()
|
|
if cs != "" {
|
|
specOpts = append(specOpts, customopts.WithWindowsCredentialSpec(cs))
|
|
}
|
|
|
|
// There really isn't a good Windows way to verify that the username is available in the
|
|
// image as early as here like there is for Linux. Later on in the stack hcsshim
|
|
// will handle the behavior of erroring out if the user isn't available in the image
|
|
// when trying to run the init process.
|
|
specOpts = append(specOpts, oci.WithUser(username))
|
|
|
|
for pKey, pValue := range getPassthroughAnnotations(config.Annotations,
|
|
runtimePodAnnotations) {
|
|
specOpts = append(specOpts, customopts.WithAnnotation(pKey, pValue))
|
|
}
|
|
|
|
specOpts = append(specOpts,
|
|
customopts.WithAnnotation(annotations.ContainerType, annotations.ContainerTypeSandbox),
|
|
customopts.WithAnnotation(annotations.SandboxID, id),
|
|
customopts.WithAnnotation(annotations.SandboxNamespace, config.GetMetadata().GetNamespace()),
|
|
customopts.WithAnnotation(annotations.SandboxUID, config.GetMetadata().GetUid()),
|
|
customopts.WithAnnotation(annotations.SandboxName, config.GetMetadata().GetName()),
|
|
customopts.WithAnnotation(annotations.SandboxLogDir, config.GetLogDirectory()),
|
|
customopts.WithAnnotation(annotations.WindowsHostProcess, strconv.FormatBool(config.GetWindows().GetSecurityContext().GetHostProcess())),
|
|
)
|
|
|
|
return c.runtimeSpec(id, "", specOpts...)
|
|
}
|
|
|
|
// No sandbox container spec options for windows yet.
|
|
func (c *criService) sandboxContainerSpecOpts(config *runtime.PodSandboxConfig, imageConfig *imagespec.ImageConfig) ([]oci.SpecOpts, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
// No sandbox files needed for windows.
|
|
func (c *criService) setupSandboxFiles(id string, config *runtime.PodSandboxConfig) error {
|
|
return nil
|
|
}
|
|
|
|
// No sandbox files needed for windows.
|
|
func (c *criService) cleanupSandboxFiles(id string, config *runtime.PodSandboxConfig) error {
|
|
return nil
|
|
}
|
|
|
|
// No task options needed for windows.
|
|
func (c *criService) taskOpts(runtimeType string) []containerd.NewTaskOpts {
|
|
return nil
|
|
}
|
|
|
|
func (c *criService) updateNetNamespacePath(spec *runtimespec.Spec, nsPath string) {
|
|
spec.Windows.Network.NetworkNamespace = nsPath
|
|
}
|
|
|
|
// No sandbox snapshotter options needed for windows.
|
|
func sandboxSnapshotterOpts(config *runtime.PodSandboxConfig) ([]snapshots.Opt, error) {
|
|
return []snapshots.Opt{}, nil
|
|
}
|