Includes security fixes for net/http (CVE-2022-41717, CVE-2022-41720),
and os (CVE-2022-41720).
These minor releases include 2 security fixes following the security policy:
- os, net/http: avoid escapes from os.DirFS and http.Dir on Windows
The os.DirFS function and http.Dir type provide access to a tree of files
rooted at a given directory. These functions permitted access to Windows
device files under that root. For example, os.DirFS("C:/tmp").Open("COM1")
would open the COM1 device.
Both os.DirFS and http.Dir only provide read-only filesystem access.
In addition, on Windows, an os.DirFS for the directory \(the root of the
current drive) can permit a maliciously crafted path to escape from the
drive and access any path on the system.
The behavior of os.DirFS("") has changed. Previously, an empty root was
treated equivalently to "/", so os.DirFS("").Open("tmp") would open the
path "/tmp". This now returns an error.
This is CVE-2022-41720 and Go issue https://go.dev/issue/56694.
- net/http: limit canonical header cache by bytes, not entries
An attacker can cause excessive memory growth in a Go server accepting
HTTP/2 requests.
HTTP/2 server connections contain a cache of HTTP header keys sent by
the client. While the total number of entries in this cache is capped,
an attacker sending very large keys can cause the server to allocate
approximately 64 MiB per open connection.
This issue is also fixed in golang.org/x/net/http2 vX.Y.Z, for users
manually configuring HTTP/2.
Thanks to Josselin Costanzi for reporting this issue.
This is CVE-2022-41717 and Go issue https://go.dev/issue/56350.
View the release notes for more information:
https://go.dev/doc/devel/release#go1.19.4
And the milestone on the issue tracker:
https://github.com/golang/go/issues?q=milestone%3AGo1.19.4+label%3ACherryPickApproved
Full diff: https://github.com/golang/go/compare/go1.19.3...go1.19.4
The golang.org/x/net fix is in 1e63c2f08a
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
152 lines
5.5 KiB
YAML
152 lines
5.5 KiB
YAML
on:
|
|
push:
|
|
tags:
|
|
- "v*" # Push events to matching v*, i.e. v1.0, v20.15.10
|
|
|
|
name: Containerd Release
|
|
|
|
env:
|
|
GO_VERSION: "1.19.4"
|
|
|
|
permissions: # added using https://github.com/step-security/secure-workflows
|
|
contents: read
|
|
|
|
jobs:
|
|
check:
|
|
name: Check Signed Tag
|
|
runs-on: ubuntu-20.04
|
|
timeout-minutes: 5
|
|
outputs:
|
|
stringver: ${{ steps.contentrel.outputs.stringver }}
|
|
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v3
|
|
with:
|
|
ref: ${{ github.ref }}
|
|
path: src/github.com/containerd/containerd
|
|
|
|
- name: Check signature
|
|
run: |
|
|
releasever=${{ github.ref }}
|
|
releasever="${releasever#refs/tags/}"
|
|
TAGCHECK=$(git tag -v ${releasever} 2>&1 >/dev/null) ||
|
|
echo "${TAGCHECK}" | grep -q "error" && {
|
|
echo "::error::tag ${releasever} is not a signed tag. Failing release process."
|
|
exit 1
|
|
} || {
|
|
echo "Tag ${releasever} is signed."
|
|
exit 0
|
|
}
|
|
working-directory: src/github.com/containerd/containerd
|
|
|
|
- name: Release content
|
|
id: contentrel
|
|
run: |
|
|
RELEASEVER=${{ github.ref }}
|
|
echo "stringver=${RELEASEVER#refs/tags/v}" >> $GITHUB_OUTPUT
|
|
git tag -l ${RELEASEVER#refs/tags/} -n20000 | tail -n +3 | cut -c 5- >release-notes.md
|
|
working-directory: src/github.com/containerd/containerd
|
|
|
|
- name: Save release notes
|
|
uses: actions/upload-artifact@v3
|
|
with:
|
|
name: containerd-release-notes
|
|
path: src/github.com/containerd/containerd/release-notes.md
|
|
|
|
build:
|
|
name: Build Release Binaries
|
|
runs-on: ubuntu-20.04
|
|
needs: [check]
|
|
timeout-minutes: 30
|
|
strategy:
|
|
matrix:
|
|
include:
|
|
# Choose an old release of Ubuntu to avoid glibc issue https://github.com/containerd/containerd/issues/7255
|
|
- dockerfile-ubuntu: 18.04
|
|
dockerfile-platform: linux/amd64
|
|
- dockerfile-ubuntu: 18.04
|
|
dockerfile-platform: linux/arm64
|
|
- dockerfile-ubuntu: 18.04
|
|
dockerfile-platform: linux/ppc64le
|
|
- dockerfile-ubuntu: 18.04
|
|
dockerfile-platform: linux/s390x
|
|
# riscv64 isn't supported by Ubuntu 18.04
|
|
- dockerfile-ubuntu: 22.04
|
|
dockerfile-platform: linux/riscv64
|
|
- dockerfile-ubuntu: 18.04
|
|
dockerfile-platform: windows/amd64
|
|
steps:
|
|
- name: Set env
|
|
shell: bash
|
|
env:
|
|
MOS: ubuntu-20.04
|
|
run: |
|
|
releasever=${{ github.ref }}
|
|
releasever="${releasever#refs/tags/}"
|
|
echo "RELEASE_VER=${releasever}" >> $GITHUB_ENV
|
|
echo "GOPATH=${{ github.workspace }}" >> $GITHUB_ENV
|
|
- name: Checkout containerd
|
|
uses: actions/checkout@v3
|
|
with:
|
|
# Intentionally use github.repository instead of containerd/containerd to
|
|
# make this action runnable on forks.
|
|
# See https://github.com/containerd/containerd/issues/5098 for the context.
|
|
repository: ${{ github.repository }}
|
|
ref: ${{ github.ref }}
|
|
path: src/github.com/containerd/containerd
|
|
|
|
- name: Setup buildx instance
|
|
uses: docker/setup-buildx-action@v1
|
|
with:
|
|
use: true
|
|
- uses: crazy-max/ghaction-github-runtime@v1 # sets up needed vars for caching to github
|
|
- name: Make
|
|
shell: bash
|
|
run: |
|
|
cache="--cache-from=type=gha,scope=containerd-release --cache-to=type=gha,scope=containerd-release"
|
|
if [[ "${PLATFORM}" =~ "windows" ]]; then
|
|
# For Windows the cni build script generates a config but shells out to powershell (and also assume it is running on windows) to get a gateway and subnet.
|
|
# The values provided here are taken from packages that we previously generated.
|
|
export GATEWAY=172.21.16.1
|
|
export PREFIX_LEN=12
|
|
BUILD_ARGS="--build-arg GATEWAY --build-arg PREFIX_LEN"
|
|
fi
|
|
docker buildx build ${cache} --build-arg RELEASE_VER --build-arg UBUNTU_VERSION=${{ matrix.dockerfile-ubuntu }} --build-arg GO_VERSION ${BUILD_ARGS} -f .github/workflows/release/Dockerfile --platform=${PLATFORM} -o releases/ .
|
|
echo PLATFORM_CLEAN=${PLATFORM/\//-} >> $GITHUB_ENV
|
|
|
|
# Remove symlinks since we don't want these in the release Artifacts
|
|
find ./releases/ -maxdepth 1 -type l | xargs rm
|
|
working-directory: src/github.com/containerd/containerd
|
|
env:
|
|
PLATFORM: ${{ matrix.dockerfile-platform }}
|
|
- name: Save Artifacts
|
|
uses: actions/upload-artifact@v3
|
|
with:
|
|
name: release-tars-${{env.PLATFORM_CLEAN}}
|
|
path: src/github.com/containerd/containerd/releases/*.tar.gz*
|
|
|
|
release:
|
|
name: Create containerd Release
|
|
permissions:
|
|
contents: write
|
|
runs-on: ubuntu-20.04
|
|
timeout-minutes: 10
|
|
needs: [build, check]
|
|
steps:
|
|
- name: Download builds and release notes
|
|
uses: actions/download-artifact@v2
|
|
with:
|
|
path: builds
|
|
- name: Create Release
|
|
uses: softprops/action-gh-release@v1
|
|
with:
|
|
token: ${{ secrets.GITHUB_TOKEN }}
|
|
fail_on_unmatched_files: true
|
|
name: containerd ${{ needs.check.outputs.stringver }}
|
|
draft: false
|
|
prerelease: ${{ contains(github.ref, 'beta') || contains(github.ref, 'rc') }}
|
|
body_path: ./builds/containerd-release-notes/release-notes.md
|
|
files: |
|
|
builds/release-tars-**/*
|