containerd/diff
Daniel Canter d2588b3fa4 LCOW differ return ErrNotImplemented for wrong mount type
On Windows the two differs we register by default are the "windows" and
"windows-lcow" differs. The diff service checks if Apply returns
ErrNotImplemented and will move on to the next differ in the line.
The Windows differ makes use of this to fallback to LCOW if it's
determined the mount type passed is incorrect, but the LCOW differ
does not return ErrNotImplemented for the same scenario. This puts
a strict ordering requirement on the default differ entries in the config,
namely that ["windows", "windows-lcow"] will work, as windows will correctly
fall back to the lcow differ, but ["windows-lcow", "windows"] won't as
the diff services Apply will just return the error directly.

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
2022-06-28 17:19:04 -07:00
..
apply feat: replace github.com/pkg/errors to errors 2022-01-07 10:27:03 +08:00
lcow LCOW differ return ErrNotImplemented for wrong mount type 2022-06-28 17:19:04 -07:00
walking feat: replace github.com/pkg/errors to errors 2022-01-07 10:27:03 +08:00
windows feat: replace github.com/pkg/errors to errors 2022-01-07 10:27:03 +08:00
diff.go diff: hide types.Any from clients 2022-04-21 13:43:20 +00:00
stream_unix.go Add Wait to binaryProcessor 2022-05-09 17:15:00 -04:00
stream_windows.go Add Wait to binaryProcessor 2022-05-09 17:15:00 -04:00
stream.go diff: hide types.Any from clients 2022-04-21 13:43:20 +00:00