containerd

History

Kazuyoshi Kato 69ae95531c tracing: fix OTLP tracer's initialization - insecure.NewCredential was simply wrong. It has to use otlptracegrpc.WithInsecure to disable TLS. - context.WithTimeout is nice to have, in case the endpoint is not correctly configured. Otherwise, the plugin initialization blocks indefinitely. - grpc.WithReturnConnectionError is nice to have. Otherwise, otlptracegrpc.New returns "context deadline exceeded" without underlying errors. - TraceSamplingRatio should be 1.0 by default. Otherwise, users need to configure both io.containerd.internal.v1.tracing and io.containerd.tracing.processor.v1.otlp. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>	2022-01-13 17:50:18 +00:00
..
otlp.go	tracing: fix OTLP tracer's initialization	2022-01-13 17:50:18 +00:00

Kazuyoshi Kato 69ae95531c tracing: fix OTLP tracer's initialization

- insecure.NewCredential was simply wrong. It has to use
  otlptracegrpc.WithInsecure to disable TLS.
- context.WithTimeout is nice to have, in case the endpoint is not
  correctly configured.
  Otherwise, the plugin initialization blocks indefinitely.
- grpc.WithReturnConnectionError is nice to have.
  Otherwise, otlptracegrpc.New returns "context deadline exceeded"
  without underlying errors.
- TraceSamplingRatio should be 1.0 by default.
  Otherwise, users need to configure both io.containerd.internal.v1.tracing
  and io.containerd.tracing.processor.v1.otlp.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>

2022-01-13 17:50:18 +00:00

otlp.go

tracing: fix OTLP tracer's initialization

2022-01-13 17:50:18 +00:00