99721c27e1
Schema 1 (`application/vnd.docker.distribution.manifest.v1+prettyjws`) has been officially deprecated since containerd v1.7 (PR 6884). We have planned to remove the support for Schema 1 in containerd v2.0, but this removal may still surprise some users. So, in containerd v2.0 we will just disable it by default. The support for Schema 1 can be still enabled by setting an environment variable `CONTAINERD_ENABLE_DEPRECATED_PULL_SCHEMA_1_IMAGE=1`, however, this workaround will be completely removed in containerd v2.1. Schema 2 was introduced in Docker 1.10 (Feb 2016), so most users should have been already using Schema 2 or OCI. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
66 lines
2.1 KiB
Go
66 lines
2.1 KiB
Go
//go:build !windows
|
|
|
|
/*
|
|
Copyright The containerd Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package client
|
|
|
|
import (
|
|
"testing"
|
|
|
|
. "github.com/containerd/containerd/v2/client"
|
|
"github.com/containerd/containerd/v2/integration/images"
|
|
"github.com/containerd/containerd/v2/pkg/deprecation"
|
|
"github.com/containerd/platforms"
|
|
)
|
|
|
|
var (
|
|
testImage = images.Get(images.BusyBox)
|
|
testMultiLayeredImage = images.Get(images.VolumeCopyUp)
|
|
shortCommand = withProcessArgs("true")
|
|
// NOTE: The TestContainerPids needs two running processes in one
|
|
// container. But busybox:1.36 sh shell, the `sleep` is a builtin.
|
|
//
|
|
// /bin/sh -c "type sleep"
|
|
// sleep is a shell builtin
|
|
//
|
|
// We should use `/bin/sleep` instead of `sleep`. And busybox sh shell
|
|
// will execve directly instead of clone-execve if there is only one
|
|
// command. There will be only one process in container if we use
|
|
// '/bin/sh -c "/bin/sleep inf"'.
|
|
//
|
|
// So we append `&& exit 0` to force sh shell uses clone-execve.
|
|
longCommand = withProcessArgs("/bin/sh", "-c", "/bin/sleep inf && exit 0")
|
|
)
|
|
|
|
func TestImagePullSchema1WithEmptyLayers(t *testing.T) {
|
|
t.Setenv(deprecation.EnvPullSchema1Image, "1")
|
|
client, err := newClient(t, address)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer client.Close()
|
|
|
|
ctx, cancel := testContext(t)
|
|
defer cancel()
|
|
|
|
schema1TestImageWithEmptyLayers := "gcr.io/google-containers/busybox@sha256:d8d3bc2c183ed2f9f10e7258f84971202325ee6011ba137112e01e30f206de67"
|
|
_, err = client.Pull(ctx, schema1TestImageWithEmptyLayers, WithPlatform(platforms.DefaultString()), WithSchema1Conversion, WithPullUnpack)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|