b5e1b8f619
A majority of the tests in /pkg/cri are testing/validating multiple things per test (generally spec or options validations). This flow lends itself well to using *testing.T's Run method to run each thing as a subtest so `go test` output can actually display which subtest failed/passed. Some of the tests in the packages in pkg/cri already did this, but a bunch simply logged what sub-testcase was currently running without invoking t.Run. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
100 lines
2.8 KiB
Go
100 lines
2.8 KiB
Go
/*
|
|
Copyright The containerd Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package server
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
containerstore "github.com/containerd/containerd/pkg/cri/store/container"
|
|
)
|
|
|
|
// TestSetContainerStarting tests setContainerStarting sets removing
|
|
// state correctly.
|
|
func TestSetContainerStarting(t *testing.T) {
|
|
testID := "test-id"
|
|
for desc, test := range map[string]struct {
|
|
status containerstore.Status
|
|
expectErr bool
|
|
}{
|
|
|
|
"should not return error when container is in created state": {
|
|
status: containerstore.Status{
|
|
CreatedAt: time.Now().UnixNano(),
|
|
},
|
|
expectErr: false,
|
|
},
|
|
"should return error when container is in running state": {
|
|
status: containerstore.Status{
|
|
CreatedAt: time.Now().UnixNano(),
|
|
StartedAt: time.Now().UnixNano(),
|
|
},
|
|
expectErr: true,
|
|
},
|
|
"should return error when container is in exited state": {
|
|
status: containerstore.Status{
|
|
CreatedAt: time.Now().UnixNano(),
|
|
StartedAt: time.Now().UnixNano(),
|
|
FinishedAt: time.Now().UnixNano(),
|
|
},
|
|
expectErr: true,
|
|
},
|
|
"should return error when container is in unknown state": {
|
|
status: containerstore.Status{
|
|
CreatedAt: 0,
|
|
StartedAt: 0,
|
|
FinishedAt: 0,
|
|
},
|
|
expectErr: true,
|
|
},
|
|
"should return error when container is in starting state": {
|
|
status: containerstore.Status{
|
|
CreatedAt: time.Now().UnixNano(),
|
|
Starting: true,
|
|
},
|
|
expectErr: true,
|
|
},
|
|
"should return error when container is in removing state": {
|
|
status: containerstore.Status{
|
|
CreatedAt: time.Now().UnixNano(),
|
|
Removing: true,
|
|
},
|
|
expectErr: true,
|
|
},
|
|
} {
|
|
t.Run(desc, func(t *testing.T) {
|
|
container, err := containerstore.NewContainer(
|
|
containerstore.Metadata{ID: testID},
|
|
containerstore.WithFakeStatus(test.status),
|
|
)
|
|
assert.NoError(t, err)
|
|
err = setContainerStarting(container)
|
|
if test.expectErr {
|
|
assert.Error(t, err)
|
|
assert.Equal(t, test.status, container.Status.Get(), "metadata should not be updated")
|
|
} else {
|
|
assert.NoError(t, err)
|
|
assert.True(t, container.Status.Get().Starting, "starting should be set")
|
|
assert.NoError(t, resetContainerStarting(container))
|
|
assert.False(t, container.Status.Get().Starting, "starting should be reset")
|
|
}
|
|
})
|
|
}
|
|
}
|