
Since we now have a common set of error definitions, mapped to existing error codes, we no longer need the specialized error codes used for interaction with linux processes. The main issue was that string matching was being used to map these to useful error codes. With this change, we use errors defined in the `errdefs` package, which map cleanly to GRPC error codes and are recoverable on either side of the request. The main focus of this PR was in removin these from the shim. We may need follow ups to ensure error codes are preserved by the `Tasks` service. Signed-off-by: Stephen J Day <stephen.day@docker.com>
265 lines
6.4 KiB
Go
265 lines
6.4 KiB
Go
package containerd
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"path/filepath"
|
|
"strings"
|
|
"sync"
|
|
|
|
"github.com/containerd/containerd/api/services/tasks/v1"
|
|
"github.com/containerd/containerd/api/types"
|
|
"github.com/containerd/containerd/containers"
|
|
"github.com/containerd/containerd/errdefs"
|
|
"github.com/containerd/containerd/typeurl"
|
|
specs "github.com/opencontainers/runtime-spec/specs-go"
|
|
"github.com/pkg/errors"
|
|
)
|
|
|
|
type DeleteOpts func(context.Context, *Client, containers.Container) error
|
|
|
|
type Container interface {
|
|
ID() string
|
|
Info() containers.Container
|
|
Delete(context.Context, ...DeleteOpts) error
|
|
NewTask(context.Context, IOCreation, ...NewTaskOpts) (Task, error)
|
|
Spec() (*specs.Spec, error)
|
|
Task(context.Context, IOAttach) (Task, error)
|
|
Image(context.Context) (Image, error)
|
|
Labels(context.Context) (map[string]string, error)
|
|
SetLabels(context.Context, map[string]string) (map[string]string, error)
|
|
}
|
|
|
|
func containerFromRecord(client *Client, c containers.Container) *container {
|
|
return &container{
|
|
client: client,
|
|
c: c,
|
|
}
|
|
}
|
|
|
|
var _ = (Container)(&container{})
|
|
|
|
type container struct {
|
|
mu sync.Mutex
|
|
|
|
client *Client
|
|
c containers.Container
|
|
}
|
|
|
|
// ID returns the container's unique id
|
|
func (c *container) ID() string {
|
|
return c.c.ID
|
|
}
|
|
|
|
func (c *container) Info() containers.Container {
|
|
return c.c
|
|
}
|
|
|
|
func (c *container) Labels(ctx context.Context) (map[string]string, error) {
|
|
r, err := c.client.ContainerService().Get(ctx, c.ID())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
c.c = r
|
|
|
|
m := make(map[string]string, len(r.Labels))
|
|
for k, v := range c.c.Labels {
|
|
m[k] = v
|
|
}
|
|
|
|
return m, nil
|
|
}
|
|
|
|
func (c *container) SetLabels(ctx context.Context, labels map[string]string) (map[string]string, error) {
|
|
container := containers.Container{
|
|
ID: c.ID(),
|
|
Labels: labels,
|
|
}
|
|
|
|
var paths []string
|
|
// mask off paths so we only muck with the labels encountered in labels.
|
|
// Labels not in the passed in argument will be left alone.
|
|
for k := range labels {
|
|
paths = append(paths, strings.Join([]string{"labels", k}, "."))
|
|
}
|
|
|
|
r, err := c.client.ContainerService().Update(ctx, container, paths...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
c.c = r // update our local container
|
|
|
|
m := make(map[string]string, len(r.Labels))
|
|
for k, v := range c.c.Labels {
|
|
m[k] = v
|
|
}
|
|
return m, nil
|
|
}
|
|
|
|
// Spec returns the current OCI specification for the container
|
|
func (c *container) Spec() (*specs.Spec, error) {
|
|
var s specs.Spec
|
|
if err := json.Unmarshal(c.c.Spec.Value, &s); err != nil {
|
|
return nil, err
|
|
}
|
|
return &s, nil
|
|
}
|
|
|
|
// WithRootFSDeletion deletes the rootfs allocated for the container
|
|
func WithRootFSDeletion(ctx context.Context, client *Client, c containers.Container) error {
|
|
if c.RootFS != "" {
|
|
return client.SnapshotService(c.Snapshotter).Remove(ctx, c.RootFS)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Delete deletes an existing container
|
|
// an error is returned if the container has running tasks
|
|
func (c *container) Delete(ctx context.Context, opts ...DeleteOpts) (err error) {
|
|
if _, err := c.Task(ctx, nil); err == nil {
|
|
return errors.Wrapf(errdefs.ErrFailedPrecondition, "cannot delete running task %v", c.ID())
|
|
}
|
|
for _, o := range opts {
|
|
if err := o(ctx, c.client, c.c); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
if cerr := c.client.ContainerService().Delete(ctx, c.ID()); err == nil {
|
|
err = cerr
|
|
}
|
|
return err
|
|
}
|
|
|
|
func (c *container) Task(ctx context.Context, attach IOAttach) (Task, error) {
|
|
return c.loadTask(ctx, attach)
|
|
}
|
|
|
|
// Image returns the image that the container is based on
|
|
func (c *container) Image(ctx context.Context) (Image, error) {
|
|
if c.c.Image == "" {
|
|
return nil, errors.Wrapf(errdefs.ErrNotFound, "container not created from an image")
|
|
}
|
|
i, err := c.client.ImageService().Get(ctx, c.c.Image)
|
|
if err != nil {
|
|
return nil, errors.Wrapf(err, "failed to get image for container")
|
|
}
|
|
return &image{
|
|
client: c.client,
|
|
i: i,
|
|
}, nil
|
|
}
|
|
|
|
type NewTaskOpts func(context.Context, *Client, *TaskInfo) error
|
|
|
|
func (c *container) NewTask(ctx context.Context, ioCreate IOCreation, opts ...NewTaskOpts) (Task, error) {
|
|
c.mu.Lock()
|
|
defer c.mu.Unlock()
|
|
i, err := ioCreate()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
request := &tasks.CreateTaskRequest{
|
|
ContainerID: c.c.ID,
|
|
Terminal: i.Terminal,
|
|
Stdin: i.Stdin,
|
|
Stdout: i.Stdout,
|
|
Stderr: i.Stderr,
|
|
}
|
|
if c.c.RootFS != "" {
|
|
// get the rootfs from the snapshotter and add it to the request
|
|
mounts, err := c.client.SnapshotService(c.c.Snapshotter).Mounts(ctx, c.c.RootFS)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
for _, m := range mounts {
|
|
request.Rootfs = append(request.Rootfs, &types.Mount{
|
|
Type: m.Type,
|
|
Source: m.Source,
|
|
Options: m.Options,
|
|
})
|
|
}
|
|
}
|
|
var info TaskInfo
|
|
for _, o := range opts {
|
|
if err := o(ctx, c.client, &info); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
if info.Options != nil {
|
|
any, err := typeurl.MarshalAny(info.Options)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
request.Options = any
|
|
}
|
|
t := &task{
|
|
client: c.client,
|
|
io: i,
|
|
id: c.ID(),
|
|
}
|
|
if info.Checkpoint != nil {
|
|
request.Checkpoint = info.Checkpoint
|
|
// we need to defer the create call to start
|
|
t.deferred = request
|
|
} else {
|
|
response, err := c.client.TaskService().Create(ctx, request)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
t.pid = response.Pid
|
|
}
|
|
return t, nil
|
|
}
|
|
|
|
func (c *container) loadTask(ctx context.Context, ioAttach IOAttach) (Task, error) {
|
|
response, err := c.client.TaskService().Get(ctx, &tasks.GetTaskRequest{
|
|
ContainerID: c.c.ID,
|
|
})
|
|
if err != nil {
|
|
err = errdefs.FromGRPC(err)
|
|
if errdefs.IsNotFound(err) {
|
|
return nil, errors.Wrapf(err, "no running task found")
|
|
}
|
|
return nil, err
|
|
}
|
|
var i *IO
|
|
if ioAttach != nil {
|
|
// get the existing fifo paths from the task information stored by the daemon
|
|
paths := &FIFOSet{
|
|
Dir: getFifoDir([]string{
|
|
response.Task.Stdin,
|
|
response.Task.Stdout,
|
|
response.Task.Stderr,
|
|
}),
|
|
In: response.Task.Stdin,
|
|
Out: response.Task.Stdout,
|
|
Err: response.Task.Stderr,
|
|
Terminal: response.Task.Terminal,
|
|
}
|
|
if i, err = ioAttach(paths); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
t := &task{
|
|
client: c.client,
|
|
io: i,
|
|
id: response.Task.ID,
|
|
pid: response.Task.Pid,
|
|
}
|
|
return t, nil
|
|
}
|
|
|
|
// getFifoDir looks for any non-empty path for a stdio fifo
|
|
// and returns the dir for where it is located
|
|
func getFifoDir(paths []string) string {
|
|
for _, p := range paths {
|
|
if p != "" {
|
|
return filepath.Dir(p)
|
|
}
|
|
}
|
|
return ""
|
|
}
|