d94a789d15
It says: The prefix path **must be absolute, have all symlinks resolved, and cleaned**. But those requirements are violated in lots of places. What happens when it is given a non-canonicalized path is that `mountinfo.GetMounts` will not find mounts. The trivial case is: ``` $ mkdir a && ln -s a b && mkdir b/c b/d && mount --bind b/c b/d && cat /proc/mounts | grep -- '[ab]/d' /dev/sdd3 /home/user/a/d ext4 rw,noatime,discard 0 0 ``` We asked to bind-mount b/c to b/d, but ended up with mount in a/d. So, mount table always contains canonicalized mount points, and it is an error to look for non-canonicalized paths in it. Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
61 lines
1.6 KiB
Go
61 lines
1.6 KiB
Go
//go:build !windows && !darwin
|
|
|
|
/*
|
|
Copyright The containerd Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package mount
|
|
|
|
import (
|
|
"os"
|
|
"sort"
|
|
|
|
"github.com/moby/sys/mountinfo"
|
|
)
|
|
|
|
// SetTempMountLocation sets the temporary mount location
|
|
func SetTempMountLocation(root string) error {
|
|
err := os.MkdirAll(root, 0700)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
// We need to pass canonicalized path to mountinfo.PrefixFilter in CleanupTempMounts
|
|
tempMountLocation, err = CanonicalizePath(root)
|
|
return err
|
|
}
|
|
|
|
// CleanupTempMounts all temp mounts and remove the directories
|
|
func CleanupTempMounts(flags int) (warnings []error, err error) {
|
|
mounts, err := mountinfo.GetMounts(mountinfo.PrefixFilter(tempMountLocation))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Make the deepest mount be first
|
|
sort.Slice(mounts, func(i, j int) bool {
|
|
return len(mounts[i].Mountpoint) > len(mounts[j].Mountpoint)
|
|
})
|
|
for _, mount := range mounts {
|
|
if err := UnmountAll(mount.Mountpoint, flags); err != nil {
|
|
warnings = append(warnings, err)
|
|
continue
|
|
}
|
|
if err := os.Remove(mount.Mountpoint); err != nil {
|
|
warnings = append(warnings, err)
|
|
}
|
|
}
|
|
return warnings, nil
|
|
}
|