
Close connection if no more data. It's to fix false alert filed by image pull progress. ``` dst = OpenWriter (--> Content Store) src = Fetch Open (--> Registry) Mark it as active request Copy(dst, src) (--> Keep updating total received bytes) ^ | (Active Request > 0, but total received bytes won't be updated) v defer src.Close() content.Commit(dst) ``` Before migrating to transfer service, CRI plugin doesn't limit global concurrent downloads for ImagePulls. Each ImagePull requests have 3 concurrent goroutines to download blob and 1 goroutine to unpack blob. Like ext4 filesystem [1][1], the fsync from content.Commit may sync unrelated dirty pages into disk. The host is running under IO pressure, and then the content.Commit will take long time and block other goroutines. If httpreadseeker doesn't close the connection after io.EOF, this connection will be considered as active. The pull progress reporter reports there is no bytes transfered and cancels the ImagePull. The original 1-minute timeout[2][2] is from kubelet settting. Since CRI-plugin can't limit the total concurrent downloads, this patch is to update 1-minute to 5-minutes to prevent from unexpected cancel. [1]: https://lwn.net/Articles/842385/ [2]: https://github.com/kubernetes/kubernetes/blob/release-1.23/pkg/kubelet/config/flags.go#L45-L48 Signed-off-by: Wei Fu <fuweid89@gmail.com>
179 lines
4.3 KiB
Go
179 lines
4.3 KiB
Go
/*
|
|
Copyright The containerd Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package docker
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"io"
|
|
|
|
"github.com/containerd/containerd/v2/errdefs"
|
|
"github.com/containerd/log"
|
|
)
|
|
|
|
const maxRetry = 3
|
|
|
|
type httpReadSeeker struct {
|
|
size int64
|
|
offset int64
|
|
rc io.ReadCloser
|
|
open func(offset int64) (io.ReadCloser, error)
|
|
closed bool
|
|
|
|
errsWithNoProgress int
|
|
}
|
|
|
|
func newHTTPReadSeeker(size int64, open func(offset int64) (io.ReadCloser, error)) (io.ReadCloser, error) {
|
|
return &httpReadSeeker{
|
|
size: size,
|
|
open: open,
|
|
}, nil
|
|
}
|
|
|
|
func (hrs *httpReadSeeker) Read(p []byte) (n int, err error) {
|
|
if hrs.closed {
|
|
return 0, io.EOF
|
|
}
|
|
|
|
rd, err := hrs.reader()
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
|
|
n, err = rd.Read(p)
|
|
hrs.offset += int64(n)
|
|
if n > 0 || err == nil {
|
|
hrs.errsWithNoProgress = 0
|
|
}
|
|
if err == io.ErrUnexpectedEOF {
|
|
// connection closed unexpectedly. try reconnecting.
|
|
if n == 0 {
|
|
hrs.errsWithNoProgress++
|
|
if hrs.errsWithNoProgress > maxRetry {
|
|
return // too many retries for this offset with no progress
|
|
}
|
|
}
|
|
if hrs.rc != nil {
|
|
if clsErr := hrs.rc.Close(); clsErr != nil {
|
|
log.L.WithError(clsErr).Error("httpReadSeeker: failed to close ReadCloser")
|
|
}
|
|
hrs.rc = nil
|
|
}
|
|
if _, err2 := hrs.reader(); err2 == nil {
|
|
return n, nil
|
|
}
|
|
} else if err == io.EOF {
|
|
// The CRI's imagePullProgressTimeout relies on responseBody.Close to
|
|
// update the process monitor's status. If the err is io.EOF, close
|
|
// the connection since there is no more available data.
|
|
if hrs.rc != nil {
|
|
if clsErr := hrs.rc.Close(); clsErr != nil {
|
|
log.L.WithError(clsErr).Error("httpReadSeeker: failed to close ReadCloser after io.EOF")
|
|
}
|
|
hrs.rc = nil
|
|
}
|
|
}
|
|
return
|
|
}
|
|
|
|
func (hrs *httpReadSeeker) Close() error {
|
|
if hrs.closed {
|
|
return nil
|
|
}
|
|
hrs.closed = true
|
|
if hrs.rc != nil {
|
|
return hrs.rc.Close()
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (hrs *httpReadSeeker) Seek(offset int64, whence int) (int64, error) {
|
|
if hrs.closed {
|
|
return 0, fmt.Errorf("Fetcher.Seek: closed: %w", errdefs.ErrUnavailable)
|
|
}
|
|
|
|
abs := hrs.offset
|
|
switch whence {
|
|
case io.SeekStart:
|
|
abs = offset
|
|
case io.SeekCurrent:
|
|
abs += offset
|
|
case io.SeekEnd:
|
|
if hrs.size == -1 {
|
|
return 0, fmt.Errorf("Fetcher.Seek: unknown size, cannot seek from end: %w", errdefs.ErrUnavailable)
|
|
}
|
|
abs = hrs.size + offset
|
|
default:
|
|
return 0, fmt.Errorf("Fetcher.Seek: invalid whence: %w", errdefs.ErrInvalidArgument)
|
|
}
|
|
|
|
if abs < 0 {
|
|
return 0, fmt.Errorf("Fetcher.Seek: negative offset: %w", errdefs.ErrInvalidArgument)
|
|
}
|
|
|
|
if abs != hrs.offset {
|
|
if hrs.rc != nil {
|
|
if err := hrs.rc.Close(); err != nil {
|
|
log.L.WithError(err).Error("Fetcher.Seek: failed to close ReadCloser")
|
|
}
|
|
|
|
hrs.rc = nil
|
|
}
|
|
|
|
hrs.offset = abs
|
|
}
|
|
|
|
return hrs.offset, nil
|
|
}
|
|
|
|
func (hrs *httpReadSeeker) reader() (io.Reader, error) {
|
|
if hrs.rc != nil {
|
|
return hrs.rc, nil
|
|
}
|
|
|
|
if hrs.size == -1 || hrs.offset < hrs.size {
|
|
// only try to reopen the body request if we are seeking to a value
|
|
// less than the actual size.
|
|
if hrs.open == nil {
|
|
return nil, fmt.Errorf("cannot open: %w", errdefs.ErrNotImplemented)
|
|
}
|
|
|
|
rc, err := hrs.open(hrs.offset)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("httpReadSeeker: failed open: %w", err)
|
|
}
|
|
|
|
if hrs.rc != nil {
|
|
if err := hrs.rc.Close(); err != nil {
|
|
log.L.WithError(err).Error("httpReadSeeker: failed to close ReadCloser")
|
|
}
|
|
}
|
|
hrs.rc = rc
|
|
} else {
|
|
// There is an edge case here where offset == size of the content. If
|
|
// we seek, we will probably get an error for content that cannot be
|
|
// sought (?). In that case, we should err on committing the content,
|
|
// as the length is already satisfied but we just return the empty
|
|
// reader instead.
|
|
|
|
hrs.rc = io.NopCloser(bytes.NewReader([]byte{}))
|
|
}
|
|
|
|
return hrs.rc, nil
|
|
}
|