Using the utility caused other project to have containerd/cri as a dependency, only for this utility. The new `reference.ParseDockerRef` function does the same (it's a copy of this function). Tests were kept for now, but could be removed in future. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
		
			
				
	
	
		
			324 lines
		
	
	
		
			9.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			324 lines
		
	
	
		
			9.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
/*
 | 
						|
Copyright 2017 The Kubernetes Authors.
 | 
						|
 | 
						|
Licensed under the Apache License, Version 2.0 (the "License");
 | 
						|
you may not use this file except in compliance with the License.
 | 
						|
You may obtain a copy of the License at
 | 
						|
 | 
						|
    http://www.apache.org/licenses/LICENSE-2.0
 | 
						|
 | 
						|
Unless required by applicable law or agreed to in writing, software
 | 
						|
distributed under the License is distributed on an "AS IS" BASIS,
 | 
						|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | 
						|
See the License for the specific language governing permissions and
 | 
						|
limitations under the License.
 | 
						|
*/
 | 
						|
 | 
						|
package server
 | 
						|
 | 
						|
import (
 | 
						|
	"sort"
 | 
						|
	"testing"
 | 
						|
 | 
						|
	"github.com/BurntSushi/toml"
 | 
						|
	"github.com/containerd/containerd/runtime/linux/runctypes"
 | 
						|
	runcoptions "github.com/containerd/containerd/runtime/v2/runc/options"
 | 
						|
	"github.com/docker/distribution/reference"
 | 
						|
	imagedigest "github.com/opencontainers/go-digest"
 | 
						|
	"github.com/stretchr/testify/assert"
 | 
						|
	"github.com/stretchr/testify/require"
 | 
						|
	runtime "k8s.io/kubernetes/pkg/kubelet/apis/cri/runtime/v1alpha2"
 | 
						|
 | 
						|
	criconfig "github.com/containerd/cri/pkg/config"
 | 
						|
	"github.com/containerd/cri/pkg/store"
 | 
						|
	imagestore "github.com/containerd/cri/pkg/store/image"
 | 
						|
)
 | 
						|
 | 
						|
// TestGetUserFromImage tests the logic of getting image uid or user name of image user.
 | 
						|
func TestGetUserFromImage(t *testing.T) {
 | 
						|
	newI64 := func(i int64) *int64 { return &i }
 | 
						|
	for c, test := range map[string]struct {
 | 
						|
		user string
 | 
						|
		uid  *int64
 | 
						|
		name string
 | 
						|
	}{
 | 
						|
		"no gid": {
 | 
						|
			user: "0",
 | 
						|
			uid:  newI64(0),
 | 
						|
		},
 | 
						|
		"uid/gid": {
 | 
						|
			user: "0:1",
 | 
						|
			uid:  newI64(0),
 | 
						|
		},
 | 
						|
		"empty user": {
 | 
						|
			user: "",
 | 
						|
		},
 | 
						|
		"multiple spearators": {
 | 
						|
			user: "1:2:3",
 | 
						|
			uid:  newI64(1),
 | 
						|
		},
 | 
						|
		"root username": {
 | 
						|
			user: "root:root",
 | 
						|
			name: "root",
 | 
						|
		},
 | 
						|
		"username": {
 | 
						|
			user: "test:test",
 | 
						|
			name: "test",
 | 
						|
		},
 | 
						|
	} {
 | 
						|
		t.Logf("TestCase - %q", c)
 | 
						|
		actualUID, actualName := getUserFromImage(test.user)
 | 
						|
		assert.Equal(t, test.uid, actualUID)
 | 
						|
		assert.Equal(t, test.name, actualName)
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestGetRepoDigestAndTag(t *testing.T) {
 | 
						|
	digest := imagedigest.Digest("sha256:e6693c20186f837fc393390135d8a598a96a833917917789d63766cab6c59582")
 | 
						|
	for desc, test := range map[string]struct {
 | 
						|
		ref                string
 | 
						|
		schema1            bool
 | 
						|
		expectedRepoDigest string
 | 
						|
		expectedRepoTag    string
 | 
						|
	}{
 | 
						|
		"repo tag should be empty if original ref has no tag": {
 | 
						|
			ref:                "gcr.io/library/busybox@" + digest.String(),
 | 
						|
			expectedRepoDigest: "gcr.io/library/busybox@" + digest.String(),
 | 
						|
		},
 | 
						|
		"repo tag should not be empty if original ref has tag": {
 | 
						|
			ref:                "gcr.io/library/busybox:latest",
 | 
						|
			expectedRepoDigest: "gcr.io/library/busybox@" + digest.String(),
 | 
						|
			expectedRepoTag:    "gcr.io/library/busybox:latest",
 | 
						|
		},
 | 
						|
		"repo digest should be empty if original ref is schema1 and has no digest": {
 | 
						|
			ref:                "gcr.io/library/busybox:latest",
 | 
						|
			schema1:            true,
 | 
						|
			expectedRepoDigest: "",
 | 
						|
			expectedRepoTag:    "gcr.io/library/busybox:latest",
 | 
						|
		},
 | 
						|
		"repo digest should not be empty if orignal ref is schema1 but has digest": {
 | 
						|
			ref:                "gcr.io/library/busybox@sha256:e6693c20186f837fc393390135d8a598a96a833917917789d63766cab6c59594",
 | 
						|
			schema1:            true,
 | 
						|
			expectedRepoDigest: "gcr.io/library/busybox@sha256:e6693c20186f837fc393390135d8a598a96a833917917789d63766cab6c59594",
 | 
						|
			expectedRepoTag:    "",
 | 
						|
		},
 | 
						|
	} {
 | 
						|
		t.Logf("TestCase %q", desc)
 | 
						|
		named, err := reference.ParseDockerRef(test.ref)
 | 
						|
		assert.NoError(t, err)
 | 
						|
		repoDigest, repoTag := getRepoDigestAndTag(named, digest, test.schema1)
 | 
						|
		assert.Equal(t, test.expectedRepoDigest, repoDigest)
 | 
						|
		assert.Equal(t, test.expectedRepoTag, repoTag)
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestGetCgroupsPath(t *testing.T) {
 | 
						|
	testID := "test-id"
 | 
						|
	for desc, test := range map[string]struct {
 | 
						|
		cgroupsParent string
 | 
						|
		systemdCgroup bool
 | 
						|
		expected      string
 | 
						|
	}{
 | 
						|
		"should support regular cgroup path": {
 | 
						|
			cgroupsParent: "/a/b",
 | 
						|
			systemdCgroup: false,
 | 
						|
			expected:      "/a/b/test-id",
 | 
						|
		},
 | 
						|
		"should support systemd cgroup path": {
 | 
						|
			cgroupsParent: "/a.slice/b.slice",
 | 
						|
			systemdCgroup: true,
 | 
						|
			expected:      "b.slice:cri-containerd:test-id",
 | 
						|
		},
 | 
						|
	} {
 | 
						|
		t.Logf("TestCase %q", desc)
 | 
						|
		got := getCgroupsPath(test.cgroupsParent, testID, test.systemdCgroup)
 | 
						|
		assert.Equal(t, test.expected, got)
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestBuildLabels(t *testing.T) {
 | 
						|
	configLabels := map[string]string{
 | 
						|
		"a": "b",
 | 
						|
		"c": "d",
 | 
						|
	}
 | 
						|
	newLabels := buildLabels(configLabels, containerKindSandbox)
 | 
						|
	assert.Len(t, newLabels, 3)
 | 
						|
	assert.Equal(t, "b", newLabels["a"])
 | 
						|
	assert.Equal(t, "d", newLabels["c"])
 | 
						|
	assert.Equal(t, containerKindSandbox, newLabels[containerKindLabel])
 | 
						|
 | 
						|
	newLabels["a"] = "e"
 | 
						|
	assert.Empty(t, configLabels[containerKindLabel], "should not add new labels into original label")
 | 
						|
	assert.Equal(t, "b", configLabels["a"], "change in new labels should not affect original label")
 | 
						|
}
 | 
						|
 | 
						|
func TestOrderedMounts(t *testing.T) {
 | 
						|
	mounts := []*runtime.Mount{
 | 
						|
		{ContainerPath: "/a/b/c"},
 | 
						|
		{ContainerPath: "/a/b"},
 | 
						|
		{ContainerPath: "/a/b/c/d"},
 | 
						|
		{ContainerPath: "/a"},
 | 
						|
		{ContainerPath: "/b"},
 | 
						|
		{ContainerPath: "/b/c"},
 | 
						|
	}
 | 
						|
	expected := []*runtime.Mount{
 | 
						|
		{ContainerPath: "/a"},
 | 
						|
		{ContainerPath: "/b"},
 | 
						|
		{ContainerPath: "/a/b"},
 | 
						|
		{ContainerPath: "/b/c"},
 | 
						|
		{ContainerPath: "/a/b/c"},
 | 
						|
		{ContainerPath: "/a/b/c/d"},
 | 
						|
	}
 | 
						|
	sort.Stable(orderedMounts(mounts))
 | 
						|
	assert.Equal(t, expected, mounts)
 | 
						|
}
 | 
						|
 | 
						|
func TestParseImageReferences(t *testing.T) {
 | 
						|
	refs := []string{
 | 
						|
		"gcr.io/library/busybox@sha256:e6693c20186f837fc393390135d8a598a96a833917917789d63766cab6c59582",
 | 
						|
		"gcr.io/library/busybox:1.2",
 | 
						|
		"sha256:e6693c20186f837fc393390135d8a598a96a833917917789d63766cab6c59582",
 | 
						|
		"arbitrary-ref",
 | 
						|
	}
 | 
						|
	expectedTags := []string{
 | 
						|
		"gcr.io/library/busybox:1.2",
 | 
						|
	}
 | 
						|
	expectedDigests := []string{"gcr.io/library/busybox@sha256:e6693c20186f837fc393390135d8a598a96a833917917789d63766cab6c59582"}
 | 
						|
	tags, digests := parseImageReferences(refs)
 | 
						|
	assert.Equal(t, expectedTags, tags)
 | 
						|
	assert.Equal(t, expectedDigests, digests)
 | 
						|
}
 | 
						|
 | 
						|
func TestLocalResolve(t *testing.T) {
 | 
						|
	image := imagestore.Image{
 | 
						|
		ID:      "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113799",
 | 
						|
		ChainID: "test-chain-id-1",
 | 
						|
		References: []string{
 | 
						|
			"docker.io/library/busybox:latest",
 | 
						|
			"docker.io/library/busybox@sha256:e6693c20186f837fc393390135d8a598a96a833917917789d63766cab6c59582",
 | 
						|
		},
 | 
						|
		Size: 10,
 | 
						|
	}
 | 
						|
	c := newTestCRIService()
 | 
						|
	var err error
 | 
						|
	c.imageStore, err = imagestore.NewFakeStore([]imagestore.Image{image})
 | 
						|
	assert.NoError(t, err)
 | 
						|
 | 
						|
	for _, ref := range []string{
 | 
						|
		"sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113799",
 | 
						|
		"busybox",
 | 
						|
		"busybox:latest",
 | 
						|
		"busybox@sha256:e6693c20186f837fc393390135d8a598a96a833917917789d63766cab6c59582",
 | 
						|
		"library/busybox",
 | 
						|
		"library/busybox:latest",
 | 
						|
		"library/busybox@sha256:e6693c20186f837fc393390135d8a598a96a833917917789d63766cab6c59582",
 | 
						|
		"docker.io/busybox",
 | 
						|
		"docker.io/busybox:latest",
 | 
						|
		"docker.io/busybox@sha256:e6693c20186f837fc393390135d8a598a96a833917917789d63766cab6c59582",
 | 
						|
		"docker.io/library/busybox",
 | 
						|
		"docker.io/library/busybox:latest",
 | 
						|
		"docker.io/library/busybox@sha256:e6693c20186f837fc393390135d8a598a96a833917917789d63766cab6c59582",
 | 
						|
	} {
 | 
						|
		img, err := c.localResolve(ref)
 | 
						|
		assert.NoError(t, err)
 | 
						|
		assert.Equal(t, image, img)
 | 
						|
	}
 | 
						|
	img, err := c.localResolve("randomid")
 | 
						|
	assert.Equal(t, store.ErrNotExist, err)
 | 
						|
	assert.Equal(t, imagestore.Image{}, img)
 | 
						|
}
 | 
						|
 | 
						|
func TestGenerateRuntimeOptions(t *testing.T) {
 | 
						|
	nilOpts := `
 | 
						|
systemd_cgroup = true
 | 
						|
[containerd]
 | 
						|
  no_pivot = true
 | 
						|
[containerd.default_runtime]
 | 
						|
  runtime_type = "` + linuxRuntime + `"
 | 
						|
[containerd.runtimes.runc]
 | 
						|
  runtime_type = "` + runcRuntime + `"
 | 
						|
`
 | 
						|
	nonNilOpts := `
 | 
						|
systemd_cgroup = true
 | 
						|
[containerd]
 | 
						|
  no_pivot = true
 | 
						|
[containerd.default_runtime]
 | 
						|
  runtime_type = "` + linuxRuntime + `"
 | 
						|
[containerd.default_runtime.options]
 | 
						|
  Runtime = "default"
 | 
						|
  RuntimeRoot = "/default"
 | 
						|
[containerd.runtimes.runc]
 | 
						|
  runtime_type = "` + runcRuntime + `"
 | 
						|
[containerd.runtimes.runc.options]
 | 
						|
  BinaryName = "runc"
 | 
						|
  Root = "/runc"
 | 
						|
  NoNewKeyring = true
 | 
						|
`
 | 
						|
	var nilOptsConfig, nonNilOptsConfig criconfig.Config
 | 
						|
	_, err := toml.Decode(nilOpts, &nilOptsConfig)
 | 
						|
	require.NoError(t, err)
 | 
						|
	_, err = toml.Decode(nonNilOpts, &nonNilOptsConfig)
 | 
						|
	require.NoError(t, err)
 | 
						|
	require.Len(t, nilOptsConfig.Runtimes, 1)
 | 
						|
	require.Len(t, nonNilOptsConfig.Runtimes, 1)
 | 
						|
 | 
						|
	for desc, test := range map[string]struct {
 | 
						|
		r               criconfig.Runtime
 | 
						|
		c               criconfig.Config
 | 
						|
		expectedOptions interface{}
 | 
						|
	}{
 | 
						|
		"when options is nil, should return nil option for non legacy runtime": {
 | 
						|
			r:               nilOptsConfig.Runtimes["runc"],
 | 
						|
			c:               nilOptsConfig,
 | 
						|
			expectedOptions: nil,
 | 
						|
		},
 | 
						|
		"when options is nil, should use legacy fields for legacy runtime": {
 | 
						|
			r: nilOptsConfig.DefaultRuntime,
 | 
						|
			c: nilOptsConfig,
 | 
						|
			expectedOptions: &runctypes.RuncOptions{
 | 
						|
				SystemdCgroup: true,
 | 
						|
			},
 | 
						|
		},
 | 
						|
		"when options is not nil, should be able to decode for io.containerd.runc.v1": {
 | 
						|
			r: nonNilOptsConfig.Runtimes["runc"],
 | 
						|
			c: nonNilOptsConfig,
 | 
						|
			expectedOptions: &runcoptions.Options{
 | 
						|
				BinaryName:   "runc",
 | 
						|
				Root:         "/runc",
 | 
						|
				NoNewKeyring: true,
 | 
						|
			},
 | 
						|
		},
 | 
						|
		"when options is not nil, should be able to decode for legacy runtime": {
 | 
						|
			r: nonNilOptsConfig.DefaultRuntime,
 | 
						|
			c: nonNilOptsConfig,
 | 
						|
			expectedOptions: &runctypes.RuncOptions{
 | 
						|
				Runtime:     "default",
 | 
						|
				RuntimeRoot: "/default",
 | 
						|
			},
 | 
						|
		},
 | 
						|
	} {
 | 
						|
		t.Run(desc, func(t *testing.T) {
 | 
						|
			opts, err := generateRuntimeOptions(test.r, test.c)
 | 
						|
			assert.NoError(t, err)
 | 
						|
			assert.Equal(t, test.expectedOptions, opts)
 | 
						|
		})
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestRestrictOOMScoreAdj(t *testing.T) {
 | 
						|
	current, err := getCurrentOOMScoreAdj()
 | 
						|
	require.NoError(t, err)
 | 
						|
 | 
						|
	got, err := restrictOOMScoreAdj(current - 1)
 | 
						|
	require.NoError(t, err)
 | 
						|
	assert.Equal(t, got, current)
 | 
						|
 | 
						|
	got, err = restrictOOMScoreAdj(current)
 | 
						|
	require.NoError(t, err)
 | 
						|
	assert.Equal(t, got, current)
 | 
						|
 | 
						|
	got, err = restrictOOMScoreAdj(current + 1)
 | 
						|
	require.NoError(t, err)
 | 
						|
	assert.Equal(t, got, current+1)
 | 
						|
}
 |