9924e56f42
These tests were failing on my macOS; could be the precision issue (like on
Windows), or just because they're "too fast".
=== RUN TestSourceDateEpoch/WithoutSourceDateEpoch
epoch_test.go:51:
Error Trace: /Users/thajeztah/go/src/github.com/containerd/containerd/pkg/epoch/epoch_test.go:51
Error: Should be true
Test: TestSourceDateEpoch/WithoutSourceDateEpoch
Messages: now: 2023-06-23 11:47:09.93118 +0000 UTC, v: 2023-06-23 11:47:09.93118 +0000 UTC
This patch:
- updates the rightAfter utility to allow the timestamps to be "equal"
- updates the asserts to provide some details about the timestamps
- uses UTC for the value we're comparing to, to match the timestamps
that are generated.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
97 lines
2.5 KiB
Go
97 lines
2.5 KiB
Go
/*
|
|
Copyright The containerd Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package epoch
|
|
|
|
import (
|
|
"os"
|
|
"runtime"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func rightAfter(t1, t2 time.Time) bool {
|
|
if t2.Equal(t1) {
|
|
return true
|
|
}
|
|
threshold := 10 * time.Millisecond
|
|
if runtime.GOOS == "windows" {
|
|
// Low timer resolution on Windows
|
|
threshold *= 10
|
|
}
|
|
return t2.After(t1) && t2.Before(t1.Add(threshold))
|
|
}
|
|
|
|
func TestSourceDateEpoch(t *testing.T) {
|
|
if s, ok := os.LookupEnv(SourceDateEpochEnv); ok {
|
|
t.Logf("%s is already set to %q, unsetting", SourceDateEpochEnv, s)
|
|
// see https://github.com/golang/go/issues/52817#issuecomment-1131339120
|
|
t.Setenv(SourceDateEpochEnv, "")
|
|
os.Unsetenv(SourceDateEpochEnv)
|
|
}
|
|
|
|
t.Run("WithoutSourceDateEpoch", func(t *testing.T) {
|
|
vp, err := SourceDateEpoch()
|
|
require.NoError(t, err)
|
|
require.Nil(t, vp)
|
|
|
|
now := time.Now().UTC()
|
|
v := SourceDateEpochOrNow()
|
|
require.True(t, rightAfter(now, v), "now: %s, v: %s", now, v)
|
|
})
|
|
|
|
t.Run("WithEmptySourceDateEpoch", func(t *testing.T) {
|
|
t.Setenv(SourceDateEpochEnv, "")
|
|
|
|
vp, err := SourceDateEpoch()
|
|
require.NoError(t, err)
|
|
require.Nil(t, vp)
|
|
|
|
now := time.Now().UTC()
|
|
v := SourceDateEpochOrNow()
|
|
require.True(t, rightAfter(now, v), "now: %s, v: %s", now, v)
|
|
})
|
|
|
|
t.Run("WithSourceDateEpoch", func(t *testing.T) {
|
|
sourceDateEpoch, err := time.Parse(time.RFC3339, "2022-01-23T12:34:56Z")
|
|
require.NoError(t, err)
|
|
|
|
SetSourceDateEpoch(sourceDateEpoch)
|
|
t.Cleanup(UnsetSourceDateEpoch)
|
|
|
|
vp, err := SourceDateEpoch()
|
|
require.NoError(t, err)
|
|
require.True(t, vp.Equal(sourceDateEpoch))
|
|
|
|
v := SourceDateEpochOrNow()
|
|
require.True(t, v.Equal(sourceDateEpoch))
|
|
})
|
|
|
|
t.Run("WithInvalidSourceDateEpoch", func(t *testing.T) {
|
|
t.Setenv(SourceDateEpochEnv, "foo")
|
|
|
|
vp, err := SourceDateEpoch()
|
|
require.ErrorContains(t, err, "invalid SOURCE_DATE_EPOCH value")
|
|
require.Nil(t, vp)
|
|
|
|
now := time.Now().UTC()
|
|
v := SourceDateEpochOrNow()
|
|
require.True(t, rightAfter(now, v), "now: %s, v: %s", now, v)
|
|
})
|
|
}
|