af1e2af720
This allows us to dig more details out of test runs and maintain a better history. For this we can use `gotestsum`, which is a utility that wraps `go test` so that it outputs test2json (go's format) and output junit (a format more easily imported into other systems). The PR makes it possible to override the Makefile's use of `go test` to use any other command tto executet the test. For CI we'll use `gotestsum --`, where `gotestsum` expects everything after the `--` to be flags for `go test`. We then use environment variables to configure `gotestsum` (e.g. `GOTESTSUM_JUNITFILE` is an env var accepted by `gotestsum`). For cri tests, the test suite supports outputing test results to a directory, these are in junit format already. The file is not named properly just because the code that creates it (in ginkgo) is not configured well. We can fix that upstream to give us a better name... until then I'm keeping those results in a separate dir. A second workflow is also added so the test results can be summed up and a report added to the workflow run. The 2nd workflow is required for this since PR runs do not have access to do some of this due to safety reasons (https://securitylab.github.com/research/github-actions-preventing-pwn-requests/) Signed-off-by: Brian Goff <cpuguy83@gmail.com>
573 lines
17 KiB
YAML
573 lines
17 KiB
YAML
name: CI
|
|
on:
|
|
push:
|
|
branches:
|
|
- master
|
|
- 'release/**'
|
|
pull_request:
|
|
branches:
|
|
- master
|
|
- 'release/**'
|
|
|
|
jobs:
|
|
#
|
|
# golangci-lint
|
|
#
|
|
linters:
|
|
name: Linters
|
|
runs-on: ${{ matrix.os }}
|
|
timeout-minutes: 10
|
|
|
|
strategy:
|
|
matrix:
|
|
go-version: [1.16.2]
|
|
os: [ubuntu-18.04, macos-10.15, windows-2019]
|
|
|
|
steps:
|
|
- uses: actions/checkout@v2
|
|
with:
|
|
path: src/github.com/containerd/containerd
|
|
|
|
- name: Set env
|
|
shell: bash
|
|
run: |
|
|
echo "GOPATH=${{ github.workspace }}" >> $GITHUB_ENV
|
|
echo "${{ github.workspace }}/bin" >> $GITHUB_PATH
|
|
|
|
- uses: golangci/golangci-lint-action@v2
|
|
with:
|
|
version: v1.36.0
|
|
working-directory: src/github.com/containerd/containerd
|
|
args: --timeout=5m
|
|
|
|
#
|
|
# Project checks
|
|
#
|
|
project:
|
|
name: Project Checks
|
|
runs-on: ubuntu-18.04
|
|
timeout-minutes: 5
|
|
|
|
steps:
|
|
- uses: actions/checkout@v2
|
|
with:
|
|
path: src/github.com/containerd/containerd
|
|
fetch-depth: 100
|
|
|
|
- uses: containerd/project-checks@v1
|
|
with:
|
|
working-directory: src/github.com/containerd/containerd
|
|
|
|
#
|
|
# Protobuf checks
|
|
#
|
|
protos:
|
|
name: Protobuf
|
|
runs-on: ubuntu-18.04
|
|
timeout-minutes: 5
|
|
|
|
defaults:
|
|
run:
|
|
working-directory: src/github.com/containerd/containerd
|
|
|
|
steps:
|
|
- uses: actions/setup-go@v2
|
|
with:
|
|
go-version: '1.16.2'
|
|
|
|
- uses: actions/checkout@v2
|
|
with:
|
|
path: src/github.com/containerd/containerd
|
|
|
|
- name: Set env
|
|
shell: bash
|
|
run: |
|
|
echo "GOPATH=${{ github.workspace }}" >> $GITHUB_ENV
|
|
echo "GO111MODULE=off" >> $GITHUB_ENV
|
|
echo "${{ github.workspace }}/bin" >> $GITHUB_PATH
|
|
|
|
- name: Install protobuf
|
|
run: |
|
|
sudo env PATH=$PATH GOPATH=$GOPATH script/setup/install-protobuf
|
|
sudo chmod +x /usr/local/bin/protoc
|
|
sudo chmod og+rx /usr/local/include/google /usr/local/include/google/protobuf /usr/local/include/google/protobuf/compiler
|
|
sudo chmod -R og+r /usr/local/include/google/protobuf/
|
|
protoc --version
|
|
|
|
- run: script/setup/install-dev-tools
|
|
- run: make proto-fmt
|
|
- run: make check-protos check-api-descriptors
|
|
|
|
man:
|
|
name: Manpages
|
|
runs-on: ubuntu-18.04
|
|
timeout-minutes: 5
|
|
|
|
steps:
|
|
- uses: actions/setup-go@v2
|
|
with:
|
|
go-version: '1.16.2'
|
|
|
|
- name: Set env
|
|
shell: bash
|
|
run: |
|
|
echo "GOPATH=${{ github.workspace }}" >> $GITHUB_ENV
|
|
echo "${{ github.workspace }}/bin" >> $GITHUB_PATH
|
|
|
|
- uses: actions/checkout@v2
|
|
with:
|
|
path: src/github.com/containerd/containerd
|
|
|
|
- run: GO111MODULE=on go get github.com/cpuguy83/go-md2man/v2@v2.0.0
|
|
|
|
- run: make man
|
|
working-directory: src/github.com/containerd/containerd
|
|
|
|
# Make sure binaries compile with other platforms
|
|
crossbuild:
|
|
name: Crossbuild Binaries
|
|
needs: [project, linters, protos, man]
|
|
runs-on: ubuntu-18.04
|
|
timeout-minutes: 10
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
include:
|
|
- goos: linux
|
|
goarch: arm64
|
|
- goos: linux
|
|
goarch: arm
|
|
goarm: "7"
|
|
- goos: linux
|
|
goarch: arm
|
|
goarm: "5"
|
|
- goos: freebsd
|
|
goarch: amd64
|
|
- goos: freebsd
|
|
goarch: arm64
|
|
- goos: windows
|
|
goarch: arm
|
|
goarm: "7"
|
|
|
|
steps:
|
|
- uses: actions/setup-go@v2
|
|
with:
|
|
go-version: '1.16.2'
|
|
- name: Set env
|
|
shell: bash
|
|
run: |
|
|
echo "GOPATH=${{ github.workspace }}" >> $GITHUB_ENV
|
|
echo "${{ github.workspace }}/bin" >> $GITHUB_PATH
|
|
- uses: actions/checkout@v2
|
|
with:
|
|
path: src/github.com/containerd/containerd
|
|
- run: |
|
|
set -e -x
|
|
|
|
packages=""
|
|
platform="${{matrix.goos}}/${{matrix.goarch}}"
|
|
if [ -n "${{matrix.goarm}}" ]; then
|
|
platform+="/v${{matrix.goarm}}"
|
|
fi
|
|
|
|
case "${platform}" in
|
|
linux/arm/v5)
|
|
packages+=" crossbuild-essential-armel"
|
|
echo "CGO_ENABLED=1" >> $GITHUB_ENV
|
|
echo "CC=arm-linux-gnueabi-gcc" >> $GITHUB_ENV
|
|
;;
|
|
linux/arm/v7)
|
|
packages+=" crossbuild-essential-armhf"
|
|
echo "CGO_ENABLED=1" >> $GITHUB_ENV
|
|
echo "CC=arm-linux-gnueabihf-gcc" >> $GITHUB_ENV
|
|
;;
|
|
linux/arm64)
|
|
packages+=" crossbuild-essential-arm64"
|
|
echo "CGO_ENABLED=1" >> $GITHUB_ENV
|
|
echo "CC=aarch64-linux-gnu-gcc" >> $GITHUB_ENV
|
|
;;
|
|
windows/arm/v7)
|
|
echo "CGO_ENABLED=0" >> $GITHUB_ENV
|
|
;;
|
|
esac
|
|
|
|
if [ -n "${packages}" ]; then
|
|
sudo apt-get update && sudo apt-get install -y ${packages}
|
|
fi
|
|
name: install deps
|
|
- name: Build
|
|
working-directory: src/github.com/containerd/containerd
|
|
env:
|
|
GOOS: ${{matrix.goos}}
|
|
GOARCH: ${{matrix.goarch}}
|
|
GOARM: ${{matrix.goarm}}
|
|
run: |
|
|
make build
|
|
make binaries
|
|
|
|
#
|
|
# Build containerd binaries
|
|
#
|
|
binaries:
|
|
name: Binaries
|
|
runs-on: ${{ matrix.os }}
|
|
timeout-minutes: 10
|
|
needs: [project, linters, protos, man]
|
|
|
|
strategy:
|
|
matrix:
|
|
os: [ubuntu-18.04, macos-10.15, windows-2019]
|
|
|
|
steps:
|
|
- uses: actions/setup-go@v2
|
|
with:
|
|
go-version: '1.16.2'
|
|
|
|
- name: Set env
|
|
shell: bash
|
|
run: |
|
|
echo "GOPATH=${{ github.workspace }}" >> $GITHUB_ENV
|
|
echo "${{ github.workspace }}/bin" >> $GITHUB_PATH
|
|
|
|
- uses: actions/checkout@v2
|
|
with:
|
|
path: src/github.com/containerd/containerd
|
|
|
|
- name: Make
|
|
run: |
|
|
make build
|
|
make binaries
|
|
working-directory: src/github.com/containerd/containerd
|
|
|
|
#
|
|
# Integration and CRI tests
|
|
#
|
|
integration-windows:
|
|
name: Windows Integration
|
|
runs-on: windows-2019
|
|
timeout-minutes: 30
|
|
needs: [project, linters, protos, man]
|
|
env:
|
|
GOTEST: gotestsum --
|
|
|
|
defaults:
|
|
run:
|
|
shell: bash
|
|
working-directory: src/github.com/containerd/containerd
|
|
|
|
steps:
|
|
- uses: actions/setup-go@v2
|
|
with:
|
|
go-version: '1.16.2'
|
|
|
|
- uses: actions/checkout@v2
|
|
with:
|
|
path: src/github.com/containerd/containerd
|
|
|
|
- uses: actions/checkout@v2
|
|
with:
|
|
repository: Microsoft/hcsshim
|
|
path: src/github.com/Microsoft/hcsshim
|
|
|
|
- name: Set env
|
|
run: |
|
|
echo "GOPATH=${{ github.workspace }}" >> $GITHUB_ENV
|
|
echo "${{ github.workspace }}/bin" >> $GITHUB_PATH
|
|
echo "${{ github.workspace }}/src/github.com/containerd/containerd/bin" >> $GITHUB_PATH
|
|
|
|
- run: script/setup/install-dev-tools
|
|
|
|
- name: Binaries
|
|
env:
|
|
CGO_ENABLED: 1
|
|
run: |
|
|
set -o xtrace
|
|
mingw32-make.exe binaries
|
|
bindir="$(pwd)"
|
|
SHIM_COMMIT=$(grep 'Microsoft/hcsshim ' go.mod | awk '{print $2}')
|
|
cd ../../Microsoft/hcsshim
|
|
git fetch --tags origin "${SHIM_COMMIT}"
|
|
git checkout "${SHIM_COMMIT}"
|
|
GO111MODULE=on go build -mod=vendor -o "${bindir}/integration/client/containerd-shim-runhcs-v1.exe" ./cmd/containerd-shim-runhcs-v1
|
|
|
|
- run: script/setup/install-gotestsum
|
|
- name: Tests
|
|
env:
|
|
CGO_ENABLED: 1
|
|
GOTESTSUM_JUNITFILE: ${{github.workspace}}/test-unit-root.xml
|
|
run: mingw32-make.exe test root-test
|
|
|
|
- name: Integration 1
|
|
env:
|
|
CGO_ENABLED: 1
|
|
GOTESTSUM_JUNITFILE: ${{github.workspace}}/test-integration-serial-junit.xml
|
|
run: mingw32-make.exe integration
|
|
|
|
# Run the integration suite a second time. See discussion in github.com/containerd/containerd/pull/1759
|
|
- name: Integration 2
|
|
env:
|
|
TESTFLAGS_PARALLEL: 1
|
|
CGO_ENABLED: 1
|
|
GOTESTSUM_JUNITFILE: ${{github.workspace}}/test-integration-parallel-junit.xml
|
|
run: mingw32-make.exe integration
|
|
- uses: actions/upload-artifact@v2
|
|
if: always()
|
|
with:
|
|
name: TestResults Windows
|
|
path: |
|
|
${{github.workspace}}/*-junit.xml
|
|
|
|
integration-linux:
|
|
name: Linux Integration
|
|
runs-on: ubuntu-18.04
|
|
timeout-minutes: 30
|
|
needs: [project, linters, protos, man]
|
|
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
runtime: [io.containerd.runtime.v1.linux, io.containerd.runc.v1, io.containerd.runc.v2]
|
|
runc: [runc, crun]
|
|
exclude:
|
|
- runtime: io.containerd.runc.v1
|
|
runc: crun
|
|
- runtime: io.containerd.runtime.v1.linux
|
|
runc: crun
|
|
|
|
env:
|
|
GOTEST: gotestsum --
|
|
steps:
|
|
- uses: actions/setup-go@v2
|
|
with:
|
|
go-version: '1.16.2'
|
|
|
|
- uses: actions/checkout@v2
|
|
with:
|
|
path: src/github.com/containerd/containerd
|
|
|
|
- name: Set env
|
|
run: |
|
|
echo "GOPATH=${{ github.workspace }}" >> $GITHUB_ENV
|
|
echo "${{ github.workspace }}/bin" >> $GITHUB_PATH
|
|
|
|
- name: Install containerd dependencies
|
|
env:
|
|
RUNC_FLAVOR: ${{ matrix.runc }}
|
|
run: |
|
|
sudo -E PATH=$PATH script/setup/install-seccomp
|
|
sudo -E PATH=$PATH script/setup/install-runc
|
|
sudo -E PATH=$PATH script/setup/install-cni
|
|
sudo -E PATH=$PATH script/setup/install-critools
|
|
working-directory: src/github.com/containerd/containerd
|
|
|
|
- name: Install criu
|
|
run: |
|
|
sudo apt-get install -y \
|
|
libprotobuf-dev \
|
|
libprotobuf-c-dev \
|
|
protobuf-c-compiler \
|
|
protobuf-compiler \
|
|
python-protobuf \
|
|
libnl-3-dev \
|
|
libnet-dev \
|
|
libcap-dev \
|
|
python-future
|
|
wget https://github.com/checkpoint-restore/criu/archive/v3.13.tar.gz -O criu.tar.gz
|
|
tar -zxf criu.tar.gz
|
|
cd criu-3.13
|
|
sudo make install-criu
|
|
|
|
- name: Install containerd
|
|
env:
|
|
CGO_ENABLED: 1
|
|
run: |
|
|
make binaries
|
|
sudo make install
|
|
working-directory: src/github.com/containerd/containerd
|
|
|
|
- run: sudo -E PATH=$PATH script/setup/install-gotestsum
|
|
working-directory: src/github.com/containerd/containerd
|
|
- name: Tests
|
|
env:
|
|
GOPROXY: direct
|
|
GOTESTSUM_JUNITFILE: ${{github.workspace}}/test-unit-root-junit.xml
|
|
run: |
|
|
make test
|
|
sudo -E PATH=$PATH GOPATH=$GOPATH GOPROXY=$GOPROXY make root-test
|
|
working-directory: src/github.com/containerd/containerd
|
|
|
|
- name: Integration 1
|
|
env:
|
|
GOPROXY: direct
|
|
TEST_RUNTIME: ${{ matrix.runtime }}
|
|
RUNC_FLAVOR: ${{ matrix.runc }}
|
|
GOTESTSUM_JUNITFILE: ${{github.workspace}}/test-integration-serial-junit.xml
|
|
run: |
|
|
sudo GOPATH=$GOPATH GOPROXY=$GOPROXY TEST_RUNTIME=$TEST_RUNTIME RUNC_FLAVOR=$RUNC_FLAVOR make integration EXTRA_TESTFLAGS=-no-criu TESTFLAGS_RACE=-race
|
|
working-directory: src/github.com/containerd/containerd
|
|
|
|
# Run the integration suite a second time. See discussion in github.com/containerd/containerd/pull/1759
|
|
- name: Integration 2
|
|
env:
|
|
GOPROXY: direct
|
|
TEST_RUNTIME: ${{ matrix.runtime }}
|
|
RUNC_FLAVOR: ${{ matrix.runc }}
|
|
GOTESTSUM_JUNITFILE: ${{github.workspace}}/test-integration-parallel-junit.xml
|
|
run: |
|
|
sudo GOPATH=$GOPATH GOPROXY=$GOPROXY TEST_RUNTIME=$TEST_RUNTIME RUNC_FLAVOR=$RUNC_FLAVOR TESTFLAGS_PARALLEL=1 make integration EXTRA_TESTFLAGS=-no-criu
|
|
working-directory: src/github.com/containerd/containerd
|
|
|
|
# CRIU wouldn't work with overlay snapshotter yet.
|
|
# See https://github.com/containerd/containerd/pull/4708#issuecomment-724322294.
|
|
- name: CRIU Integration
|
|
env:
|
|
GOPROXY: direct
|
|
TEST_RUNTIME: ${{ matrix.runtime }}
|
|
RUNC_FLAVOR: ${{ matrix.runc }}
|
|
GOTESTSUM_JUNITFILE: ${{github.workspace}}/test-integration-criu-junit.xml
|
|
# crun doesn't have "checkpoint" command.
|
|
if: ${{ matrix.runc == 'runc' }}
|
|
run: |
|
|
sudo GOPATH=$GOPATH GOPROXY=$GOPROXY \
|
|
TEST_RUNTIME=$TEST_RUNTIME RUNC_FLAVOR=$RUNC_FLAVOR TESTFLAGS_PARALLEL=1 \
|
|
TEST_SNAPSHOTTER=native \
|
|
make integration EXTRA_TESTFLAGS='-run TestCheckpoint'
|
|
working-directory: src/github.com/containerd/containerd
|
|
|
|
- name: CRI Integration Test
|
|
env:
|
|
TEST_RUNTIME: ${{ matrix.runtime }}
|
|
run: |
|
|
CONTAINERD_RUNTIME=$TEST_RUNTIME make cri-integration
|
|
working-directory: src/github.com/containerd/containerd
|
|
|
|
- name: cri-tools critest
|
|
env:
|
|
TEST_RUNTIME: ${{ matrix.runtime }}
|
|
run: |
|
|
BDIR="$(mktemp -d -p $PWD)"
|
|
mkdir -p ${BDIR}/{root,state}
|
|
cat > ${BDIR}/config.toml <<EOF
|
|
[plugins.cri.containerd.default_runtime]
|
|
runtime_type = "${TEST_RUNTIME}"
|
|
EOF
|
|
sudo ls /etc/cni/net.d
|
|
sudo PATH=$PATH BDIR=$BDIR /usr/local/bin/containerd -a ${BDIR}/c.sock --config ${BDIR}/config.toml --root ${BDIR}/root --state ${BDIR}/state --log-level debug &> ${BDIR}/containerd-cri.log &
|
|
sudo PATH=$PATH BDIR=$BDIR /usr/local/bin/ctr -a ${BDIR}/c.sock version
|
|
sudo PATH=$PATH BDIR=$BDIR GOPATH=$GOPATH critest --report-dir "${{github.workspace}}/critestreport" --runtime-endpoint=unix:///${BDIR}/c.sock --parallel=8
|
|
TEST_RC=$?
|
|
test $TEST_RC -ne 0 && cat ${BDIR}/containerd-cri.log
|
|
sudo pkill containerd
|
|
sudo BDIR=$BDIR rm -rf ${BDIR}
|
|
test $TEST_RC -eq 0 || /bin/false
|
|
|
|
# Log the status of this VM to investigate issues like
|
|
# https://github.com/containerd/containerd/issues/4969
|
|
- name: Host Status
|
|
if: always()
|
|
run: |
|
|
set -x
|
|
mount
|
|
df
|
|
losetup -l
|
|
- uses: actions/upload-artifact@v2
|
|
if: always()
|
|
with:
|
|
name: TestResults ${{ matrix.runtime }} ${{matrix.runc}}
|
|
path: |
|
|
*-junit.xml
|
|
${{github.workspace}}/critestreport/*.xml
|
|
|
|
tests-mac-os:
|
|
name: MacOS unit tests
|
|
runs-on: macos-10.15
|
|
timeout-minutes: 10
|
|
needs: [project, linters, protos, man]
|
|
env:
|
|
GOTEST: gotestsum --
|
|
|
|
steps:
|
|
- uses: actions/setup-go@v2
|
|
with:
|
|
go-version: '1.16.2'
|
|
|
|
- uses: actions/checkout@v2
|
|
with:
|
|
path: src/github.com/containerd/containerd
|
|
|
|
- name: Set env
|
|
run: |
|
|
echo "GOPATH=${{ github.workspace }}" >> $GITHUB_ENV
|
|
echo "${{ github.workspace }}/bin" >> $GITHUB_PATH
|
|
|
|
- run: sudo -E PATH=$PATH script/setup/install-gotestsum
|
|
working-directory: src/github.com/containerd/containerd
|
|
- name: Tests
|
|
env:
|
|
GOPROXY: direct
|
|
GOTESTSUM_JUNITFILE: "${{ github.workspace }}/macos-test-junit.xml"
|
|
run: |
|
|
make test
|
|
working-directory: src/github.com/containerd/containerd
|
|
- uses: actions/upload-artifact@v2
|
|
if: always()
|
|
with:
|
|
name: TestResults MacOS
|
|
path: |
|
|
*-junit.xml
|
|
|
|
cgroup2:
|
|
name: CGroupsV2 and SELinux Integration
|
|
# nested virtualization is only available on macOS hosts
|
|
runs-on: macos-10.15
|
|
timeout-minutes: 45
|
|
needs: [project, linters, protos, man]
|
|
strategy:
|
|
matrix:
|
|
# Currently crun is disabled to decrease CI flakiness.
|
|
# We can enable crun again when we get a better CI infra.
|
|
runc: [runc]
|
|
env:
|
|
GOTEST: gotestsum --
|
|
steps:
|
|
- uses: actions/checkout@v2
|
|
|
|
- name: "Cache ~/.vagrant.d/boxes"
|
|
uses: actions/cache@v2
|
|
with:
|
|
path: ~/.vagrant.d/boxes
|
|
key: vagrant-${{ hashFiles('Vagrantfile*') }}
|
|
|
|
- name: Vagrant start
|
|
run: |
|
|
# Retry if it fails (download.fedoraproject.org returns 404 sometimes)
|
|
vagrant up || vagrant up
|
|
|
|
- name: Integration
|
|
env:
|
|
RUNC_FLAVOR: ${{ matrix.runc }}
|
|
SELINUX: Enforcing
|
|
GOTESTSUM_JUNITFILE: /tmp/test-integration-junit.xml
|
|
run: vagrant up --provision-with=selinux,install-runc,install-gotestsum,test-integration
|
|
|
|
- name: CRI test
|
|
env:
|
|
RUNC_FLAVOR: ${{ matrix.runc }}
|
|
SELINUX: Enforcing
|
|
REPORT_DIR: /tmp/critestreport
|
|
run: vagrant up --provision-with=selinux,install-runc,install-gotestsum,test-cri
|
|
- name: Get test reports
|
|
if: always()
|
|
run: |
|
|
set -e
|
|
vagrant plugin install vagrant-vbguest
|
|
vagrant plugin install vagrant-scp
|
|
vagrant scp :/tmp/test-integration-junit.xml "${{ github.workspace }}/"
|
|
vagrant scp :/tmp/critestreport "${{ github.workspace }}/critestreport"
|
|
- uses: actions/upload-artifact@v2
|
|
if: always()
|
|
with:
|
|
name: TestResults cgroup2 ${{ matrix.runtime }} ${{matrix.runc}}
|
|
path: |
|
|
${{github.workspace}}/*-junit.xml
|
|
${{github.workspace}}/critestreport/* |