86530c0afb
The metadata store is in the best place to handle events directly after the database has been updated. This prevents every user of the image store interface from having to know whether or not they are responsible for publishing events and avoid double events if the grpc local service is used. Signed-off-by: Derek McGowan <derek@mcg.dev>
71 lines
2.6 KiB
Go
71 lines
2.6 KiB
Go
/*
|
|
Copyright The containerd Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package images
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/containerd/containerd/v2/core/images"
|
|
"github.com/containerd/containerd/v2/pkg/tracing"
|
|
"github.com/containerd/errdefs"
|
|
|
|
runtime "k8s.io/cri-api/pkg/apis/runtime/v1"
|
|
)
|
|
|
|
// RemoveImage removes the image.
|
|
// TODO(random-liu): Update CRI to pass image reference instead of ImageSpec. (See
|
|
// kubernetes/kubernetes#46255)
|
|
// TODO(random-liu): We should change CRI to distinguish image id and image spec.
|
|
// Remove the whole image no matter the it's image id or reference. This is the
|
|
// semantic defined in CRI now.
|
|
func (c *GRPCCRIImageService) RemoveImage(ctx context.Context, r *runtime.RemoveImageRequest) (*runtime.RemoveImageResponse, error) {
|
|
span := tracing.SpanFromContext(ctx)
|
|
|
|
// TODO: Move to separate function
|
|
image, err := c.LocalResolve(r.GetImage().GetImage())
|
|
if err != nil {
|
|
if errdefs.IsNotFound(err) {
|
|
span.AddEvent(err.Error())
|
|
// return empty without error when image not found.
|
|
return &runtime.RemoveImageResponse{}, nil
|
|
}
|
|
return nil, fmt.Errorf("can not resolve %q locally: %w", r.GetImage().GetImage(), err)
|
|
}
|
|
span.SetAttributes(tracing.Attribute("image.id", image.ID))
|
|
// Remove all image references.
|
|
for i, ref := range image.References {
|
|
var opts []images.DeleteOpt
|
|
if i == len(image.References)-1 {
|
|
// Delete the last image reference synchronously to trigger garbage collection.
|
|
// This is best effort. It is possible that the image reference is deleted by
|
|
// someone else before this point.
|
|
opts = []images.DeleteOpt{images.SynchronousDelete()}
|
|
}
|
|
err = c.images.Delete(ctx, ref, opts...)
|
|
if err == nil || errdefs.IsNotFound(err) {
|
|
// Update image store to reflect the newest state in containerd.
|
|
if err := c.imageStore.Update(ctx, ref); err != nil {
|
|
return nil, fmt.Errorf("failed to update image reference %q for %q: %w", ref, image.ID, err)
|
|
}
|
|
continue
|
|
}
|
|
return nil, fmt.Errorf("failed to delete image reference %q for %q: %w", ref, image.ID, err)
|
|
}
|
|
return &runtime.RemoveImageResponse{}, nil
|
|
}
|