
go1.20.4 (released 2023-05-02) includes three security fixes to the html/template package, as well as bug fixes to the compiler, the runtime, and the crypto/subtle, crypto/tls, net/http, and syscall packages. See the Go 1.20.4 milestone on our issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.20.4+label%3ACherryPickApproved release notes: https://go.dev/doc/devel/release#go1.20.4 full diff: https://github.com/golang/go/compare/go1.20.3...go1.20.4 from the announcement: > These minor releases include 3 security fixes following the security policy: > > - html/template: improper sanitization of CSS values > > Angle brackets (`<>`) were not considered dangerous characters when inserted > into CSS contexts. Templates containing multiple actions separated by a '/' > character could result in unexpectedly closing the CSS context and allowing > for injection of unexpected HMTL, if executed with untrusted input. > > Thanks to Juho Nurminen of Mattermost for reporting this issue. > > This is CVE-2023-24539 and Go issue https://go.dev/issue/59720. > > - html/template: improper handling of JavaScript whitespace > > Not all valid JavaScript whitespace characters were considered to be > whitespace. Templates containing whitespace characters outside of the character > set "\t\n\f\r\u0020\u2028\u2029" in JavaScript contexts that also contain > actions may not be properly sanitized during execution. > > Thanks to Juho Nurminen of Mattermost for reporting this issue. > > This is CVE-2023-24540 and Go issue https://go.dev/issue/59721. > > - html/template: improper handling of empty HTML attributes > > Templates containing actions in unquoted HTML attributes (e.g. "attr={{.}}") > executed with empty input could result in output that would have unexpected > results when parsed due to HTML normalization rules. This may allow injection > of arbitrary attributes into tags. > > Thanks to Juho Nurminen of Mattermost for reporting this issue. > > This is CVE-2023-29400 and Go issue https://go.dev/issue/59722. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
159 lines
5.8 KiB
YAML
159 lines
5.8 KiB
YAML
on:
|
|
push:
|
|
branches:
|
|
- main
|
|
- "release/**"
|
|
tags:
|
|
- "v*" # Push events to matching v*, i.e. v1.0, v20.15.10
|
|
pull_request:
|
|
branches:
|
|
- main
|
|
- "release/**"
|
|
|
|
name: Release
|
|
|
|
env:
|
|
GO_VERSION: "1.20.4"
|
|
|
|
permissions: # added using https://github.com/step-security/secure-workflows
|
|
contents: read
|
|
|
|
jobs:
|
|
check:
|
|
name: Check Signed Tag
|
|
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
|
|
runs-on: ubuntu-20.04
|
|
timeout-minutes: 5
|
|
outputs:
|
|
stringver: ${{ steps.contentrel.outputs.stringver }}
|
|
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v3
|
|
with:
|
|
ref: ${{ github.ref }}
|
|
path: src/github.com/containerd/containerd
|
|
|
|
- name: Check signature
|
|
run: |
|
|
releasever=${{ github.ref }}
|
|
releasever="${releasever#refs/tags/}"
|
|
TAGCHECK=$(git tag -v ${releasever} 2>&1 >/dev/null) ||
|
|
echo "${TAGCHECK}" | grep -q "error" && {
|
|
echo "::error::tag ${releasever} is not a signed tag. Failing release process."
|
|
exit 1
|
|
} || {
|
|
echo "Tag ${releasever} is signed."
|
|
exit 0
|
|
}
|
|
working-directory: src/github.com/containerd/containerd
|
|
|
|
- name: Release content
|
|
id: contentrel
|
|
run: |
|
|
RELEASEVER=${{ github.ref }}
|
|
echo "stringver=${RELEASEVER#refs/tags/v}" >> $GITHUB_OUTPUT
|
|
git tag -l ${RELEASEVER#refs/tags/} -n20000 | tail -n +3 | cut -c 5- >release-notes.md
|
|
working-directory: src/github.com/containerd/containerd
|
|
|
|
- name: Save release notes
|
|
uses: actions/upload-artifact@v3
|
|
with:
|
|
name: containerd-release-notes
|
|
path: src/github.com/containerd/containerd/release-notes.md
|
|
|
|
build:
|
|
name: Build Release Binaries
|
|
runs-on: ubuntu-20.04
|
|
timeout-minutes: 30
|
|
strategy:
|
|
matrix:
|
|
include:
|
|
# Ubuntu 22.04 can't be used until we drop support for binary compatibility with dynamically-linked glibc 2.17 (CentOS 7).
|
|
# https://github.com/containerd/containerd/issues/7255
|
|
# https://github.com/containerd/containerd/issues/7961
|
|
- dockerfile-ubuntu: 20.04
|
|
dockerfile-platform: linux/amd64
|
|
- dockerfile-ubuntu: 20.04
|
|
dockerfile-platform: linux/arm64
|
|
- dockerfile-ubuntu: 20.04
|
|
dockerfile-platform: linux/ppc64le
|
|
- dockerfile-ubuntu: 20.04
|
|
dockerfile-platform: linux/s390x
|
|
- dockerfile-ubuntu: 20.04
|
|
dockerfile-platform: linux/riscv64
|
|
- dockerfile-ubuntu: 20.04
|
|
dockerfile-platform: windows/amd64
|
|
steps:
|
|
- name: Set RELEASE_VER
|
|
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
|
|
shell: bash
|
|
run: |
|
|
releasever=${{ github.ref }}
|
|
releasever="${releasever#refs/tags/}"
|
|
echo "RELEASE_VER=${releasever}" >> $GITHUB_ENV
|
|
- name: Checkout containerd
|
|
uses: actions/checkout@v3
|
|
with:
|
|
# Intentionally use github.repository instead of containerd/containerd to
|
|
# make this action runnable on forks.
|
|
# See https://github.com/containerd/containerd/issues/5098 for the context.
|
|
repository: ${{ github.repository }}
|
|
ref: ${{ github.ref }}
|
|
path: src/github.com/containerd/containerd
|
|
|
|
- name: Setup buildx instance
|
|
uses: docker/setup-buildx-action@v2
|
|
with:
|
|
use: true
|
|
- uses: crazy-max/ghaction-github-runtime@v2 # sets up needed vars for caching to github
|
|
- name: Make
|
|
shell: bash
|
|
run: |
|
|
cache="--cache-from=type=gha,scope=containerd-release --cache-to=type=gha,scope=containerd-release"
|
|
if [[ "${PLATFORM}" =~ "windows" ]]; then
|
|
# For Windows the cni build script generates a config but shells out to powershell (and also assume it is running on windows) to get a gateway and subnet.
|
|
# The values provided here are taken from packages that we previously generated.
|
|
export GATEWAY=172.21.16.1
|
|
export PREFIX_LEN=12
|
|
BUILD_ARGS="--build-arg GATEWAY --build-arg PREFIX_LEN"
|
|
fi
|
|
docker buildx build ${cache} --build-arg RELEASE_VER --build-arg UBUNTU_VERSION=${{ matrix.dockerfile-ubuntu }} --build-arg GO_VERSION ${BUILD_ARGS} -f .github/workflows/release/Dockerfile --platform=${PLATFORM} -o releases/ .
|
|
echo PLATFORM_CLEAN=${PLATFORM/\//-} >> $GITHUB_ENV
|
|
|
|
# Remove symlinks since we don't want these in the release Artifacts
|
|
find ./releases/ -maxdepth 1 -type l | xargs rm
|
|
working-directory: src/github.com/containerd/containerd
|
|
env:
|
|
PLATFORM: ${{ matrix.dockerfile-platform }}
|
|
- name: Save Artifacts
|
|
uses: actions/upload-artifact@v3
|
|
with:
|
|
name: release-tars-${{env.PLATFORM_CLEAN}}
|
|
path: src/github.com/containerd/containerd/releases/*.tar.gz*
|
|
|
|
release:
|
|
name: Create containerd Release
|
|
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
|
|
permissions:
|
|
contents: write
|
|
runs-on: ubuntu-20.04
|
|
timeout-minutes: 10
|
|
needs: [build, check]
|
|
steps:
|
|
- name: Download builds and release notes
|
|
uses: actions/download-artifact@v3
|
|
with:
|
|
path: builds
|
|
- name: Create Release
|
|
uses: softprops/action-gh-release@v1
|
|
with:
|
|
token: ${{ secrets.GITHUB_TOKEN }}
|
|
fail_on_unmatched_files: true
|
|
name: containerd ${{ needs.check.outputs.stringver }}
|
|
draft: false
|
|
prerelease: ${{ contains(github.ref, 'beta') || contains(github.ref, 'rc') }}
|
|
body_path: ./builds/containerd-release-notes/release-notes.md
|
|
files: |
|
|
builds/release-tars-**/*
|