 fdf7a795bc
			
		
	
	fdf7a795bc
	
	
	
		
			
			Fix commentary to be clear that the RFC1035 2.3.1 rules are not explicitly enforced by the identifiers regex. Add a test to show the lessened restrictions for digits to follow hyphen and period. Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
		
			
				
	
	
		
			74 lines
		
	
	
		
			1.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			74 lines
		
	
	
		
			1.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| /*
 | |
|    Copyright The containerd Authors.
 | |
| 
 | |
|    Licensed under the Apache License, Version 2.0 (the "License");
 | |
|    you may not use this file except in compliance with the License.
 | |
|    You may obtain a copy of the License at
 | |
| 
 | |
|        http://www.apache.org/licenses/LICENSE-2.0
 | |
| 
 | |
|    Unless required by applicable law or agreed to in writing, software
 | |
|    distributed under the License is distributed on an "AS IS" BASIS,
 | |
|    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | |
|    See the License for the specific language governing permissions and
 | |
|    limitations under the License.
 | |
| */
 | |
| 
 | |
| package identifiers
 | |
| 
 | |
| import (
 | |
| 	"strings"
 | |
| 	"testing"
 | |
| 
 | |
| 	"github.com/containerd/containerd/errdefs"
 | |
| )
 | |
| 
 | |
| func TestValidIdentifiers(t *testing.T) {
 | |
| 	for _, input := range []string{
 | |
| 		"default",
 | |
| 		"Default",
 | |
| 		t.Name(),
 | |
| 		"default-default",
 | |
| 		"containerd.io",
 | |
| 		"foo.boo",
 | |
| 		"swarmkit.docker.io",
 | |
| 		"0912341234",
 | |
| 		"task.0.0123456789",
 | |
| 		"container.system-75-f19a.00",
 | |
| 		"underscores_are_allowed",
 | |
| 		strings.Repeat("a", maxLength),
 | |
| 	} {
 | |
| 		t.Run(input, func(t *testing.T) {
 | |
| 			if err := Validate(input); err != nil {
 | |
| 				t.Fatalf("unexpected error: %v != nil", err)
 | |
| 			}
 | |
| 		})
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestInvalidIdentifiers(t *testing.T) {
 | |
| 	for _, input := range []string{
 | |
| 		"",
 | |
| 		".foo..foo",
 | |
| 		"foo/foo",
 | |
| 		"foo/..",
 | |
| 		"foo..foo",
 | |
| 		"foo.-boo",
 | |
| 		"-foo.boo",
 | |
| 		"foo.boo-",
 | |
| 		"but__only_tasteful_underscores",
 | |
| 		"zn--e9.org", // or something like it!
 | |
| 		"default--default",
 | |
| 		strings.Repeat("a", maxLength+1),
 | |
| 	} {
 | |
| 
 | |
| 		t.Run(input, func(t *testing.T) {
 | |
| 			if err := Validate(input); err == nil {
 | |
| 				t.Fatal("expected invalid error")
 | |
| 			} else if !errdefs.IsInvalidArgument(err) {
 | |
| 				t.Fatal("error should be an invalid identifier error")
 | |
| 			}
 | |
| 		})
 | |
| 	}
 | |
| }
 |