 e84a84a5a9
			
		
	
	e84a84a5a9
	
	
	
		
			
			Currently auth.docker.io uses a custom auth scope for (docker) plugins `repository(plugin):<repo>:<perms>`. This makes it impossible to use containerd distribution tooling to fetch plugins without also supplying a totally custom authorizer. This changes allows clients to set the correct scope on the context. It's a little bit nasty but "works". I'm also a bit suspect of some a couple of these unexported context functrions. Before the primary one used `contextWithRepositoryScope` overwrites any scope value and there is another one that appends the scope value. With this change they both append... Signed-off-by: Brian Goff <cpuguy83@gmail.com>
		
			
				
	
	
		
			98 lines
		
	
	
		
			3.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			98 lines
		
	
	
		
			3.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| /*
 | |
|    Copyright The containerd Authors.
 | |
| 
 | |
|    Licensed under the Apache License, Version 2.0 (the "License");
 | |
|    you may not use this file except in compliance with the License.
 | |
|    You may obtain a copy of the License at
 | |
| 
 | |
|        http://www.apache.org/licenses/LICENSE-2.0
 | |
| 
 | |
|    Unless required by applicable law or agreed to in writing, software
 | |
|    distributed under the License is distributed on an "AS IS" BASIS,
 | |
|    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | |
|    See the License for the specific language governing permissions and
 | |
|    limitations under the License.
 | |
| */
 | |
| 
 | |
| package docker
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"fmt"
 | |
| 	"net/url"
 | |
| 	"sort"
 | |
| 	"strings"
 | |
| 
 | |
| 	"github.com/containerd/containerd/reference"
 | |
| )
 | |
| 
 | |
| // repositoryScope returns a repository scope string such as "repository:foo/bar:pull"
 | |
| // for "host/foo/bar:baz".
 | |
| // When push is true, both pull and push are added to the scope.
 | |
| func repositoryScope(refspec reference.Spec, push bool) (string, error) {
 | |
| 	u, err := url.Parse("dummy://" + refspec.Locator)
 | |
| 	if err != nil {
 | |
| 		return "", err
 | |
| 	}
 | |
| 	s := "repository:" + strings.TrimPrefix(u.Path, "/") + ":pull"
 | |
| 	if push {
 | |
| 		s += ",push"
 | |
| 	}
 | |
| 	return s, nil
 | |
| }
 | |
| 
 | |
| // tokenScopesKey is used for the key for context.WithValue().
 | |
| // value: []string (e.g. {"registry:foo/bar:pull"})
 | |
| type tokenScopesKey struct{}
 | |
| 
 | |
| // contextWithRepositoryScope returns a context with tokenScopesKey{} and the repository scope value.
 | |
| func contextWithRepositoryScope(ctx context.Context, refspec reference.Spec, push bool) (context.Context, error) {
 | |
| 	s, err := repositoryScope(refspec, push)
 | |
| 	if err != nil {
 | |
| 		return nil, err
 | |
| 	}
 | |
| 	return WithScope(ctx, s), nil
 | |
| }
 | |
| 
 | |
| // WithScope appends a custom registry auth scope to the context.
 | |
| func WithScope(ctx context.Context, scope string) context.Context {
 | |
| 	var scopes []string
 | |
| 	if v := ctx.Value(tokenScopesKey{}); v != nil {
 | |
| 		scopes = v.([]string)
 | |
| 		scopes = append(scopes, scope)
 | |
| 	} else {
 | |
| 		scopes = []string{scope}
 | |
| 	}
 | |
| 	return context.WithValue(ctx, tokenScopesKey{}, scopes)
 | |
| }
 | |
| 
 | |
| // contextWithAppendPullRepositoryScope is used to append repository pull
 | |
| // scope into existing scopes indexed by the tokenScopesKey{}.
 | |
| func contextWithAppendPullRepositoryScope(ctx context.Context, repo string) context.Context {
 | |
| 	return WithScope(ctx, fmt.Sprintf("repository:%s:pull", repo))
 | |
| }
 | |
| 
 | |
| // getTokenScopes returns deduplicated and sorted scopes from ctx.Value(tokenScopesKey{}) and common scopes.
 | |
| func getTokenScopes(ctx context.Context, common []string) []string {
 | |
| 	var scopes []string
 | |
| 	if x := ctx.Value(tokenScopesKey{}); x != nil {
 | |
| 		scopes = append(scopes, x.([]string)...)
 | |
| 	}
 | |
| 
 | |
| 	scopes = append(scopes, common...)
 | |
| 	sort.Strings(scopes)
 | |
| 
 | |
| 	l := 0
 | |
| 	for idx := 1; idx < len(scopes); idx++ {
 | |
| 		// Note: this comparison is unaware of the scope grammar (https://docs.docker.com/registry/spec/auth/scope/)
 | |
| 		// So, "repository:foo/bar:pull,push" != "repository:foo/bar:push,pull", although semantically they are equal.
 | |
| 		if scopes[l] == scopes[idx] {
 | |
| 			continue
 | |
| 		}
 | |
| 
 | |
| 		l++
 | |
| 		scopes[l] = scopes[idx]
 | |
| 	}
 | |
| 	return scopes[:l+1]
 | |
| }
 |