0f51aa874d
When unpacking a TAR archive, containerd preserves file's owner: https://github.com/containerd/containerd/blob/main/archive/tar.go#L384 In some cases this behavior is not desired. In current implementation we avoid `Lchown` on Windows. Another case when this should be skipped is when using native snapshotter on darwin and running as non-root user. This PR extracts a generic option - `WithNoSameOwner` (same as `tar --no-same-owner`) to skip `Lchown` when its not required. Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
48 lines
1.3 KiB
Go
48 lines
1.3 KiB
Go
/*
|
|
Copyright The containerd Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package apply
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
"os"
|
|
|
|
"github.com/containerd/containerd/archive"
|
|
"github.com/containerd/containerd/mount"
|
|
)
|
|
|
|
func apply(ctx context.Context, mounts []mount.Mount, r io.Reader) error {
|
|
// We currently do not support mounts nor bind mounts on MacOS in the containerd daemon.
|
|
// Using this as an exception to enable native snapshotter and allow further research.
|
|
if len(mounts) == 1 && mounts[0].Type == "bind" {
|
|
opts := []archive.ApplyOpt{}
|
|
|
|
if os.Getuid() != 0 {
|
|
opts = append(opts, archive.WithNoSameOwner())
|
|
}
|
|
|
|
path := mounts[0].Source
|
|
_, err := archive.Apply(ctx, path, r, opts...)
|
|
return err
|
|
}
|
|
|
|
return mount.WithTempMount(ctx, mounts, func(root string) error {
|
|
_, err := archive.Apply(ctx, root, r)
|
|
return err
|
|
})
|
|
}
|