
With btrfs-prog 4.17 as shipped with Alpine 3.8 the btrfs tests fail with: ERROR: '/dev/loop1' is too small to make a usable filesystem ERROR: minimum size for each btrfs device is 114294784 btrfs-prog commit 997f9977c243 ("btrfs-progs: mkfs: Prevent temporary system chunk to use space in reserved 1M range") changed the code to compute the minimum size for a btrfs size and is the likely reason for this error. Increase the size of the loop back device to 128MB for the btrfs test. With this fix, the containerd tests pass on Alpine 3.8, tested in LinuxKit with kernel 4.14.53. fixes #2447 Signed-off-by: Rolf Neugebauer <rolf.neugebauer@gmail.com>
182 lines
4.9 KiB
Go
182 lines
4.9 KiB
Go
// +build linux,!no_btrfs
|
|
|
|
/*
|
|
Copyright The containerd Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package btrfs
|
|
|
|
import (
|
|
"context"
|
|
"io/ioutil"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/containerd/containerd/mount"
|
|
"github.com/containerd/containerd/pkg/testutil"
|
|
"github.com/containerd/containerd/snapshots"
|
|
"github.com/containerd/containerd/snapshots/testsuite"
|
|
"github.com/pkg/errors"
|
|
"golang.org/x/sys/unix"
|
|
)
|
|
|
|
func boltSnapshotter(t *testing.T) func(context.Context, string) (snapshots.Snapshotter, func() error, error) {
|
|
mkbtrfs, err := exec.LookPath("mkfs.btrfs")
|
|
if err != nil {
|
|
t.Skipf("could not find mkfs.btrfs: %v", err)
|
|
}
|
|
|
|
// TODO: Check for btrfs in /proc/module and skip if not loaded
|
|
|
|
return func(ctx context.Context, root string) (snapshots.Snapshotter, func() error, error) {
|
|
|
|
loopbackSize := int64(128 << 20) // 128 MB
|
|
// mkfs.btrfs creates a fs which has a blocksize equal to the system default pagesize. If that pagesize
|
|
// is > 4KB, mounting the fs will fail unless we increase the size of the file used by mkfs.btrfs
|
|
if os.Getpagesize() > 4096 {
|
|
loopbackSize = int64(650 << 20) // 650 MB
|
|
}
|
|
deviceName, cleanupDevice, err := testutil.NewLoopback(loopbackSize)
|
|
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
|
|
if out, err := exec.Command(mkbtrfs, deviceName).CombinedOutput(); err != nil {
|
|
cleanupDevice()
|
|
return nil, nil, errors.Wrapf(err, "failed to make btrfs filesystem (out: %q)", out)
|
|
}
|
|
if out, err := exec.Command("mount", deviceName, root).CombinedOutput(); err != nil {
|
|
cleanupDevice()
|
|
return nil, nil, errors.Wrapf(err, "failed to mount device %s (out: %q)", deviceName, out)
|
|
}
|
|
|
|
snapshotter, err := NewSnapshotter(root)
|
|
if err != nil {
|
|
cleanupDevice()
|
|
return nil, nil, errors.Wrap(err, "failed to create new snapshotter")
|
|
}
|
|
|
|
return snapshotter, func() error {
|
|
if err := snapshotter.Close(); err != nil {
|
|
return err
|
|
}
|
|
err := mount.UnmountAll(root, unix.MNT_DETACH)
|
|
if cerr := cleanupDevice(); cerr != nil {
|
|
err = errors.Wrap(cerr, "device cleanup failed")
|
|
}
|
|
return err
|
|
}, nil
|
|
}
|
|
}
|
|
|
|
func TestBtrfs(t *testing.T) {
|
|
testutil.RequiresRoot(t)
|
|
testsuite.SnapshotterSuite(t, "Btrfs", boltSnapshotter(t))
|
|
}
|
|
|
|
func TestBtrfsMounts(t *testing.T) {
|
|
testutil.RequiresRoot(t)
|
|
ctx := context.Background()
|
|
|
|
// create temporary directory for mount point
|
|
mountPoint, err := ioutil.TempDir("", "containerd-btrfs-test")
|
|
if err != nil {
|
|
t.Fatal("could not create mount point for btrfs test", err)
|
|
}
|
|
defer os.RemoveAll(mountPoint)
|
|
t.Log("temporary mount point created", mountPoint)
|
|
|
|
root, err := ioutil.TempDir(mountPoint, "TestBtrfsPrepare-")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(root)
|
|
|
|
b, c, err := boltSnapshotter(t)(ctx, root)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer c()
|
|
|
|
target := filepath.Join(root, "test")
|
|
mounts, err := b.Prepare(ctx, target, "")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
t.Log(mounts)
|
|
|
|
for _, mount := range mounts {
|
|
if mount.Type != "btrfs" {
|
|
t.Fatalf("wrong mount type: %v != btrfs", mount.Type)
|
|
}
|
|
|
|
// assumes the first, maybe incorrect in the future
|
|
if !strings.HasPrefix(mount.Options[0], "subvolid=") {
|
|
t.Fatalf("no subvolid option in %v", mount.Options)
|
|
}
|
|
}
|
|
|
|
if err := os.MkdirAll(target, 0755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := mount.All(mounts, target); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer testutil.Unmount(t, target)
|
|
|
|
// write in some data
|
|
if err := ioutil.WriteFile(filepath.Join(target, "foo"), []byte("content"), 0777); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// TODO(stevvooe): We don't really make this with the driver, but that
|
|
// might prove annoying in practice.
|
|
if err := os.MkdirAll(filepath.Join(root, "snapshots"), 0755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if err := b.Commit(ctx, filepath.Join(root, "snapshots/committed"), filepath.Join(root, "test")); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
target = filepath.Join(root, "test2")
|
|
mounts, err = b.Prepare(ctx, target, filepath.Join(root, "snapshots/committed"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if err := os.MkdirAll(target, 0755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if err := mount.All(mounts, target); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer testutil.Unmount(t, target)
|
|
|
|
// TODO(stevvooe): Verify contents of "foo"
|
|
if err := ioutil.WriteFile(filepath.Join(target, "bar"), []byte("content"), 0777); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if err := b.Commit(ctx, filepath.Join(root, "snapshots/committed2"), target); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|