containerd/plugins
Akihiro Suda b2f254fff0
cri: make read-only mounts recursively read-only
Prior to this commit, `readOnly` volumes were not recursively read-only and
could result in compromise of data;
e.g., even if `/mnt` was mounted as read-only, its submounts such as
`/mnt/usbstorage` were not read-only.

This commit utilizes runc's "rro" bind mount option to make read-only bind
mounts literally read-only. The "rro" bind mount options is implemented by
calling `mount_setattr(2)` with `MOUNT_ATTR_RDONLY` and `AT_RECURSIVE`.

The "rro" bind mount options requires kernel >= 5.12, with runc >= 1.1 or
a compatible runtime such as crun >= 1.4.

When the "rro" bind mount options is not available, containerd falls back
to the legacy non-recursive read-only mounts by default.

The behavior is configurable via `/etc/containerd/config.toml`:
```toml
version = 2
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runc]
  # treat_ro_mounts_as_rro ("Enabled"|"IfPossible"|"Disabled")
  # treats read-only mounts as recursive read-only mounts.
  # An empty string means "IfPossible".
  # "Enabled" requires Linux kernel v5.12 or later.
  # This configuration does not apply to non-volume mounts such as "/sys/fs/cgroup".
  treat_ro_mounts_as_rro = ""
```

Replaces:
- kubernetes/enhancements issue 3857
- kubernetes/enhancements PR 3858

Note: this change does not affect non-CRI clients such as ctr, nerdctl, and Docker/Moby.
RRO mounts have been supported since nerdctl v0.14 (containerd/nerdctl PR 511)
and Docker v25 (moby/moby PR 45278).

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2024-02-01 09:39:36 +09:00
..
content/local Switch to new errdefs package 2024-01-25 22:18:45 -08:00
cri cri: make read-only mounts recursively read-only 2024-02-01 09:39:36 +09:00
diff Switch to new errdefs package 2024-01-25 22:18:45 -08:00
gc Move gc to pkg/gc 2024-01-17 09:55:12 -08:00
imageverifier Move pkg/tomlext to internal/tomlext 2024-01-17 09:57:37 -08:00
leases Move gc to pkg/gc 2024-01-17 09:55:12 -08:00
metadata Switch to new errdefs package 2024-01-25 22:18:45 -08:00
restart Move runtime to core/runtime 2024-01-17 09:58:04 -08:00
sandbox Switch to new errdefs package 2024-01-25 22:18:45 -08:00
services Switch to new errdefs package 2024-01-25 22:18:45 -08:00
snapshots Switch to new errdefs package 2024-01-25 22:18:45 -08:00
streaming Switch to new errdefs package 2024-01-25 22:18:45 -08:00
transfer Switch to new errdefs package 2024-01-25 22:18:45 -08:00
types.go Move cri base plugin to CRI runtime service 2024-01-28 20:57:18 -08:00