
Tests in pkg/cri/[sb]server/container_create_linux_test.go depends on go:noinline since Go 1.21. e.g., > ``` > === FAIL: pkg/cri/sbserver TestGenerateSeccompSecurityProfileSpecOpts/should_set_default_seccomp_when_seccomp_is_runtime/default (0.00s) > container_create_linux_test.go:1013: > Error Trace: /home/runner/work/containerd/containerd/pkg/cri/sbserver/container_create_linux_test.go:1013 > Error: Not equal: > expected: 0x263d880 > actual : 0x263cbc0 > Test: TestGenerateSeccompSecurityProfileSpecOpts/should_set_default_seccomp_when_seccomp_is_runtime/default > ``` See comments in PR 8957. Thanks to Wei Fu for analyzing this. Co-authored-by: Wei Fu <fuweid89@gmail.com> Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
65 lines
2.0 KiB
Go
65 lines
2.0 KiB
Go
/*
|
|
Copyright The containerd Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package seccomp
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"os"
|
|
|
|
"github.com/containerd/containerd/containers"
|
|
"github.com/containerd/containerd/oci"
|
|
"github.com/opencontainers/runtime-spec/specs-go"
|
|
)
|
|
|
|
// WithProfile receives the name of a file stored on disk comprising a json
|
|
// formatted seccomp profile, as specified by the opencontainers/runtime-spec.
|
|
// The profile is read from the file, unmarshaled, and set to the spec.
|
|
//
|
|
// FIXME: pkg/cri/[sb]server/container_create_linux_test.go depends on go:noinline
|
|
// since Go 1.21.
|
|
//
|
|
//go:noinline
|
|
func WithProfile(profile string) oci.SpecOpts {
|
|
return func(_ context.Context, _ oci.Client, _ *containers.Container, s *specs.Spec) error {
|
|
s.Linux.Seccomp = &specs.LinuxSeccomp{}
|
|
f, err := os.ReadFile(profile)
|
|
if err != nil {
|
|
return fmt.Errorf("cannot load seccomp profile %q: %v", profile, err)
|
|
}
|
|
if err := json.Unmarshal(f, s.Linux.Seccomp); err != nil {
|
|
return fmt.Errorf("decoding seccomp profile failed %q: %v", profile, err)
|
|
}
|
|
return nil
|
|
}
|
|
}
|
|
|
|
// WithDefaultProfile sets the default seccomp profile to the spec.
|
|
// Note: must follow the setting of process capabilities
|
|
//
|
|
// FIXME: pkg/cri/[sb]server/container_create_linux_test.go depends on go:noinline
|
|
// since Go 1.21.
|
|
//
|
|
//go:noinline
|
|
func WithDefaultProfile() oci.SpecOpts {
|
|
return func(_ context.Context, _ oci.Client, _ *containers.Container, s *specs.Spec) error {
|
|
s.Linux.Seccomp = DefaultProfile(s)
|
|
return nil
|
|
}
|
|
}
|