
Working from feedback on the existing implementation, we have now introduced a central metadata object to represent the lifecycle and pin the resources required to implement what people today know as containers. This includes the runtime specification and the root filesystem snapshots. We also allow arbitrary labeling of the container. Such provisions will bring the containerd definition of container closer to what is expected by users. The objects that encompass today's ContainerService, centered around the runtime, will be known as tasks. These tasks take on the existing lifecycle behavior of containerd's containers, which means that they are deleted when they exit. Largely, there are no other changes except for naming. The `Container` object will operate purely as a metadata object. No runtime state will be held on `Container`. It only informs the execution service on what is required for creating tasks and the resources in use by that container. The resources referenced by that container will be deleted when the container is deleted, if not in use. In this sense, users can create, list, label and delete containers in a similar way as they do with docker today, without the complexity of runtime locks that plagues current implementations. Signed-off-by: Stephen J Day <stephen.day@docker.com>
64 lines
1.2 KiB
Go
64 lines
1.2 KiB
Go
package plugin
|
|
|
|
// TaskMonitor provides an interface for monitoring of containers within containerd
|
|
type TaskMonitor interface {
|
|
// Monitor adds the provided container to the monitor
|
|
Monitor(Task) error
|
|
// Stop stops and removes the provided container from the monitor
|
|
Stop(Task) error
|
|
// Events emits events from the monitor
|
|
Events(chan<- *Event)
|
|
}
|
|
|
|
func NewMultiTaskMonitor(monitors ...TaskMonitor) TaskMonitor {
|
|
return &multiTaskMonitor{
|
|
monitors: monitors,
|
|
}
|
|
}
|
|
|
|
func NewNoopMonitor() TaskMonitor {
|
|
return &noopTaskMonitor{}
|
|
}
|
|
|
|
type noopTaskMonitor struct {
|
|
}
|
|
|
|
func (mm *noopTaskMonitor) Monitor(c Task) error {
|
|
return nil
|
|
}
|
|
|
|
func (mm *noopTaskMonitor) Stop(c Task) error {
|
|
return nil
|
|
}
|
|
|
|
func (mm *noopTaskMonitor) Events(events chan<- *Event) {
|
|
}
|
|
|
|
type multiTaskMonitor struct {
|
|
monitors []TaskMonitor
|
|
}
|
|
|
|
func (mm *multiTaskMonitor) Monitor(c Task) error {
|
|
for _, m := range mm.monitors {
|
|
if err := m.Monitor(c); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (mm *multiTaskMonitor) Stop(c Task) error {
|
|
for _, m := range mm.monitors {
|
|
if err := m.Stop(c); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (mm *multiTaskMonitor) Events(events chan<- *Event) {
|
|
for _, m := range mm.monitors {
|
|
m.Events(events)
|
|
}
|
|
}
|